From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30047.outbound.protection.outlook.com [40.107.3.47]) by dpdk.org (Postfix) with ESMTP id 98BBD1C01; Wed, 25 Jul 2018 15:14:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cC1SvS7Yj7EVe2Aa9GrJpAy+/GMJM8896H5L4v8DJfw=; b=S58ac3HKe3/bMQS7+4BlhGhdloYu4HvgnL3UTv9DTSksQ5hHWuigqerZM/bWFoWaiZJWhWw7Mah1UGpxH9z9fgwepm8DPiSXYW+5fG0GNuRID2JvVvHCNf5s6+hBdx/GAhswFRD8ZcGsx3kK6ZqZwxnWb9LBbIyj0gpmXJAQlJg= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB5036.eurprd05.prod.outlook.com (20.176.236.208) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.21; Wed, 25 Jul 2018 13:14:44 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::52a:650b:ae10:fc3]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::52a:650b:ae10:fc3%3]) with mapi id 15.20.0952.022; Wed, 25 Jul 2018 13:14:44 +0000 From: Shahaf Shuler To: Yongseok Koh CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix queue rollback when starting device Thread-Index: AQHUIsfBH+gWEHAtmk+17MGJK/oV7KSf7TSQ Date: Wed, 25 Jul 2018 13:14:44 +0000 Message-ID: References: <20180723205704.1999-1-yskoh@mellanox.com> In-Reply-To: <20180723205704.1999-1-yskoh@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB5036; 6:U4lHTDxtMjFr6b4hLwoGhI3Y4BNHSVho2t5wAIqEov/j+IJEGJelW6hbTCIJK2kZf/zw+nb3oqDFUNiGHqVl0Ef733pF7eVXN7LEE9r3diPuRaxMkTuHJMN3wbDuEKYJdI20qHfxwKYFzXN/tvBbtoPFSCcDKdZz/UH0mXPi9mpD8S3cFq3g1Vq0qc2XnvldVnNM3dtawMySqkTJaFTjBkybFDKTA9R9Arb9LNPVTqbDLJSu0pmEzo6Wt5RkU+WtXR5HisKBEnTPi0OXgo1KgCCp/B/l2c5Zfwxv8/3lOaSxU36nTB0g+ctgzXB7q3sN3gYVAIQmcMhA9NWLFAZXjSiwBHVtUBxAe7qhBuD4s9uvn+JgKP7o/7DKmdI4gscU7tItIQ216X7KMQSfE/hQys+aVqYX8e+OdnGqUsWq75SYIUW2HSnx/EiioXW+b06tzicKFXRIdoIPtK+nYiwWlQ==; 5:dBrhik0k9w/MZfY3i50H8KtXq1fNsz14q0bazck8LnCSvRdUHq9XMqR/Hx8DZV6tS/XFUdgymj9uJRLAtIcVlImFv0SquYZLglssxdREhfE8fQ5mI3N0RDKhWmbJaz1UKXvMIH49hJqJnlHh0o5mF3DNkwwEIqxljbVL1GtZLss=; 7:sDV0h61MFIT1LN9pd9DMfo0hK5WZiRGr3SIxwWKV+XleMC0MMoZR24ryBXGQExlDXaWNY0dZ/9klsgVyAZLieNYxZds38nfwVTr4G81vmliZGsemgjho+YErg4PSKtPdD+IXvj4JwoBb4GJcRxEzTTdakKEzu+vP7mjGvzWYNEO2T7DqSuAHmD91fXrPYwYf9LunNzz8od0wVtlb1RPt0pgVxz5nS2Qt8xCcbadjvFzTPYkbSFWa8EOhPI98IYZf x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 71db81e4-6056-40bf-5750-08d5f230969b x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600073)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB5036; x-ms-traffictypediagnostic: DB7PR05MB5036: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231311)(944501410)(52105095)(93006095)(93001095)(3002001)(10201501046)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:DB7PR05MB5036; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB5036; x-forefront-prvs: 0744CFB5E8 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(136003)(376002)(346002)(366004)(189003)(199004)(14454004)(229853002)(3846002)(54906003)(86362001)(106356001)(11346002)(6116002)(97736004)(105586002)(2906002)(316002)(76176011)(478600001)(6436002)(68736007)(9686003)(6636002)(55016002)(53936002)(7696005)(256004)(2900100001)(476003)(81156014)(26005)(81166006)(446003)(5660300001)(7736002)(8676002)(25786009)(6246003)(450100002)(99286004)(305945005)(6862004)(5250100002)(74316002)(6506007)(4326008)(102836004)(8936002)(486006)(66066001)(33656002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB5036; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 2BvIsASF11l8X+/rdwwUxTrhxRw1X1y9rzJTN1zqoB/rKH6l4c/bMHO9NzUBAj9iifPomOd3ByZFKqFoRaYgwMz4xUynLzrOh2NOJjm8l01LXY5Lf9pN0GlY0ddfhu2TDNPPIlBiJVJmj6r6inMpzPtUPS34sRegVCqtRRJ0+jnRujHndZmq1qcxbSa56ovsefMYok0AC4u19/omVLOk82W/2fvajXBF61GekuUi5PH+zAnMQRn5jqt65luG+C8JqEY5q3bFvB/SX7ooQHKWcHw5WAy1j/ULL+/Omn006YijQEE3tbmJOkIAAs116pVXXW55Ne/UBxAzADfWDTICVIAKbIIZcsA7QQ2NndF+chU= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 71db81e4-6056-40bf-5750-08d5f230969b X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jul 2018 13:14:44.0970 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB5036 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix queue rollback when starting device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jul 2018 13:14:51 -0000 Monday, July 23, 2018 11:57 PM, Yongseok Koh: > Subject: [PATCH] net/mlx5: fix queue rollback when starting device >=20 > mlx5_rxq_start() and mlx5_rxq_stop() must be strictly paired because > internal reference counter is increased or decreased inside. Also, > mlx5_rxq_get() must be paired with mlx5_rxq_release(). >=20 > Fixes: 7d6bf6b866b8 ("net/mlx5: add Multi-Packet Rx support") > Fixes: a1366b1a2be3 ("net/mlx5: add reference counter on DPDK Rx > queues") > Fixes: 6e78005a9b30 ("net/mlx5: add reference counter on DPDK Tx > queues") > Cc: stable@dpdk.org >=20 > Signed-off-by: Yongseok Koh Applied to next-net-mlx, thanks.=20