From: Shahaf Shuler <shahafs@mellanox.com>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/2] net/mlx4: fix minor resource leak during init
Date: Sun, 17 Jun 2018 08:05:28 +0000 [thread overview]
Message-ID: <DB7PR05MB442608DB7CBCA93298DFDCC6C3720@DB7PR05MB4426.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20180522153441.31354-1-adrien.mazarguil@6wind.com>
Tuesday, May 22, 2018 6:37 PM, Adrien Mazarguil:
> Subject: [PATCH 1/2] net/mlx4: fix minor resource leak during init
>
> Temporary IB device context and list are not freed in case of a successful
> initialization of the device.
>
> This issue is caused by the two following commits, the first of which causes
> initialization to return early, while the second one goes a bit overboard while
> switching to negative errno values; an internal variable
> (err) is needed to tell success from failure at the end of the function since
> rte_errno is not reliable enough.
>
> Fixes: f2318196c71a ("net/mlx4: remove limitation on number of instances")
> Fixes: 9d14b27308a0 ("net/mlx4: standardize on negative errno values")
> Cc: stable@dpdk.org
>
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Series applied to next-net-mlx, thanks.
prev parent reply other threads:[~2018-06-17 8:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 15:36 Adrien Mazarguil
2018-05-22 15:37 ` [dpdk-dev] [PATCH 2/2] net/mlx5: remove limitation on number of instances Adrien Mazarguil
2018-05-23 0:31 ` Yongseok Koh
2018-06-17 8:05 ` Shahaf Shuler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR05MB442608DB7CBCA93298DFDCC6C3720@DB7PR05MB4426.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).