From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0083.outbound.protection.outlook.com [104.47.2.83]) by dpdk.org (Postfix) with ESMTP id 476EC1B540; Sun, 17 Jun 2018 10:05:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lEIJSsJ8U6nfeojxpA3avcLSEruwHT1ktUHwdRXNvWc=; b=h0vBdt2x2FoOEj8Gz+LXw0T2P7xSzt4MdqtagJARZ48UnZHRpj5ofFJk3CXqIY2XuRlkX72ymDO+l80pvP+EiyilZvvNqZmLxn8HIOOOfSqMPxk6hyNCcJK1ijpHPhbMdRlhDVwfCK84ipaiju3SpQUZUT1II6Z+Z1jzxJpTRlk= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4267.eurprd05.prod.outlook.com (52.134.108.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.19; Sun, 17 Jun 2018 08:05:28 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::4c94:2db9:b8c5:cc6b]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::4c94:2db9:b8c5:cc6b%4]) with mapi id 15.20.0863.016; Sun, 17 Jun 2018 08:05:28 +0000 From: Shahaf Shuler To: Adrien Mazarguil CC: Ferruh Yigit , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH 1/2] net/mlx4: fix minor resource leak during init Thread-Index: AQHT8eLDz5e/tvFbSECEk8/4+eya/aRfxhBw Date: Sun, 17 Jun 2018 08:05:28 +0000 Message-ID: References: <20180522153441.31354-1-adrien.mazarguil@6wind.com> In-Reply-To: <20180522153441.31354-1-adrien.mazarguil@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4267; 7:S6IjqAUNOFHhZq5mSu1ZXCtO2+gI9bUjr78LZ5NVp/iWoy22QpvpDmKlBIE9YVHeABrMJHKRxOXfy+PU7JyxdxwAxRpeH8uNyTQA+q5zF6rAQB4PTvZy/Q4HVPLxIe1kuxutorL+JQzbJAdb94mIjajgl/ue4gd+Nw2L346bQJvBp0s4vUsZOWKe57sIweoNUXusZI92yeRZKQ8b9QppnsC6zekxzkt6S5LKFmcUvFZlS35ULs36c2sWhqOCn13Z x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: fc00f540-2932-46c0-3b17-08d5d42916af x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(711020)(48565401081)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4267; x-ms-traffictypediagnostic: DB7PR05MB4267: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231254)(944501410)(52105095)(93006095)(93001095)(10201501046)(3002001)(6055026)(149027)(150027)(6041310)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:DB7PR05MB4267; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4267; x-forefront-prvs: 07063A0A30 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(39860400002)(39380400002)(346002)(366004)(396003)(199004)(189003)(6436002)(186003)(2900100001)(6506007)(305945005)(102836004)(86362001)(26005)(478600001)(7736002)(59450400001)(5660300001)(76176011)(9686003)(5250100002)(99286004)(6916009)(7696005)(11346002)(446003)(486006)(14454004)(8676002)(81156014)(55016002)(476003)(8936002)(229853002)(81166006)(25786009)(74316002)(66066001)(4326008)(6116002)(33656002)(105586002)(3846002)(2906002)(6246003)(53936002)(3660700001)(97736004)(54906003)(316002)(68736007)(3280700002)(106356001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4267; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: v549yhi7QPwrKrldW/6JSBgBFDoELAXiF8nWicZ5BI9Ew2hTwr7de0PsoWukf8NRPZuLDSgcoVBCjYgc0H5x2fzDE+J6JPmg6UzuyYBNqOF+mRmvYVvEYnaOh9PK286HWiNxLkch4kqvK6x89ilNVSnGzQzFC6tt2kOfdURBzoZ6PVRLKeq0QmjeujZ1naY9 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc00f540-2932-46c0-3b17-08d5d42916af X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jun 2018 08:05:28.0717 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4267 Subject: Re: [dpdk-dev] [PATCH 1/2] net/mlx4: fix minor resource leak during init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Jun 2018 08:05:29 -0000 Tuesday, May 22, 2018 6:37 PM, Adrien Mazarguil: > Subject: [PATCH 1/2] net/mlx4: fix minor resource leak during init >=20 > Temporary IB device context and list are not freed in case of a successfu= l > initialization of the device. >=20 > This issue is caused by the two following commits, the first of which cau= ses > initialization to return early, while the second one goes a bit overboard= while > switching to negative errno values; an internal variable > (err) is needed to tell success from failure at the end of the function s= ince > rte_errno is not reliable enough. >=20 > Fixes: f2318196c71a ("net/mlx4: remove limitation on number of instances"= ) > Fixes: 9d14b27308a0 ("net/mlx4: standardize on negative errno values") > Cc: stable@dpdk.org >=20 > Signed-off-by: Adrien Mazarguil Series applied to next-net-mlx, thanks.=20