* [dpdk-dev] [PATCH] net/mlx5: fix artificial L4 limitation on switch flow rules
@ 2018-08-06 14:25 Adrien Mazarguil
2018-08-15 7:30 ` Shahaf Shuler
0 siblings, 1 reply; 2+ messages in thread
From: Adrien Mazarguil @ 2018-08-06 14:25 UTC (permalink / raw)
To: Shahaf Shuler, Yongseok Koh; +Cc: dev
Partial bit-masks are in fact supported on TCP/UDP source/destination
ports. Remove unnecessary check.
Fixes: 2bfc777e07 ("net/mlx5: add L2-L4 pattern items to switch flow rules")
Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
---
drivers/net/mlx5/mlx5_nl_flow.c | 20 --------------------
1 file changed, 20 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_nl_flow.c b/drivers/net/mlx5/mlx5_nl_flow.c
index a1c8c340b..beb03c911 100644
--- a/drivers/net/mlx5/mlx5_nl_flow.c
+++ b/drivers/net/mlx5/mlx5_nl_flow.c
@@ -800,16 +800,6 @@ mlx5_nl_flow_transpose(void *buf,
}
spec.tcp = item->spec;
if ((mask.tcp->hdr.src_port &&
- mask.tcp->hdr.src_port != RTE_BE16(0xffff)) ||
- (mask.tcp->hdr.dst_port &&
- mask.tcp->hdr.dst_port != RTE_BE16(0xffff)))
- return rte_flow_error_set
- (error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ITEM_MASK,
- mask.tcp,
- "no support for partial masks on"
- " \"hdr.src_port\" and \"hdr.dst_port\""
- " fields");
- if ((mask.tcp->hdr.src_port &&
(!mnl_attr_put_u16_check(buf, size,
TCA_FLOWER_KEY_TCP_SRC,
spec.tcp->hdr.src_port) ||
@@ -847,16 +837,6 @@ mlx5_nl_flow_transpose(void *buf,
}
spec.udp = item->spec;
if ((mask.udp->hdr.src_port &&
- mask.udp->hdr.src_port != RTE_BE16(0xffff)) ||
- (mask.udp->hdr.dst_port &&
- mask.udp->hdr.dst_port != RTE_BE16(0xffff)))
- return rte_flow_error_set
- (error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ITEM_MASK,
- mask.udp,
- "no support for partial masks on"
- " \"hdr.src_port\" and \"hdr.dst_port\""
- " fields");
- if ((mask.udp->hdr.src_port &&
(!mnl_attr_put_u16_check(buf, size,
TCA_FLOWER_KEY_UDP_SRC,
spec.udp->hdr.src_port) ||
--
2.11.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: fix artificial L4 limitation on switch flow rules
2018-08-06 14:25 [dpdk-dev] [PATCH] net/mlx5: fix artificial L4 limitation on switch flow rules Adrien Mazarguil
@ 2018-08-15 7:30 ` Shahaf Shuler
0 siblings, 0 replies; 2+ messages in thread
From: Shahaf Shuler @ 2018-08-15 7:30 UTC (permalink / raw)
To: Adrien Mazarguil, Yongseok Koh; +Cc: dev
Monday, August 6, 2018 5:26 PM, Adrien Mazarguil:
> Subject: [PATCH] net/mlx5: fix artificial L4 limitation on switch flow rules
>
> Partial bit-masks are in fact supported on TCP/UDP source/destination ports.
> Remove unnecessary check.
>
> Fixes: 2bfc777e07 ("net/mlx5: add L2-L4 pattern items to switch flow rules")
>
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Applied to next-net-mlx, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-15 7:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-06 14:25 [dpdk-dev] [PATCH] net/mlx5: fix artificial L4 limitation on switch flow rules Adrien Mazarguil
2018-08-15 7:30 ` Shahaf Shuler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).