DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/mlx5: fix VLAN ID matching on switch flow rules
@ 2018-08-02  9:25 Adrien Mazarguil
  2018-08-02 12:48 ` Shahaf Shuler
  0 siblings, 1 reply; 2+ messages in thread
From: Adrien Mazarguil @ 2018-08-02  9:25 UTC (permalink / raw)
  To: Shahaf Shuler; +Cc: dev

VLAN ID is not properly translated to TC due to swapped byte order.

Fixes: fdc4d0f4c7e1 ("net/mlx5: add VLAN item and actions to switch flow rules")

Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
---
 drivers/net/mlx5/mlx5_nl_flow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/mlx5/mlx5_nl_flow.c b/drivers/net/mlx5/mlx5_nl_flow.c
index 9bad1a418..8803ffc32 100644
--- a/drivers/net/mlx5/mlx5_nl_flow.c
+++ b/drivers/net/mlx5/mlx5_nl_flow.c
@@ -662,7 +662,7 @@ mlx5_nl_flow_transpose(void *buf,
 		    (mask.vlan->tci & RTE_BE16(0x0fff) &&
 		     !mnl_attr_put_u16_check
 		     (buf, size, TCA_FLOWER_KEY_VLAN_ID,
-		      spec.vlan->tci & RTE_BE16(0x0fff))))
+		      rte_be_to_cpu_16(spec.vlan->tci & RTE_BE16(0x0fff)))))
 			goto error_nobufs;
 		++item;
 		break;
-- 
2.11.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: fix VLAN ID matching on switch flow rules
  2018-08-02  9:25 [dpdk-dev] [PATCH] net/mlx5: fix VLAN ID matching on switch flow rules Adrien Mazarguil
@ 2018-08-02 12:48 ` Shahaf Shuler
  0 siblings, 0 replies; 2+ messages in thread
From: Shahaf Shuler @ 2018-08-02 12:48 UTC (permalink / raw)
  To: Adrien Mazarguil; +Cc: dev

Thursday, August 2, 2018 12:25 PM, Adrien Mazarguil:
> Subject: [PATCH] net/mlx5: fix VLAN ID matching on switch flow rules
> 
> VLAN ID is not properly translated to TC due to swapped byte order.
> 
> Fixes: fdc4d0f4c7e1 ("net/mlx5: add VLAN item and actions to switch flow
> rules")
> 
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

Applied to next-net-mlx, thank. 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-08-02 12:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-02  9:25 [dpdk-dev] [PATCH] net/mlx5: fix VLAN ID matching on switch flow rules Adrien Mazarguil
2018-08-02 12:48 ` Shahaf Shuler

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).