From: Shahaf Shuler <shahafs@mellanox.com>
To: Yongseok Koh <yskoh@mellanox.com>,
Bruce Richardson <bruce.richardson@intel.com>
Cc: "Adrien Mazarguil" <adrien.mazarguil@6wind.com>,
"Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] mlx: fix warnings for unused compiler arguments
Date: Sun, 1 Apr 2018 07:39:28 +0000 [thread overview]
Message-ID: <DB7PR05MB442614934361F9C5A7920D1FC3A70@DB7PR05MB4426.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <213D6C3B-866A-4F73-997E-07873E8AB576@mellanox.com>
Thursday, March 29, 2018 11:54 PM, Yongseok Koh:
>
> > On Mar 29, 2018, at 6:36 AM, Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > When linking the mlx glue code libraries using CC, the linker
> > arguments in LDFLAGS are not prefixed with -Wl. [The EXTRA_LDFLAGS are
> > though.] This leads to warning messages on build:
> >
> > clang-5.0: warning: argument unused during compilation: '-e xport-
> dynamic'
> >
> > Fix this by checking for $LINK_USING_CC in the Makefiles and prefixing
> > the LDFLAGS appropriately if set.
> >
> > Fixes: 27cea11686ff ("net/mlx4: spawn rdma-core dependency plug-in")
> > Fixes: 59b91bec12c6 ("net/mlx5: spawn rdma-core dependency plug-in")
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> Acked-by: Yongseok Koh <yskoh@mellanox.com>
Applied to next-net-mlx, thanks.
>
> Thanks
prev parent reply other threads:[~2018-04-01 7:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 13:36 Bruce Richardson
2018-03-29 20:53 ` Yongseok Koh
2018-04-01 7:39 ` Shahaf Shuler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR05MB442614934361F9C5A7920D1FC3A70@DB7PR05MB4426.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).