From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0064.outbound.protection.outlook.com [104.47.0.64]) by dpdk.org (Postfix) with ESMTP id 6B3581B19 for ; Wed, 28 Mar 2018 10:31:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=g7m9r+NS0/3P+ZHxtArPilDBdKKVL2a1WmIiU/4KIQk=; b=kEtcBIvYPV1RIriZ3uDJickC0/hOXtT1fBEf3MYl+uCjNfDVWkq4x5RVLTmDwVCAOjD0d7yys77yV7VmM5PY/n7cRqt6YAGRqJu5Auawy67tAtJgOJyaRB6JBUlfxkK+sItNyXrg5ZrPQck+f4rIwaFrsf41aTATqnl3HfCWhtk= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4236.eurprd05.prod.outlook.com (52.134.108.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.631.10; Wed, 28 Mar 2018 08:30:58 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::808d:386e:26f3:859f]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::808d:386e:26f3:859f%13]) with mapi id 15.20.0609.012; Wed, 28 Mar 2018 08:30:58 +0000 From: Shahaf Shuler To: Rahul Lakkireddy CC: Ferruh Yigit , "dev@dpdk.org" , Kumar A S , Nirranjan Kirubaharan , Indranil Choudhury Thread-Topic: [dpdk-dev] [PATCH 00/13] cxgbe: add CXGBE VF PMD and updates Thread-Index: AQHTuMIabw7NnumF8EO9chqc/n2gDKPjFwkAgACqbgCAAWuG4IAAMVMAgAANY0A= Date: Wed, 28 Mar 2018 08:30:58 +0000 Message-ID: References: <20180327070155.GA17402@chelsio.com> <20180328073933.GA19600@chelsio.com> In-Reply-To: <20180328073933.GA19600@chelsio.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.107] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4236; 7:Sl1djMa9GlPFWaubd/RBFnKNWZmonCV358MbXic86I66ymFoYoXDUrHFtJzZLds1ZAzS3+x9pASN9wzOaISMNjJduzLEhtBOzEb+9v+s7z/jfdELmUdfbLcGRdP5VMPoegu0WMfbFzGFgLHGtjz9cGkBLz6cp+n9gq+EsTZARN4FsgzulnKIJcxPuQfAIZ1v+cv9ztyLZKo6588vu3d3AySXLakoSnHXGHuUT51yq4OhSQi9Gyl7o+X8+QegryIu x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 6a321439-000c-4d44-8a61-08d594863b38 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4236; x-ms-traffictypediagnostic: DB7PR05MB4236: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3231221)(944501327)(52105095)(3002001)(6055026)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011); SRVR:DB7PR05MB4236; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4236; x-forefront-prvs: 06259BA5A2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(396003)(346002)(366004)(39380400002)(39860400002)(189003)(199004)(55016002)(6916009)(186003)(9686003)(6246003)(25786009)(53936002)(2900100001)(486005)(11346002)(102836004)(446003)(14454004)(76176011)(54906003)(486005)(26005)(316002)(68736007)(6506007)(99286004)(93886005)(86362001)(476003)(7696005)(97736004)(2906002)(3846002)(33656002)(8676002)(8936002)(3660700001)(81156014)(81166006)(3280700002)(5660300001)(6436002)(105586002)(106356001)(7736002)(6116002)(5250100002)(4326008)(66066001)(74316002)(229853002)(478600001)(305945005); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4236; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: PAdEMD7ADSWKnp8i+dkzavTgozRANupA3GahJKQlmuZzyj+lCkxOScWWSpYHnu2Nuv0xVNzUWP+OC9oAKO4xrTPl+xv1OBoSvw2yGKXwd24h5lnvade8+z50EmwTUxUbvcXFiwG8wIA1pcbbtKKClBMtt1W4WxtyPB57uRe7LZkwP9TFpuoVIrNasDSqSx8dEv1YUqF0+b/Y7W3A/WkZd668t3CwKLeL4ciFO1FnT/FXc2vDF8ex/OrqOP8xsVRBI82YbufF0OwvRYA5HrMpmfo0eNgCD1Kn71/HfCHim68eKcKngOXom2grO30Bw6+IptMRxzVA3oPrXw1mMGRZYw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6a321439-000c-4d44-8a61-08d594863b38 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Mar 2018 08:30:58.2570 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4236 Subject: Re: [dpdk-dev] [PATCH 00/13] cxgbe: add CXGBE VF PMD and updates X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Mar 2018 08:31:00 -0000 Wednesday, March 28, 2018 10:40 AM, Rahul Lakkireddy: > On Wednesday, March 03/28/18, 2018 at 10:19:17 +0530, Shahaf Shuler > > > > What exactly is the offload you try to expose? To strip the inner VLAN = while > keeping the outer one? > > >=20 > Sorry about that, I should have provided more details on this earlier. > Chelsio hardware supports below for double-vlans: > 1) Dropping Outer VLAN in hw; inner vlan is stripped and available as pac= ket > metadata. So this is basically the DEV_RX_OFFLOAD_QINQ_STRIP with limitation from you= r device you cannot return the outer vlan in the packet metadata > 2) Preserving Outer VLAN so, Outer VLAN is stripped and available as pack= et > metadata. Inner VLAN is available as part of packet itself. And this one is the regular DEV_RX_OFFLOAD_VLAN_STRIP >=20 > So, the configurability here is with respect to Outer VLAN and subsequent= ly > what is available as part of packet metadata (outer or inner vlan). Inne= r > VLAN gets retained in both cases. However, based on how Outer VLAN is > configured, Inner VLAN will be available either as packet metadata or as = part > of packet itself. >=20 > We are not very sure if DEV_RX_OFFLOAD_QINQ_STRIP could be used here. > If it holds the same meaning then we will use the same. Yeah , we are missing good documentation of what each offload means.=20 >=20 > Thanks, > Rahul