From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20076.outbound.protection.outlook.com [40.107.2.76]) by dpdk.org (Postfix) with ESMTP id 68CF1AAEE; Wed, 9 May 2018 11:57:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=bRiwtKzRfrswpHWsp2WrGGZIpHDEsqdFrc4bGX9uOls=; b=V+tK7voktghWAPu3c+J4D/b6fjGkFFvpcH60X2zsNsTjPl/rGvZRnD25oI984E21Szw6Kqn93xYHcVDHuMKWeEf7QMK4t53BMoHIbpIhmRGmGihywIgneAsbUxBnsREtQHiYq2eslDZru46zapPCOC5lbUxeE4l9r08vBJvrwEk= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4378.eurprd05.prod.outlook.com (52.134.108.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.735.17; Wed, 9 May 2018 09:57:31 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::f116:5be4:ba29:fed8]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::f116:5be4:ba29:fed8%13]) with mapi id 15.20.0735.018; Wed, 9 May 2018 09:57:31 +0000 From: Shahaf Shuler To: Ophir Munk , Adrien Mazarguil CC: Ferruh Yigit , "dev@dpdk.org" , "stable@dpdk.org" , Thomas Monjalon , Raslan Darawsheh , Saleh Alsouqi , Olga Shern Thread-Topic: Please revert: [dpdk-dev] [PATCH 2/2] net/mlx4: fix useless default in RSS converter Thread-Index: AdPncXBiPvWHcNBXQQ6JnspCaCHQlwACpAaA Date: Wed, 9 May 2018 09:57:31 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4378; 7:Tn80mXYlSXPYQ54UDA1rWyPDAgNLdDPQ4xKrmqxxxhvjjUFg1oBmG5X1tkeK4kUPReC/n+TKe2EOzqOUG4uHICxy8g8A3p+OsHdwUT435SKi2KdBQAOImiJ6myhNmwFBi4ZDC0IJaKs50tx4Q63j42lzt3Nadebq6djY9KniTlz4gK8hfh8/tCmSKsP+8yr6IqFzJ16/3pYzfCNxzpRrO8paOAp2HVKVE25o/B/XySWRHt2HLsrmLRyWcChHZJhP x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4378; x-ms-traffictypediagnostic: DB7PR05MB4378: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231254)(944501410)(52105095)(93006095)(93001095)(3002001)(10201501046)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(6072148)(201708071742011); SRVR:DB7PR05MB4378; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4378; x-forefront-prvs: 0667289FF8 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(396003)(39860400002)(39380400002)(346002)(366004)(376002)(189003)(199004)(13464003)(76176011)(478600001)(7696005)(97736004)(476003)(446003)(11346002)(106356001)(9686003)(105586002)(305945005)(53936002)(486006)(68736007)(5250100002)(74316002)(7736002)(99286004)(5660300001)(33656002)(55016002)(86362001)(107886003)(110136005)(6246003)(3846002)(316002)(2900100001)(14454004)(81156014)(54906003)(81166006)(26005)(6436002)(3280700002)(25786009)(53546011)(3660700001)(2906002)(6506007)(102836004)(229853002)(6116002)(66066001)(8936002)(8676002)(4326008)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4378; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: Y3dBAuT2iRkGEs/mof1k7sNnfvea/Uz4rqRofL9V08aI+K2BwLc5uTj8EgMM92Q9Sc4QxKtGivbw4uUU3q8PqhhKe8rI8N4SFxBejGVcz20xdQXwL/70+TkypfaK76MsitpdSH8oeU9vwaKHoxV41EElutjt641lLV09PENX4Tv2jo1VDgw5MgaUWABJG96i spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: f5193af3-8886-4f1f-8dba-08d5b59347e2 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: f5193af3-8886-4f1f-8dba-08d5b59347e2 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2018 09:57:31.1924 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4378 Subject: Re: [dpdk-dev] Please revert: [PATCH 2/2] net/mlx4: fix useless default in RSS converter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 09:57:33 -0000 Wednesday, May 9, 2018 11:47 AM, Ophir Munk: > Subject: Please revert: [dpdk-dev] [PATCH 2/2] net/mlx4: fix useless defa= ult > in RSS converter >=20 > Hi Shahaf, Adrien, >=20 > This commit (in next-net/master since 8-May-18) is breaking all testpmd c= alls > with mlx4 NIC, see [1]. > Can you please revert it? What is the root cause? Why is failsafe failing due to it? =20 >=20 > [1] > PMD: net_mlx4: cannot set up internal flow rules (code 95, "Operation not > supported"), flow error type 16, cause 0x7fffdb5bb3a0, message: > unsupported RSS hash type requested Fail to configure port 0 > EAL: Error - exiting with code: 1 > Cause: Start ports failed >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Adrien Mazarguil > > Sent: Friday, May 04, 2018 6:18 PM > > To: Shahaf Shuler > > Cc: Ferruh Yigit ; dev@dpdk.org; > > stable@dpdk.org > > Subject: [dpdk-dev] [PATCH 2/2] net/mlx4: fix useless default in RSS > > converter > > > > Since the commit below, mlx4_conv_rss_types() does not need to support > > special value -1 anymore. Other functions rely on priv->hw_rss_sup > directly. > > > > Fixes: 1d173da83ef2 ("net/mlx4: fix default RSS hash fields") > > Cc: stable@dpdk.org > > > > Signed-off-by: Adrien Mazarguil > > --- > > drivers/net/mlx4/mlx4_flow.c | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/drivers/net/mlx4/mlx4_flow.c > > b/drivers/net/mlx4/mlx4_flow.c index 3f754b480..cb3b9a952 100644 > > --- a/drivers/net/mlx4/mlx4_flow.c > > +++ b/drivers/net/mlx4/mlx4_flow.c > > @@ -78,9 +78,6 @@ struct mlx4_drop { > > /** > > * Convert DPDK RSS hash types to their Verbs equivalent. > > * > > - * This function returns the supported (default) set when @p types > > has > > - * special value (uint64_t)-1. > > - * > > * @param priv > > * Pointer to private structure. > > * @param types > > @@ -125,8 +122,6 @@ mlx4_conv_rss_types(struct priv *priv, uint64_t > > types) > > uint64_t conv =3D 0; > > unsigned int i; > > > > - if (types =3D=3D (uint64_t)-1) > > - return priv->hw_rss_sup; > > for (i =3D 0; i !=3D RTE_DIM(in); ++i) > > if (types & in[i]) { > > seen |=3D types & in[i]; > > -- > > 2.11.0