Re: [dpdk-dev] [PATCH v4 0/3] support meadata as flow rule criteria

[Shahaf Shuler <shahafs@mellanox.com>]

Andrew,

Are you OK with the below updates? 
Any other comments on the rest of the patches? 

Thursday, October 11, 2018 1:50 PM, Dekel Peled:
> arybchenko@solarflare.com
> Cc: Shahaf Shuler <shahafs@mellanox.com>; dev@dpdk.org; Ori Kam
> <orika@mellanox.com>
> Subject: [dpdk-dev] [PATCH v4 0/3] support meadata as flow rule criteria
> 
> This series implements the match-metadata feature described in [1].
> 
> [1] "[RFC v2] ethdev: support metadata as flow rule criteria"
> 	https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F
> %2Fmails.dpdk.org%2Farchives%2Fdev%2F2018-
> August%2F110194.html&amp;data=02%7C01%7Cshahafs%40mellanox.com%
> 7C6492a52cd55747e95e8608d62f696abd%7Ca652971c7d2e4d9ba6a4d149256f
> 461b%7C0%7C0%7C636748527156517743&amp;sdata=DrSIJz%2FjKzluPzF6kg
> WH70MXRKIaTe8SrVCq8zlV26U%3D&amp;reserved=0
> 
> ---
> v4:
> Apply code review comments:
> * Change location of metadata item in mbuf
> * Update debug commands
> 
> v3:
> * Add link to RFC email.
> * Add cover letter subject line.
> 
> v2:
> * Fix some checkpatch coding style issues (wrongly sent).
> ---
> 
> Dekel Peled (3):
>   ethdev: support metadata as flow rule criteria
>   app/testpmd: support metadata as flow rule criteria
>   app/testpmd: add Tx metadata debug commands
> 
>  app/test-pmd/cmdline.c                      | 114 ++++++++++++++++++++++++++-
> -
>  app/test-pmd/cmdline_flow.c                 |  25 ++++++
>  app/test-pmd/config.c                       |   1 +
>  app/test-pmd/testpmd.c                      |   5 ++
>  app/test-pmd/testpmd.h                      |   2 +
>  app/test-pmd/txonly.c                       |   9 +++
>  doc/guides/prog_guide/rte_flow.rst          |  21 +++++
>  doc/guides/testpmd_app_ug/testpmd_funcs.rst |  13 +++-
>  lib/librte_ethdev/rte_ethdev.c              |   1 +
>  lib/librte_ethdev/rte_ethdev.h              |   5 ++
>  lib/librte_ethdev/rte_flow.c                |   1 +
>  lib/librte_ethdev/rte_flow.h                |  24 ++++++
>  lib/librte_mbuf/rte_mbuf.c                  |   2 +
>  lib/librte_mbuf/rte_mbuf.h                  |  57 +++++++++-----
>  14 files changed, 255 insertions(+), 25 deletions(-)
> 
> --
> 1.8.3.1