From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10089.outbound.protection.outlook.com [40.107.1.89]) by dpdk.org (Postfix) with ESMTP id 1FF9A4C8C for ; Tue, 16 Oct 2018 10:42:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ezDPPcvqp67nTPzL4VqAYOSr//4MPjbNsZHajrUJI+U=; b=t4keTQ/YF60UJ7qr3wGSZlk39NuChq820gyitJAeWyfCcOpLfRzNbXMWnWYIFSbcXrMp3h4i4s9tdxxzOZsw04+REu94tgegA7rE0HhHAsQHIZIzy5x+WJ4HzEl2hCgKybh6OiGoCmpuOUNmdnOemGRsl7o4Pl2fY7lJEf2kQhk= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB5557.eurprd05.prod.outlook.com (20.177.193.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1228.23; Tue, 16 Oct 2018 08:42:43 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::80e:e6b:baf2:d973]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::80e:e6b:baf2:d973%3]) with mapi id 15.20.1228.020; Tue, 16 Oct 2018 08:42:43 +0000 From: Shahaf Shuler To: Dekel Peled , "wenzhuo.lu@intel.com" , "jingjing.wu@intel.com" , "bernard.iremonger@intel.com" , "olivier.matz@6wind.com" , Adrien Mazarguil , Thomas Monjalon , "ferruh.yigit@intel.com" , "arybchenko@solarflare.com" CC: "dev@dpdk.org" , Ori Kam Thread-Topic: [dpdk-dev] [PATCH v4 0/3] support meadata as flow rule criteria Thread-Index: AQHUYVJKs7jeTm4Mk0+3WtLCf7LhLKUhlZMw Date: Tue, 16 Oct 2018 08:42:43 +0000 Message-ID: References: <1538056677-33846-1-git-send-email-dekelp@mellanox.com> <1539254998-8555-1-git-send-email-dekelp@mellanox.com> In-Reply-To: <1539254998-8555-1-git-send-email-dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.105] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB5557; 6:m++xdbQhRPYswm4HfLod0e7nPXg4p9azJVkqkroo7Vhtr3VpE8A4iQaDx8KtxPmEKsdG7SOmgcwQcDNUjpiGZDfkgL6JR5MMh96pFCLK8cTz3HFjsfKoBmfIIRGPUormXXPRsQF/Yo+y0vF/zTjZtwE/tlbC6bMxKvunxLUseOPEKGgfmAq7dZdxMoh7CW3BAxHotQg+FHAJF72HLcyy8bEd2gKeJQdbdlF8XQc0/XG63+XqKhfk0uGpsgYn6PsRhcLgan3acy/udhSHuWrtrcVeOG0GfE8reU43/6KhfGx3KMs8yTOCEMizio1wTg2RBY1WWUKM4PCFdmtaFtjr0o7ZAg030RUIv4gqilT4W1iBwfrz0wzCD8hA7JppfufcoISzGpBHUKg18Dhuzp5aOEc+EP6kc+Kqofg3z5VK9y1wC86q3nwczZlkjxxso48YTC/Ijcznb7bQdUKQbDk04g==; 5:8A2TEGga4gwBFpvUIQcBDXpJ6Mlp402ngo09sWptoJUEptouHHPOiU+S0ZrHJhRVlWsFj4sC1qsVUayZvhn5lUNNKXi1RyksLmuOqdTE5AZ/R46ohJ9v6nnBQWY/+shvncU0xUZp1vgyre2r/2qoYHGYsQGLoMNM6SV9lv5ZM0A=; 7:SFdWl5z2Lrxflbt1OWV3x+i+OBcprj+02D5MgMCU9C7BLtnukT2H8TGHSrqXi5T24J3K8UudtpkOPB0L0rfYUF5MVZ/qjbuY0P+LVLTL2QKnWIbzkZ28qBu5/izohj85u9Q2VLbaKL1cr/D9FDtf2LgLMYvAFkwQbu92EkicKMYQ/gRr+0qo7MIy0jWzHodvdXqr2HxjfRcUgzX+MRoH9TKHb/bxxxV55qqdtajcT3IXYMjnQowQOkRRzse1AafE x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: d409bbc9-1fa0-40ac-d41c-08d633435713 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB5557; x-ms-traffictypediagnostic: DB7PR05MB5557: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(45079756050767)(189930954265078); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3231355)(944501410)(4982022)(52105095)(3002001)(6055026)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123558120)(20161123560045)(201708071742011)(7699051); SRVR:DB7PR05MB5557; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB5557; x-forefront-prvs: 0827D7ACB9 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(396003)(346002)(366004)(39860400002)(136003)(199004)(189003)(71190400001)(8676002)(25786009)(6246003)(106356001)(14454004)(2201001)(86362001)(9686003)(229853002)(8936002)(81156014)(55016002)(81166006)(68736007)(2900100001)(4326008)(6306002)(5660300001)(6436002)(54906003)(97736004)(107886003)(110136005)(53936002)(486006)(446003)(11346002)(476003)(7736002)(2501003)(74316002)(186003)(316002)(3846002)(99286004)(305945005)(76176011)(2906002)(6116002)(71200400001)(6506007)(33656002)(966005)(5250100002)(45080400002)(14444005)(256004)(478600001)(26005)(7696005)(66066001)(102836004)(105586002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB5557; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: QDLLL2YO9l8HYfR353dFyQyY3qprAgbb/qVT3vqCcwgIJIXBSSN2CQwYLf93d6/oALcqiOwOmkUlGkYxGjc/OoTjuoUlMmEED4Dvg9WfH+Kafslgoi3Bcmv9kwsc3S0cYlVAudJ1nVjAP6UvPXz+Uo8ymkzpNdAVFRB+rYK3QT+SIkkmHI/P2WLmME+NfAVW9zEZGLWCjhlU38r0V9SB7r97h4jpeqH+PJaCLrQO1Lu8S1BRSlF8tRx6s+yb+I8TSJFlvokXYno8ecqrU55Lx9o5SdjRToWGkXYZtba2hwL4T2wN/yijctoaLVn2KreJSDJJR1I1HP91JqZBhXBmtkij9vS5whzQbMYcwfJO+J8= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: d409bbc9-1fa0-40ac-d41c-08d633435713 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Oct 2018 08:42:43.5309 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB5557 Subject: Re: [dpdk-dev] [PATCH v4 0/3] support meadata as flow rule criteria X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2018 08:42:46 -0000 Andrew, Are you OK with the below updates?=20 Any other comments on the rest of the patches?=20 Thursday, October 11, 2018 1:50 PM, Dekel Peled: > arybchenko@solarflare.com > Cc: Shahaf Shuler ; dev@dpdk.org; Ori Kam > > Subject: [dpdk-dev] [PATCH v4 0/3] support meadata as flow rule criteria >=20 > This series implements the match-metadata feature described in [1]. >=20 > [1] "[RFC v2] ethdev: support metadata as flow rule criteria" > https://emea01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F > %2Fmails.dpdk.org%2Farchives%2Fdev%2F2018- > August%2F110194.html&data=3D02%7C01%7Cshahafs%40mellanox.com% > 7C6492a52cd55747e95e8608d62f696abd%7Ca652971c7d2e4d9ba6a4d149256f > 461b%7C0%7C0%7C636748527156517743&sdata=3DDrSIJz%2FjKzluPzF6kg > WH70MXRKIaTe8SrVCq8zlV26U%3D&reserved=3D0 >=20 > --- > v4: > Apply code review comments: > * Change location of metadata item in mbuf > * Update debug commands >=20 > v3: > * Add link to RFC email. > * Add cover letter subject line. >=20 > v2: > * Fix some checkpatch coding style issues (wrongly sent). > --- >=20 > Dekel Peled (3): > ethdev: support metadata as flow rule criteria > app/testpmd: support metadata as flow rule criteria > app/testpmd: add Tx metadata debug commands >=20 > app/test-pmd/cmdline.c | 114 ++++++++++++++++++++++= ++++- > - > app/test-pmd/cmdline_flow.c | 25 ++++++ > app/test-pmd/config.c | 1 + > app/test-pmd/testpmd.c | 5 ++ > app/test-pmd/testpmd.h | 2 + > app/test-pmd/txonly.c | 9 +++ > doc/guides/prog_guide/rte_flow.rst | 21 +++++ > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 13 +++- > lib/librte_ethdev/rte_ethdev.c | 1 + > lib/librte_ethdev/rte_ethdev.h | 5 ++ > lib/librte_ethdev/rte_flow.c | 1 + > lib/librte_ethdev/rte_flow.h | 24 ++++++ > lib/librte_mbuf/rte_mbuf.c | 2 + > lib/librte_mbuf/rte_mbuf.h | 57 +++++++++----- > 14 files changed, 255 insertions(+), 25 deletions(-) >=20 > -- > 1.8.3.1