From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40065.outbound.protection.outlook.com [40.107.4.65]) by dpdk.org (Postfix) with ESMTP id C3C202BDB for ; Thu, 3 May 2018 09:40:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=WwfLTZ+EMBzC6U4wSTgpD7Q+eVosnUWx9nGPlWp7rk8=; b=j9gmP0KrCrqwbKKNaUxOp6F083XCjTKTTF45flSo6XK0knXvVjqmu4crr6sY33xyEOT7PC9DLIHD38slrtu4XkMvm51HHaMlSMHKy0J8jwmHAZ16B6N3WSV11RJMR/f6Ed68xMgiO11Q0vJAiTIqTNkjskJ9Z8hnsiNxwgsXldo= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4409.eurprd05.prod.outlook.com (52.134.109.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.715.23; Thu, 3 May 2018 07:40:28 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::f116:5be4:ba29:fed8]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::f116:5be4:ba29:fed8%13]) with mapi id 15.20.0715.024; Thu, 3 May 2018 07:40:28 +0000 From: Shahaf Shuler To: =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , "Yongseok Koh" CC: Adrien Mazarguil , "dev@dpdk.org" Thread-Topic: [PATCH 2/2] net/mlx5: fix probe return value polarity Thread-Index: AQHT4biICb+kcIi5TkWsqbOaZ8K0cqQcAAyAgAGfo9A= Date: Thu, 3 May 2018 07:40:28 +0000 Message-ID: References: <20180501111806.112319-1-shahafs@mellanox.com> <20180501111806.112319-2-shahafs@mellanox.com> <246A35AF-2BFD-41C6-BEFC-A93D559FBA88@mellanox.com> <20180502064941.4vwdku7ellgzq6cx@laranjeiro-vm.dev.6wind.com> In-Reply-To: <20180502064941.4vwdku7ellgzq6cx@laranjeiro-vm.dev.6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4409; 7:nGrJNQ56CRr3MyHtEoUJkVqUvyRAEMPnlbAXpWVEHQVPiJIfbOhhvB4EVhzjVraK8d3KvQDfwyikTb090PSW2rnA15ojT6+5S43LWmWH327Tn758gHvv9Kscsqn3hqGoPeq3Al69HTdW+i4pBrz1wdkSKECwS4hRGmza47oBdoUqUpWbm0QHwknHK9JCn8YilDnL4R20qV6COOg291bITtslnNylW1FZcGJcxprfDgbAauZ4Cc9KNmDHh1LNdfEw x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4409; x-ms-traffictypediagnostic: DB7PR05MB4409: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(10201501046)(3231254)(944501410)(52105095)(6055026)(6041310)(20161123562045)(20161123560045)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:DB7PR05MB4409; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4409; x-forefront-prvs: 066153096A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(39380400002)(396003)(366004)(39860400002)(346002)(199004)(189003)(4326008)(55016002)(86362001)(68736007)(93886005)(5250100002)(9686003)(478600001)(6436002)(81156014)(5660300001)(6246003)(81166006)(3660700001)(97736004)(3846002)(6116002)(305945005)(66066001)(25786009)(74316002)(8936002)(446003)(110136005)(7736002)(8676002)(476003)(14454004)(53936002)(99286004)(11346002)(316002)(102836004)(54906003)(106356001)(6636002)(229853002)(2906002)(3280700002)(105586002)(186003)(486006)(6506007)(76176011)(26005)(59450400001)(53546011)(33656002)(7696005)(2900100001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4409; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: uZuWt2bDzJOyigzsB9l3Dy73yEjRD9KPFx8UwYJA5I/q/1rOR+3dQSCMwder4WsKabHryPMD91zx/5tcvRZGCR1zJiPMuLFpD/GU09bA0ikPqf8BFp3WdjTCgHPsVd1tKupWKt9KHJUIfIFx0eeq1NRPJmxJ1NWgfDsQm+n9EJn2Z6YnuUw2HNW4HLPHJB/5 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: eccd7a16-8e31-4a51-1b10-08d5b0c9241e X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: eccd7a16-8e31-4a51-1b10-08d5b0c9241e X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2018 07:40:28.2098 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4409 Subject: Re: [dpdk-dev] [PATCH 2/2] net/mlx5: fix probe return value polarity X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2018 07:40:29 -0000 Wednesday, May 2, 2018 9:50 AM, N=E9lio Laranjeiro: > Subject: Re: [PATCH 2/2] net/mlx5: fix probe return value polarity >=20 > On Wed, May 02, 2018 at 01:54:37AM +0000, Yongseok Koh wrote: > > > > > On May 1, 2018, at 4:18 AM, Shahaf Shuler > wrote: > > > > > > mlx5 prefixed function returns a negative errno value. > > > the error handler on mlx5_pci_probe is doing the same. > > > > > > Fixes: a6d83b6a9209 ("net/mlx5: standardize on negative errno > > > values") > > > Cc: nelio.laranjeiro@6wind.com > > > > > > Signed-off-by: Shahaf Shuler > > > --- > > > drivers/net/mlx5/mlx5.c | 8 ++++++-- > > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index > > > 46cb370a29..ab860b5985 100644 > > > --- a/drivers/net/mlx5/mlx5.c > > > +++ b/drivers/net/mlx5/mlx5.c > > > @@ -804,12 +804,16 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv > __rte_unused, > > > goto error; > > > > Shouldn't you do the same for mlx5_uar_init_secondary()? > > Looks like a few more. E.g. mlx5_args(), mlx5_get_mtu() and > mlx5_uar_init_primary(). Yes thanks. > > What about ibv_query_port()=20 No need, according to man: RETURN VALUE = =20 ibv_query_port() returns 0 on success, or the value of errno on fail= ure (which indicates the failure rea- son). = =20 This is also the case for ibv_query_port_ex, I will align it on the next ve= rsion.=20 and mlx5_flow_create_drop_queue()? Yes, needed.=20 > > > > Thanks > > > > > /* Receive command fd from primary process */ > > > err =3D mlx5_socket_connect(eth_dev); > > > - if (err < 0) > > > + if (err < 0) { > > > + err =3D -err; > > > > Instead of changing sign, how about 'err =3D rte_errno;' ? >=20 > +1 Ok. >=20 > > However, err looks redundant to me because mlx5_* funcs set rte_errno. >=20 > Not it is not, rte_errno is the strict equivalent of errno but instead of= being > global to the process, it is global per logical core, its cannot be deter= mined > nor modified at the beginning of the function thus the function must trac= k > any failure and report it accordingly. >=20 > > Here, err is used to set rte_errno at the end. >=20 > It is just a optimization to avoid a lot of rte_errno sets among the func= tion, it > must only be set if err !=3D 0. I think I will keep the local err for the meanwhile.=20 >=20 > > Thanks, > > Yongseok > > > > > goto error; > > > + } > > > /* Remap UAR for Tx queues. */ > > > err =3D mlx5_tx_uar_remap(eth_dev, err); > > > - if (err) > > > + if (err) { > > > + err =3D -err; > > > goto error; > > > + } > > > /* > > > * Ethdev pointer is still required as input since > > > * the primary device is not accessible from the > > > -- > > > 2.12.0 > > > >=20 > Regards, >=20 > -- > N=E9lio Laranjeiro > 6WIND