From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70075.outbound.protection.outlook.com [40.107.7.75]) by dpdk.org (Postfix) with ESMTP id C274A2BD8 for ; Sun, 16 Sep 2018 11:01:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VbsSd/fpYkVdt7lGpxwetX5FomxoC2HzTO3P56t8lJU=; b=ds0Dqe9nKWPJzBrnr1hXqujcQiwbttzDBJRG5koAHuudfM4Gup2RESiyFR6FYHNTJ0XmSkX28vh8kKms5YpJWw+7fTxzc3IQlV1r/wefw9EuONHrI3U8/c8IFuTFETzMRsHU34K85EGjyQho22bYZVNqT2f0bSvnxvxo5Erpx4o= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4234.eurprd05.prod.outlook.com (52.134.108.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1143.17; Sun, 16 Sep 2018 09:01:19 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::c8e7:d9c1:5054:693b]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::c8e7:d9c1:5054:693b%6]) with mapi id 15.20.1122.020; Sun, 16 Sep 2018 09:01:19 +0000 From: Shahaf Shuler To: Bruce Richardson CC: Yongseok Koh , Matan Azrad , =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , "bluca@debian.org" , "dev@dpdk.org" Thread-Topic: [PATCH v6 1/2] net/mlx5: support meson build Thread-Index: AQHUS18l+P3x0upHuEyahZLvW0WHLaTyoLyw Date: Sun, 16 Sep 2018 09:01:19 +0000 Message-ID: References: <20180905114746.117936-1-shahafs@mellanox.com> <3c634e089dbcc5a6a7fc7cbff91958598f595e57.1536839688.git.shahafs@mellanox.com> <20180913124142.GA1776@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20180913124142.GA1776@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4234; 6:mI5ug8KDHAgQCYycVpG96IOf8ZwrMofz3KhqoDKihrs4ZABSHWiEns4+tbTOMFJZB2HXux7jx89wLghDHAVJRD9AHZcuUKHcLLtMcXCXzh/SFQS6J3b9YeZLHEtbmZBqE9q3d3HW3FWbpcdFTgCwjoJosa/AF8TM/7vQoSI96iIyLe/lUzmUI28tBQUmGgm79vp7JEa/QSlZ1ZChlhtd2aTAdG3aHWIo/Pf70XjKBMVKNyzcrMmatcnyehN+iRCss+5ojyedRCN5aSVU1Nc2f3waJ7bSIrTTJnYKeJWtOD4bM6RKfq0/bQ2h/6VR6IKnchGVriYCoFNR1EABHgMn/dGAgpEzxXdEKtB134iul4AqKWQlbF5fxYv81ufSRkQZ8z/iFBx1kt/TBALeIRKgm4SwDR6rZDB53k7pNYTzu1zjqTedVsaWaiK70YqtsjTx0peneoQT9pIYlmcsOi37pg==; 5:Btl/Rk84xbnWtXSOyKAJWyatGo62RUVCmlu4LSM/Ag+1pUT/nmidHYE51jWFtg7vrrWZsYXvie9yVL905Tt9p9H2uJMuDKdkpWe0tJnenQtpY3yf0tgc0560anHuHxbDA0RNS1T7+P+7fa6Xxl2amGDJBtlnPTHXnW3hh5CTdug=; 7:FDXPVzaZi3/YkkxkUZ9uX+y7R5n73zKfV+/78HoRE8aV117YQnXcvZImraIWB9AHfYh47ZrPqcmyqxFi5iRVPs98c6t7joOVtLpi+4Rju4BojdNVZR7UZ7q4bOyXgmMH090zI2pxfXCNIqMfiaXpR0wMWr1ZQFsgtv5wpeYG6iSG9StsEUJ/hwFs5n2PrgUx8qrwRitFCH7AXVbKGnGAfIp0N1nHOF3SsV6YJbQP38aQwJQDOQGNF52guNJ/XtdN x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: b114df8d-272f-4237-b9ad-08d61bb2f80c x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4234; x-ms-traffictypediagnostic: DB7PR05MB4234: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231355)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123564045)(201708071742011)(7699050); SRVR:DB7PR05MB4234; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4234; x-forefront-prvs: 079756C6B9 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(39860400002)(136003)(396003)(366004)(189003)(199004)(54906003)(68736007)(6246003)(55016002)(6436002)(7736002)(316002)(305945005)(33656002)(478600001)(74316002)(53936002)(6116002)(3846002)(8676002)(14454004)(4326008)(9686003)(25786009)(66066001)(99286004)(86362001)(2906002)(229853002)(11346002)(5250100002)(105586002)(106356001)(7696005)(81166006)(76176011)(6506007)(26005)(81156014)(2900100001)(476003)(256004)(97736004)(446003)(5660300001)(8936002)(486006)(6916009)(102836004)(186003); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4234; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: dDWRRXLKvaPqEgLmVkB1Brq1Wc0FQZiRLxiIfaKBCkt5FslQTg2O5DphjGTZ0PaGqVPi0fJnV6e0e1sSHW8nrzG0LfBsDHfpXwRs42aGj5hgKQr4PpeshitEIc6ZI5/02WbOBV2oueIpI2ryXSDk/wE6qS3ivxG8NZG1tCM7pInfJwNlhvnnLAE0D7K8OoB6xDSrMrp5w9zNTvvBaGPbMrNxamk6ZgJwti8zm0Q0szrLvmor/ou9pq9hVThUiMnLW8O/qilL5kmmAfbvglKtAqzmXdIT0z6MP3DoZHjWukaDXc14tIKLrRbUL7L5jkk2GoKPDxyRvhDJcsE+uMPScOZCBfoCDA+6aN98UYN+PoM= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: b114df8d-272f-4237-b9ad-08d61bb2f80c X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Sep 2018 09:01:19.7995 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4234 Subject: Re: [dpdk-dev] [PATCH v6 1/2] net/mlx5: support meson build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Sep 2018 09:01:22 -0000 Thursday, September 13, 2018 3:42 PM, Bruce Richardson: > Subject: Re: [PATCH v6 1/2] net/mlx5: support meson build >=20 > On Thu, Sep 13, 2018 at 03:11:05PM +0300, Shahaf Shuler wrote: > > From: Nelio Laranjeiro > > > > Compile Mellanox driver when its external dependencies are met. A > > glue version of the driver can still be requested by using the > > -Denable_driver_mlx_glue=3Dtrue > > > > To avoid modifying the whole sources and keep the compatibility with > > current build systems (e.g. make), the mlx5_autoconf.h is still > > generated by invoking DPDK scripts though meson's run_command() > > instead of using has_types, has_members, ... commands. > > >=20 > This part of the commit message is no longer accurate. >=20 > > Meson will try to find the required external libraries. When they are > > not installed system wide, they can be provided though CFLAGS, LDFLAGS > > and LD_LIBRARY_PATH environment variables, example (considering > > RDMA-Core is installed in /tmp/rdma-core): > > > > # CLFAGS=3D-I/tmp/rdma-core/build/include \ > > LDFLAGS=3D-L/tmp/rdma-core/build/lib \ > > LD_LIBRARY_PATH=3D/tmp/rdma-core/build/lib \ > > meson output > > # LD_LIBRARY_PATH=3D/tmp/rdma-core/build/lib \ > > ninja -C output install > > > > Note: LD_LIBRARY_PATH before ninja is necessary when the meson > > configuration has changed (e.g. meson configure has been called), in > > such situation the LD_LIBRARY_PATH is necessary to invoke the > > autoconfiguration script. > > > > Signed-off-by: Nelio Laranjeiro > > Acked-by: Bruce Richardson > > Signed-off-by: Shahaf Shuler >=20 > The signoffs should be together, followed by the ack. >=20 > Otherwise LGTM (for both patches) Series applied to next-net-mlx with the above modification, thanks. >=20 > /Bruce