From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0047.outbound.protection.outlook.com [104.47.0.47]) by dpdk.org (Postfix) with ESMTP id CDE201B546; Tue, 26 Jun 2018 12:25:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k+y5w7rBGcfq5mNd2Ki9FJXditZXeoY/d/tO3bG7v2g=; b=B2XQd0YBbz8/WVQtlPasqnSQRdiX2lqrrCjK6zG8Qg8KSxmVYG6OdubZOFCt6rQBIfMuZpYFOOOQxEcVNayrFQ70q/U2NJWBZSfQc8JljyAuTgiNdSN95BiBb/D/aiFYgPiagoLJwaaQKRvMZDwFFqA4QC1wqn6+PRF12QzJ29o= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4298.eurprd05.prod.outlook.com (52.134.108.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.884.23; Tue, 26 Jun 2018 10:25:19 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::4c94:2db9:b8c5:cc6b]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::4c94:2db9:b8c5:cc6b%5]) with mapi id 15.20.0884.025; Tue, 26 Jun 2018 10:25:19 +0000 From: Shahaf Shuler To: =?iso-8859-1?Q?N=E9lio_Laranjeiro?= CC: Adrien Mazarguil , Yongseok Koh , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: separate generic tunnel TSO from the standard one Thread-Index: AQHUDE9toPggSdQZvUmH34A2BgfWa6Rw1NdQgAADKYCAAX84IA== Date: Tue, 26 Jun 2018 10:25:19 +0000 Message-ID: References: <20180624062226.11507-1-shahafs@mellanox.com> <20180625064057.xnebd6se6obogwn4@laranjeiro-vm.dev.6wind.com> <20180625113317.rd5y5d4izhuvx4ri@laranjeiro-vm.dev.6wind.com> In-Reply-To: <20180625113317.rd5y5d4izhuvx4ri@laranjeiro-vm.dev.6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4298; 7:g6AhsK2kxqErLMvEFwLSZSC7l9N8uVGOd0SLXh0+h++7IMcyAO6C4vOElNj2kIVJz0vEtx2D7ykMO7jh6eUhTdYaUJ9leQc74RFHNF3X8u/LYv0eloxisfAxVFH4SHC4jjTEq3yG8kryAVrYduFO/pKPVvN4fun99Smpp9fFJecnKMfX6rposWWNiTM71o8W8HeeMrlnkSw/3+BlZKCSg5HfJ9AdaSyQIYx6BW+DgE2Ri+p1IGCa6kzioPVwiXqH x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 7132c9c8-d6b3-46a1-7b21-08d5db4f1df4 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600026)(711020)(48565401081)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4298; x-ms-traffictypediagnostic: DB7PR05MB4298: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(3231254)(944501410)(52105095)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:DB7PR05MB4298; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4298; x-forefront-prvs: 071518EF63 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(366004)(346002)(376002)(136003)(396003)(199004)(189003)(14454004)(6436002)(102836004)(99286004)(53936002)(26005)(486006)(5250100002)(476003)(86362001)(55016002)(6246003)(6506007)(229853002)(97736004)(256004)(186003)(3846002)(6116002)(7696005)(105586002)(25786009)(76176011)(6916009)(66066001)(9686003)(54906003)(478600001)(106356001)(4326008)(316002)(2900100001)(8936002)(446003)(11346002)(68736007)(8676002)(93886005)(33656002)(81156014)(81166006)(7736002)(74316002)(5660300001)(2906002)(305945005)(41533002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4298; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: CQUCAfrEI1fe+zBOFKtGtiDV+6fCmcZcsHYclfZsvylQ7ja0rIQ4/b+d6/nO98YVBVYkURS3sum5LP96qyfUW261dmjcRDVZmISK0YSEBQ6jxCwkhvRRJr+KvuGxj0QFxL8pIKGiFrCFkj4FMSHy/5XoXUryrmcjY2e7UWQcwQZfZzBZpkB9WqXr8sP5j0LGmzt6BpUN+2Ys5gDGiWA9TiwP6JQ1t7H9Iij84u/sMwMlHydYaRuJ6aV/p/ib6ohRXraspFEppuNBb/HVwRZSiQq4ylmLHhuJgyPYzmO4BH75OuFy6Gost3pbEX9BosSc8vLpjBXWi0WHfNijeHth5EFGEcvik3lzLi43avj7bf4= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7132c9c8-d6b3-46a1-7b21-08d5db4f1df4 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jun 2018 10:25:19.2532 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4298 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: separate generic tunnel TSO from the standard one X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jun 2018 10:25:21 -0000 Monday, June 25, 2018 2:33 PM, N=E9lio Laranjeiro: > Subject: Re: [PATCH] net/mlx5: separate generic tunnel TSO from the > standard one >=20 > On Mon, Jun 25, 2018 at 11:23:22AM +0000, Shahaf Shuler wrote: > > Monday, June 25, 2018 9:41 AM , N=E9lio Laranjeiro: > > > Subject: Re: [PATCH] net/mlx5: separate generic tunnel TSO from the > > > standard one > > > > > > On Sun, Jun 24, 2018 at 09:22:26AM +0300, Shahaf Shuler wrote: > > > > The generic tunnel TSO was depended in the regular one > > > > capabilities to be enabled. > > > > > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Shahaf Shuler > > > > Acked-by: Yongseok Koh > > > > --- > > > > drivers/net/mlx5/mlx5_txq.c | 13 +++++++++---- > > > > 1 file changed, 9 insertions(+), 4 deletions(-) > > > > > > > > [...] > > > > > > - txq_ctrl->txq.tunnel_en =3D config->tunnel_en; > > > > + txq_ctrl->txq.tunnel_en =3D config->tunnel_en | config->swp; > > > > txq_ctrl->txq.swp_en =3D ((DEV_TX_OFFLOAD_IP_TNL_TSO | > > > > DEV_TX_OFFLOAD_UDP_TNL_TSO | > > > > DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM) & > > > > -- > > > > 2.12.0 > > > > > > > > > > Is not it a fix? > > > > Well, more like optimization. To be less strict on when to enable the > > generic tunnel TSO. > > I can rephrase the title if you insist. >=20 > I was asking due to the CC'ed stable, which is generally used when the it= is a > fix. I don't know how the stable maintainers trigger such patch, that wh= y I > am asking. >=20 > I am not insisting in any thing here. >=20 > By the way: > Acked-by: Nelio Laranjeiro Applied to next-net-mlx, thanks.=20 >=20 > -- > N=E9lio Laranjeiro > 6WIND