From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0042.outbound.protection.outlook.com [104.47.1.42]) by dpdk.org (Postfix) with ESMTP id 95DF5CFFE; Wed, 9 May 2018 11:51:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=XERO11WcBA5neCVz9KpOpwQn747wpjrHSrwczh4+GMM=; b=S6oN55VC5w0UnRkxaqwztXv1WPMFXrf9GeIugmkSmM8Z2I3JZJ7n2SFZizSkVvKRJOJPhafJs0TE+v6cuYG9y+1+TB5n8eV41dJmFE4xUjrzAn4F0g8Cpe7be53n1xpyLO8UacHZZJX+XZfosOqNJtz/xHNAIs1zQaGuHkKmXYY= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4364.eurprd05.prod.outlook.com (52.134.108.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.735.18; Wed, 9 May 2018 09:51:34 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::f116:5be4:ba29:fed8]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::f116:5be4:ba29:fed8%13]) with mapi id 15.20.0735.018; Wed, 9 May 2018 09:51:34 +0000 From: Shahaf Shuler To: Yongseok Koh , Raslan Darawsheh CC: "dev@dpdk.org" , Thomas Monjalon , Ophir Munk , "stable@dpdk.org" Thread-Topic: [PATCH v3 1/2] net/mlx5: fix double free on error handling Thread-Index: AQHT5qyVfc9euw7gUkSTOXOEIBZsvaQmMq8AgAD2faA= Date: Wed, 9 May 2018 09:51:34 +0000 Message-ID: References: <1525770687-22980-1-git-send-email-rasland@mellanox.com> <7B4B0BF5-57AF-4F4C-BAC8-31F875D0EDE8@mellanox.com> In-Reply-To: <7B4B0BF5-57AF-4F4C-BAC8-31F875D0EDE8@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4364; 7:Z5UDECqVG/dcX5n4aPmmf+L600diJJw6ovR+1jiN+K5I1EBnXvyRa6EQJOTTUKva3WU2Km+F+v/2w4SrLfGxhwRB6QfoMAMw0/WM8acNiYqTGDMAKzBaI2GE3NyjkM2h3pFNzFVr76mKs2uegZAgZkBjH5iG6EtGgqDGMbWP0zeyrr0n5plyjs3o1bCQYcWRXp5N9zmY49HCImIlSiiwrSNnRQuqAK+8pnpKys+4F8ZHU2t7QmCu827425cu/ZRl x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4364; x-ms-traffictypediagnostic: DB7PR05MB4364: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231254)(944501410)(52105095)(3002001)(93006095)(93001095)(10201501046)(6055026)(149027)(150027)(6041310)(20161123562045)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:DB7PR05MB4364; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4364; x-forefront-prvs: 0667289FF8 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39380400002)(346002)(39860400002)(376002)(396003)(366004)(189003)(199004)(11346002)(105586002)(66066001)(76176011)(74316002)(6636002)(5250100002)(6506007)(7696005)(99286004)(54906003)(53546011)(68736007)(316002)(106356001)(110136005)(33656002)(478600001)(2900100001)(7736002)(3846002)(97736004)(5660300001)(25786009)(14454004)(446003)(102836004)(9686003)(3660700001)(4326008)(305945005)(476003)(86362001)(6436002)(486006)(81166006)(53936002)(26005)(6346003)(2906002)(229853002)(6116002)(3280700002)(55016002)(8676002)(8936002)(6246003)(81156014); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4364; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-microsoft-antispam-message-info: Gg9qfzFnTJoXoa95l/dEBz6vGaRuMUInwN0Ghk/C9xhJ+FVlhZ43AMlH88iA1v5hOIPeYG1nOchQZFwRf/sFLi9+XyNxgQaug8foUdg9gu+SPx05vVa3gLPZa1jbDhvciAHVSB5F4TjUiReoX2N5MjN4BHQZNUl6X8AqmRRX/oUR9yHJLhYySNBPCPJoKi+f spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: e4a0ebd8-708b-4997-1054-08d5b592732b X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: e4a0ebd8-708b-4997-1054-08d5b592732b X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2018 09:51:34.3597 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4364 Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/mlx5: fix double free on error handling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 09:51:36 -0000 Tuesday, May 8, 2018 10:09 PM, Yongseok Koh: > Subject: Re: [PATCH v3 1/2] net/mlx5: fix double free on error handling >=20 >=20 > > On May 8, 2018, at 2:11 AM, Raslan Darawsheh > wrote: > > > > When attr_ctx is NULL it will attempt to free the list of devices twice= . > > Avoid double freeing the list by directly going to error handling. > > > > Fixes: 771fa900b73a ("mlx5: introduce new driver for Mellanox ConnectX-= 4 > adapters") > > Cc: stable@dpdk.org > > > > Signed-off-by: Raslan Darawsheh >=20 > Acked-by: Yongseok Koh Series applied to next-net-mlx, thanks.=20 >=20 > Thanks