From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00066.outbound.protection.outlook.com [40.107.0.66]) by dpdk.org (Postfix) with ESMTP id 9F746AAEC for ; Thu, 22 Mar 2018 08:44:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=4PQnJ3B7vB13glHSocQV/548ZvxJWCqqbi5KgxK54uQ=; b=HkKRMCYE0t0OLN2ma5aPjuP9/ZIDIdWNT6DegYWzcXwL74ynF0tRTjHdmwMdLfLqG+CryFh21fGJAJFgGeKGd/PgXaSXan9NqQsM4/6n11znXu+LDYhlQFImorX1HxlsN9c21C+b0nnkm5HAH3FvneldrzGzY/I1Npm3OtJhZrU= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4123.eurprd05.prod.outlook.com (52.134.107.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.588.14; Thu, 22 Mar 2018 07:44:51 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::3473:b2b5:68f:fe6e]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::3473:b2b5:68f:fe6e%13]) with mapi id 15.20.0588.016; Thu, 22 Mar 2018 07:44:51 +0000 From: Shahaf Shuler To: =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , "Adrien Mazarguil" , Yongseok Koh CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 1/3] net/mlx5: use Netlink to add/remove MAC addresses Thread-Index: AQHTwRpZyPf7iCxleEyg/0C/MP3VAqPb2AswgAAIoKA= Date: Thu, 22 Mar 2018 07:44:51 +0000 Message-ID: References: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4123; 7:cQylK0QmzCmTlmBCcEl1T5kMXTM7webqcKJhJ9qwvoxoRZWzSdNLm5656hgPrK6QTZGFA12+y7nMSTb5u5NyD7CglJsg7/NoTcmpjEXYhltck2H8xi5QnCZoIJzyvD7kzpZCEMmX4xtBUoRFHTDU1eSCebjwQIjgVbEF11yb1GUAIDpwVJkZUVer/b3AHYGPvz6UFVRJHT/RFffjEWUomYKJ+h8Aaf0KaWuQgU7GUJRnNgxEZq8tPwwxacHWILKB x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: ce8ded27-3569-4e78-5e46-08d58fc8cb94 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4123; x-ms-traffictypediagnostic: DB7PR05MB4123: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231221)(944501327)(52105095)(6055026)(6041310)(20161123558120)(20161123560045)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:DB7PR05MB4123; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4123; x-forefront-prvs: 0619D53754 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(346002)(366004)(376002)(39380400002)(396003)(199004)(189003)(6506007)(59450400001)(3280700002)(86362001)(3660700001)(110136005)(102836004)(6636002)(5660300001)(99286004)(97736004)(4326008)(186003)(68736007)(3846002)(7696005)(105586002)(33656002)(6116002)(9686003)(53936002)(76176011)(25786009)(5250100002)(74316002)(8936002)(229853002)(6436002)(2900100001)(26005)(55016002)(478600001)(316002)(66066001)(305945005)(81156014)(106356001)(14454004)(7736002)(81166006)(6246003)(2906002)(446003); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4123; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: C9s+8HIVujVKg6PQv1619E/dahA9L8BlmlQMPHDpIOSfwYnxT0A8Djx1D453KbNNbsO7CfyffYpmdSrUqe7gDL6KvACMX87/kOM4xrBV9mYvzyRlwfuKufgyTVJE+AXgZfiLa0zTq3HsT6Cp7zZtaJV/sbfGAQN+VNGRWvJgGwSggGq5L0dikffvpXKpSe0ACZcrgjSSLRifbwNzpQSf3HtNGTIS7RnBAsD3J+vW201C0K6VoEgI/4KU/Yt1Mbam0bYzqgYEq6hP6K1y1zraYuGU/jNQFtHDLsBSUsjdCw/9LeQK/vPzWwH3VY2vn6rvQNy4emg7zWhHOCxjeSteyQ== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: ce8ded27-3569-4e78-5e46-08d58fc8cb94 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Mar 2018 07:44:51.2960 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4123 Subject: Re: [dpdk-dev] [PATCH v3 1/3] net/mlx5: use Netlink to add/remove MAC addresses X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Mar 2018 07:44:55 -0000 Thursday, March 22, 2018 9:35 AM, Shahaf Shuler: > Hi Nelio, >=20 > Wednesday, March 21, 2018 3:40 PM, Nelio Laranjeiro: > > VF devices are not able to receive traffic unless it fully requests it > > though Netlink. This will cause the request to be processed by the PF > > which will add/remove the MAC address to the VF table if the VF is trus= ted. > > > > Signed-off-by: Nelio Laranjeiro > > Acked-by: Adrien Mazarguil > > --- > > drivers/net/mlx5/Makefile | 1 + > > drivers/net/mlx5/mlx5.c | 22 ++ > > drivers/net/mlx5/mlx5.h | 13 + > > drivers/net/mlx5/mlx5_ethdev.c | 27 +++ > > drivers/net/mlx5/mlx5_mac.c | 25 +- > > drivers/net/mlx5/mlx5_nl.c | 530 > > +++++++++++++++++++++++++++++++++++++++++ > > diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index > > faacfd9d6..6a7e9f310 100644 > > --- a/drivers/net/mlx5/mlx5.h > > +++ b/drivers/net/mlx5/mlx5.h Sorry sent to early.=20 Another general question - is there required netlink version exists on all = the relevant distros? What is the minimal kernel version required?=20 > > @@ -78,6 +78,7 @@ struct mlx5_dev_config { > > unsigned int hw_vlan_strip:1; /* VLAN stripping is supported. */ > > unsigned int hw_fcs_strip:1; /* FCS stripping is supported. */ > > unsigned int hw_padding:1; /* End alignment padding is supported. > > */ > > + unsigned int vf:1; /* This is a VF. */ > > unsigned int mps:2; /* Multi-packet send supported mode. */ > > unsigned int tunnel_en:1; > > /* Whether tunnel stateless offloads are supported. */ @@ -154,6 > > +155,8 @@ struct priv { > > struct mlx5_dev_config config; /* Device configuration. */ > > struct mlx5_verbs_alloc_ctx verbs_alloc_ctx; > > /* Context for Verbs allocator. */ > > + int nl_socket; /* Netlink socket. */ > > + uint32_t nl_sn; /* Netlink message sequence number. */ > > }; > > > > /* mlx5.c */ > > @@ -163,6 +166,7 @@ int mlx5_getenv_int(const char *); > > /* mlx5_ethdev.c */ > > > > int mlx5_get_ifname(const struct rte_eth_dev *dev, char > > (*ifname)[IF_NAMESIZE]); > > +int mlx5_ifindex(const struct rte_eth_dev *dev); > > int mlx5_ifreq(const struct rte_eth_dev *dev, int req, struct ifreq > > *ifr); int mlx5_get_mtu(struct rte_eth_dev *dev, uint16_t *mtu); int > > mlx5_set_flags(struct rte_eth_dev *dev, unsigned int keep, @@ -297,4 > > +301,13 @@ struct mlx5_mr *mlx5_mr_get(struct rte_eth_dev *dev, > struct > > rte_mempool *mp); int mlx5_mr_release(struct mlx5_mr *mr); int > > mlx5_mr_verify(struct rte_eth_dev *dev); > > > > +/* mlx5_nl.c */ > > + > > +int mlx5_nl_init(uint32_t nlgroups); > > +int mlx5_nl_mac_addr_add(struct rte_eth_dev *dev, struct ether_addr > > +*mac); int mlx5_nl_mac_addr_remove(struct rte_eth_dev *dev, struct > > +ether_addr *mac); void mlx5_nl_mac_addr_flush(struct rte_eth_dev > > *dev); >=20 > I think the two below should be introduced only on the next patch of the > series. >=20 > > +int mlx5_nl_promisc(struct rte_eth_dev *dev, int enable); int > > +mlx5_nl_allmulti(struct rte_eth_dev *dev, int enable); > > + > > #endif /* RTE_PMD_MLX5_H_ */ >=20 > [...] >=20 > > +/** > > + * Flush all added MAC addresses. > > + * > > + * @param dev > > + * Pointer to Ethernet device. > > + */ > > +void > > +mlx5_nl_mac_addr_flush(struct rte_eth_dev *dev) { > > + int i; > > + const struct ether_addr mac_null =3D { .addr_bytes =3D { 0 }, }; > > + > > + for (i =3D MLX5_MAX_MAC_ADDRESSES - 1; i >=3D 0; --i) { > > + struct ether_addr *m =3D &dev->data->mac_addrs[i]; > > + > > + if (memcmp(&mac_null, m, ETHER_ADDR_LEN)) > > + mlx5_nl_mac_addr_remove(dev, m); > > + } > > +} >=20 > What if the DPDK process is terminated ungracefully? I think the MAC tabl= e > will remain with all the MACs which were added. > The next run of the process may have un-expected results. >=20 > Should we flush the neighbor mac table also on probe to make sure only th= e > VF mac exists? >=20 > > -- > > 2.11.0