From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40047.outbound.protection.outlook.com [40.107.4.47]) by dpdk.org (Postfix) with ESMTP id 6A7931B171; Wed, 9 May 2018 13:13:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Sur52eUURTx0lAo483oHIVgvX32lwZFaeTqwUOpQX88=; b=JsdxHWvpMZZnUOaP7D3VIBjSIg4KlWkRgJavsAOeXhQdIkmaHqLfGe9nnLjG2J+z1G8gJ4olEAwvsXpCBESS+H4HhDBo1gu7xiQYCXSD16tNAwOMXV1KYnr0jtnMKC9LlplmBOKTJWKPhmMxi3W0IxaGSSpXHrFs9TmxmqXqdng= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4458.eurprd05.prod.outlook.com (52.134.109.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.735.18; Wed, 9 May 2018 11:13:28 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::f116:5be4:ba29:fed8]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::f116:5be4:ba29:fed8%13]) with mapi id 15.20.0735.018; Wed, 9 May 2018 11:13:28 +0000 From: Shahaf Shuler To: Ophir Munk , "dev@dpdk.org" , "Adrien Mazarguil" CC: Thomas Monjalon , Olga Shern , "stable@dpdk.org" Thread-Topic: [PATCH v2] net/mlx4: fix CRC stripping capability report Thread-Index: AQHT5sfBMDdfwZJDgUi+nfQTdwdr5qQnP9TA Date: Wed, 9 May 2018 11:13:28 +0000 Message-ID: References: <1525091101-10782-1-git-send-email-ophirmu@mellanox.com> <1525782363-426-1-git-send-email-ophirmu@mellanox.com> In-Reply-To: <1525782363-426-1-git-send-email-ophirmu@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4458; 7:0sTV796En9SK8xWV7kBqG1cBX+I7Bs/lPOQlf0oiWnQOiQYzoGqrleP8/PMNBA5lUYCCw1T2Zp7B1T3GQI/Y0tUxABTbSrEIby8ex2XMgzK2f6eSdu/aK7ZjcnZWM1qWS/PsW/VsKE1KzlkzjMVq9WYUPAYJ4uZ8kp2eO2ZjbqWCowB6X7aktYRdWVjHSMlWLHc7/cokBECiR7jc/FX9uCJwSftFTfNS46OCxl0cu3A0RMoz3o6i35rO7+kZsz5I x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4458; x-ms-traffictypediagnostic: DB7PR05MB4458: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231254)(944501410)(52105095)(93006095)(93001095)(3002001)(10201501046)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(6072148)(201708071742011); SRVR:DB7PR05MB4458; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4458; x-forefront-prvs: 0667289FF8 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(376002)(346002)(39380400002)(396003)(39860400002)(199004)(189003)(2501003)(99286004)(316002)(68736007)(4326008)(86362001)(6116002)(9686003)(11346002)(6246003)(446003)(53936002)(3846002)(55016002)(2906002)(110136005)(3660700001)(5250100002)(2900100001)(3280700002)(54906003)(476003)(97736004)(25786009)(8936002)(66066001)(6506007)(14454004)(5660300001)(33656002)(486006)(105586002)(76176011)(7736002)(7696005)(106356001)(229853002)(81166006)(26005)(102836004)(8676002)(305945005)(6436002)(478600001)(81156014)(74316002)(168613001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4458; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: q8W3r0p1BPmODaTvxkJk+wlywDUCN15XqwpOmFfIdQr/y7BsMAuOgErPl34GTk8E7iptCMHR0N+2aLE72S+zryz3OFjStSRQTpU+WLlgpoRo97JTJiGkIM8AuutKgBvOZGLGRmzNXDCbnhnlME9K1rPLvGiHB6tyIhyK9u4tJ4qRzIWIBzL52Qot2sHpYzoc spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 2d53eb4b-e677-4ab2-a545-08d5b59de3f7 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2d53eb4b-e677-4ab2-a545-08d5b59de3f7 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2018 11:13:28.0693 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4458 Subject: Re: [dpdk-dev] [PATCH v2] net/mlx4: fix CRC stripping capability report X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 11:13:29 -0000 Tuesday, May 8, 2018 3:26 PM, Ophir Munk: > Subject: [PATCH v2] net/mlx4: fix CRC stripping capability report >=20 > There are two capabilities related to CRC stripping: > 1. mlx4 HW capability to perform CRC stripping on a received packet. > This capability is built in mlx4 HW. It should be returned by the API cal= l > mlx4_get_rx_queue_offloads(). > 2. mlx4 driver capability to enable/disable HW CRC stripping. This capabi= lity is > dependent on the driver version. > Before this commit the second capability was falsely returned by the > mentioned API. This commit fixes it by returning the first capability. >=20 > mlx4 HW performs CRC stripping by default and this capability is always > reported as "true". > The ability to enable/disable CRC stripping is supported since this commi= t and > requires OFED version 4.3-1.5.0.0 or rdma-core version v18. > CRC stripping will be done by default regardless of its configuration whe= n > working with OFED or rdma-core versions earlier than those previously > specified or before this commit. >=20 > Fixes: de1df14e6e6ec ("net/mlx4: support CRC strip toggling") > Cc: stable@dpdk.org >=20 > Signed-off-by: Ophir Munk Applied to next-net-mlx, thanks.