DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/mlx5: remove GRE inner IPv6 matching limitation
@ 2018-11-11 11:15 Shahaf Shuler
  2018-11-11 11:32 ` Yongseok Koh
  0 siblings, 1 reply; 3+ messages in thread
From: Shahaf Shuler @ 2018-11-11 11:15 UTC (permalink / raw)
  To: yskoh; +Cc: dev

Such limitation seems not to exist on:
 - MLNX_OFED_linux-4.5-0.3.0.0 (Beta)
 - MLNX_OFED_LINUX-4.4-2.0.7.0 (GA)
 - upstream kernel 4.19.0-rc7

Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
---
 drivers/net/mlx5/mlx5_flow.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 8039664bc2..9c17627da7 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -1240,17 +1240,6 @@ mlx5_flow_validate_item_ipv6(const struct rte_flow_item *item,
 		return rte_flow_error_set(error, EINVAL,
 					  RTE_FLOW_ERROR_TYPE_ITEM, item,
 					  "L3 cannot follow an L4 layer.");
-	/*
-	 * IPv6 is not recognised by the NIC inside a GRE tunnel.
-	 * Such support has to be disabled as the rule will be
-	 * accepted.  Issue reproduced with Mellanox OFED 4.3-3.0.2.1 and
-	 * Mellanox OFED 4.4-1.0.0.0.
-	 */
-	if (tunnel && item_flags & MLX5_FLOW_LAYER_GRE)
-		return rte_flow_error_set(error, ENOTSUP,
-					  RTE_FLOW_ERROR_TYPE_ITEM, item,
-					  "IPv6 inside a GRE tunnel is"
-					  " not recognised.");
 	if (!mask)
 		mask = &rte_flow_item_ipv6_mask;
 	ret = mlx5_flow_item_acceptable(item, (const uint8_t *)mask,
-- 
2.12.0

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: remove GRE inner IPv6 matching limitation
  2018-11-11 11:15 [dpdk-dev] [PATCH] net/mlx5: remove GRE inner IPv6 matching limitation Shahaf Shuler
@ 2018-11-11 11:32 ` Yongseok Koh
  2018-11-11 12:42   ` Shahaf Shuler
  0 siblings, 1 reply; 3+ messages in thread
From: Yongseok Koh @ 2018-11-11 11:32 UTC (permalink / raw)
  To: Shahaf Shuler; +Cc: dev


> On Nov 11, 2018, at 3:15 AM, Shahaf Shuler <shahafs@mellanox.com> wrote:
> 
> Such limitation seems not to exist on:
> - MLNX_OFED_linux-4.5-0.3.0.0 (Beta)
> - MLNX_OFED_LINUX-4.4-2.0.7.0 (GA)
> - upstream kernel 4.19.0-rc7
> 
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> ---
Acked-by: Yongseok Koh <yskoh@mellanox.com>
 
Thanks
> drivers/net/mlx5/mlx5_flow.c | 11 -----------
> 1 file changed, 11 deletions(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
> index 8039664bc2..9c17627da7 100644
> --- a/drivers/net/mlx5/mlx5_flow.c
> +++ b/drivers/net/mlx5/mlx5_flow.c
> @@ -1240,17 +1240,6 @@ mlx5_flow_validate_item_ipv6(const struct rte_flow_item *item,
> 		return rte_flow_error_set(error, EINVAL,
> 					  RTE_FLOW_ERROR_TYPE_ITEM, item,
> 					  "L3 cannot follow an L4 layer.");
> -	/*
> -	 * IPv6 is not recognised by the NIC inside a GRE tunnel.
> -	 * Such support has to be disabled as the rule will be
> -	 * accepted.  Issue reproduced with Mellanox OFED 4.3-3.0.2.1 and
> -	 * Mellanox OFED 4.4-1.0.0.0.
> -	 */
> -	if (tunnel && item_flags & MLX5_FLOW_LAYER_GRE)
> -		return rte_flow_error_set(error, ENOTSUP,
> -					  RTE_FLOW_ERROR_TYPE_ITEM, item,
> -					  "IPv6 inside a GRE tunnel is"
> -					  " not recognised.");
> 	if (!mask)
> 		mask = &rte_flow_item_ipv6_mask;
> 	ret = mlx5_flow_item_acceptable(item, (const uint8_t *)mask,
> -- 
> 2.12.0
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: remove GRE inner IPv6 matching limitation
  2018-11-11 11:32 ` Yongseok Koh
@ 2018-11-11 12:42   ` Shahaf Shuler
  0 siblings, 0 replies; 3+ messages in thread
From: Shahaf Shuler @ 2018-11-11 12:42 UTC (permalink / raw)
  To: Yongseok Koh; +Cc: dev

Sunday, November 11, 2018 1:32 PM, Yongseok Koh:
> Subject: Re: [PATCH] net/mlx5: remove GRE inner IPv6 matching limitation
> 
> 
> > On Nov 11, 2018, at 3:15 AM, Shahaf Shuler <shahafs@mellanox.com>
> wrote:
> >
> > Such limitation seems not to exist on:
> > - MLNX_OFED_linux-4.5-0.3.0.0 (Beta)
> > - MLNX_OFED_LINUX-4.4-2.0.7.0 (GA)
> > - upstream kernel 4.19.0-rc7
> >
> > Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> > ---
> Acked-by: Yongseok Koh <yskoh@mellanox.com>

Applied to next-net-mlx, thanks. 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-11-11 12:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-11 11:15 [dpdk-dev] [PATCH] net/mlx5: remove GRE inner IPv6 matching limitation Shahaf Shuler
2018-11-11 11:32 ` Yongseok Koh
2018-11-11 12:42   ` Shahaf Shuler

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).