From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80040.outbound.protection.outlook.com [40.107.8.40]) by dpdk.org (Postfix) with ESMTP id BE46F1B1FC for ; Mon, 9 Jul 2018 13:58:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=89Wz9Uo+E6UVvHr4pWgAVBhoy06+xwjUQCFRZMp9Svk=; b=jRXr6duqMsAcHRr9f5UjaqzKfKzM2kArS3xybw+0FYvtkQCWahVRVTUc/SqMxfwTfRGewphzbKx6vT5BuKVqZosaSsgK2fKK55T9H+RWh9uSysB170AU0f4h3LFNPqUgi0HNJ0aNGRNuQtbgowxMjdN96pWtQrTyRfaAnzmuoX8= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4122.eurprd05.prod.outlook.com (52.134.107.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.930.19; Mon, 9 Jul 2018 11:58:05 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::d9c6:913c:c361:f7b7]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::d9c6:913c:c361:f7b7%6]) with mapi id 15.20.0930.016; Mon, 9 Jul 2018 11:58:05 +0000 From: Shahaf Shuler To: Adrien Mazarguil CC: "dev@dpdk.org" Thread-Topic: [PATCH v4 10/10] net/mlx5: support negative identifiers for port representors Thread-Index: AQHUFDya6Lh6vkpFBUKJbhTlmJeEOqSGzb7Q Date: Mon, 9 Jul 2018 11:58:05 +0000 Message-ID: References: <20180704172322.22571-1-adrien.mazarguil@6wind.com> <20180705083934.5535-1-adrien.mazarguil@6wind.com> <20180705083934.5535-11-adrien.mazarguil@6wind.com> In-Reply-To: <20180705083934.5535-11-adrien.mazarguil@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4122; 7:jaggGPpufdICSrA0EpC2I07tFtIZi9YLvX35On0d8eSOD0kdcTc7ahh1ov33m/eR0s0rI+97dS2X4LdB+Fa6Og7MxGlD8mOnQD5CRsq9ZZ154AU7eHXety5nNlqXFa41dutjzra5Z7r2jRx/E4gJl1h2JcScmv07OCOHkqGTbnukmdObbAwAT+EmMj7tK7wtCK4vYSXhfru/y1KPF4nWdTGZxduqqC22F1bvgHNKGaf+vDNEF47N6xUrulbaMxYB x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: dcb64daf-4f1f-4f3c-3cd4-08d5e5933b3f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(48565401081)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4122; x-ms-traffictypediagnostic: DB7PR05MB4122: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(3231311)(944501410)(52105095)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:DB7PR05MB4122; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4122; x-forefront-prvs: 07283408BE x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(366004)(39860400002)(136003)(396003)(189003)(199004)(8936002)(55016002)(81166006)(4326008)(81156014)(7736002)(25786009)(74316002)(305945005)(33656002)(478600001)(2906002)(8676002)(3846002)(6916009)(256004)(14454004)(6246003)(5660300001)(9686003)(6116002)(14444005)(53936002)(97736004)(476003)(486006)(7696005)(76176011)(102836004)(446003)(6506007)(99286004)(26005)(11346002)(186003)(68736007)(2900100001)(5250100002)(229853002)(316002)(86362001)(6436002)(106356001)(105586002)(66066001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4122; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: EOSE9AO53yTkVPVDy/k3cDNyqWif5/9zfhCfaUuimiKHflGkb8V1QhAAGsB80OE9lq5c8w4lPS4Ms8QkJI2xPLRtSAWW2tsfApIGcvpcaoRqkkf1GQolbQlrmmcObjNUR+HvdempKiMUvqasE8qceDp4dS81Wp4BvbIgcZprlB3mn5mGply5h8rxPkdE6/+99w2Q9nUUK8zwnZTDIyue1GnmZI0gh0dbZ7osSpRfHVWYqUMLjtfPoUB38xfLR0F6FM0hTZ89Z6Ztyu1cQ9xgRSaSshRmPA0P4gCZSJNAv45/bU1kTQL340zrhsX/BQu8yy+zdIanzTkib6tie35wdBVX2u0V0rQjUC2Jdml7sOo= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: dcb64daf-4f1f-4f3c-3cd4-08d5e5933b3f X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jul 2018 11:58:05.7895 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4122 Subject: Re: [dpdk-dev] [PATCH v4 10/10] net/mlx5: support negative identifiers for port representors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jul 2018 11:58:07 -0000 Adrien, thank for this patch. Thursday, July 5, 2018 11:46 AM, Adrien Mazarguil: > Subject: [PATCH v4 10/10] net/mlx5: support negative identifiers for port > representors >=20 > This patch brings support for BlueField representors. >=20 > Signed-off-by: Adrien Mazarguil > Cc: Shahaf Shuler > -- > v3 changes: >=20 > - This patch was not present in prior revisions. > --- > drivers/net/mlx5/mlx5.c | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index > 12a77afa8..df7f39844 100644 > --- a/drivers/net/mlx5/mlx5.c > +++ b/drivers/net/mlx5/mlx5.c > @@ -1330,6 +1330,14 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv > __rte_unused, > memset(&list[i].info, 0, sizeof(list[i].info)); > continue; > } > + /* > + * Port representors not associated with any VFs (e.g. on > + * BlueField devices) report -1 as a port identifier. > + * Quietly set it to zero since DPDK only supports positive > + * values. > + */ I am waiting for the final answer from the BlueField team about the way the= y are going to enum the BlueField representors.=20 In case it will be the same as x86 I think we can drop this patch, otherwis= e use it, agree? > + if (list[i].info.representor && list[i].info.port_name =3D=3D -1) > + list[i].info.port_name =3D 0; > } > if (nl_rdma >=3D 0) > close(nl_rdma); > -- > 2.11.0