From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70074.outbound.protection.outlook.com [40.107.7.74]) by dpdk.org (Postfix) with ESMTP id F2A4E23D; Thu, 26 Jul 2018 07:38:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4FHfX/tIS5KiQ5ocbhhPMvyzOCHn0/qj0/DoUv31yLY=; b=Sl/QKjI8AlT9uCeyJhkVaq/uTl+mR4YDSet3d1zwg+MKIin9e+dQkbD4b59fNQKNX7I7szu5qHWgv1C1DWaGk72nifLY2xvR6S+7/Ec0d5BWkuaU1Rm2F1hUCW9A08v6KZXgs3ZRZdpsQMix5JGQTzQIcpMOi2EulC1WAkWi8Xk= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB5050.eurprd05.prod.outlook.com (20.176.236.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.22; Thu, 26 Jul 2018 05:38:41 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::52a:650b:ae10:fc3]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::52a:650b:ae10:fc3%4]) with mapi id 15.20.0995.014; Thu, 26 Jul 2018 05:38:41 +0000 From: Shahaf Shuler To: Yongseok Koh , Adrien Mazarguil CC: "dev@dpdk.org" , =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix invalid network interface index value Thread-Index: AQHUJDmPSi4GqxY7IUShNEH1wX4OAqSg/UMw Date: Thu, 26 Jul 2018 05:38:41 +0000 Message-ID: References: <20180725112249.11148-1-adrien.mazarguil@6wind.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.105] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB5050; 6:9UzR/fUMW1FZy/2cJML+E19ZJ/2ZStQJBPIX0rOe99DL3Jscugmo0jCeDMTmCzVbiAqjgUw31DFid3Leemsj6OLUK2MC9ZaQmwYj//9B8xENcqux5b+nekt66uIAuWajiaSrv+UsLWrhXYcJGMvPVRm8I5HjCe/hLwFQM/z4xXqcBK6xX6qMHjYhMwCJBKx3QBoOg8aGKmOtI9emuWQt3t/263g740jaPwEHJRdtgPCGvPGKowUNr5g/Q5L5wRIvjdyorp+tqTywcHPCEYwrs1JAMlmywlntXw55U42ugXcAwwsmvCjfLBoS7fY77AFO9kCZpeRCA5ff2MenbETmaM0RW4a72YR6dzXCCdzxd8Dm0MSB21qKEC/mXfn3Q2Ne/1FdgeUpeSifDdRfyVO3kO7WPIps/z181RS6mUqlRx6RbeWkhZpIEoFSpG8rP9MufBwe0z/1cVqurF/vefURpA==; 5:WHSFS0yLPCpQHBnAi6l7FZPPHEICbg2q0etIQJrtxITHqvIxblGZ17QKA2k1JG+66TqurjzOsjaj+5tJw563HmJWGgI+Ad8klSdeMJObGv2KDRPDpO/fDHHhPV5ayVvIXLvD+Bgn7XGqPIMnOLRNaw8k2UsfKp3SPulZdeNKlHE=; 7:Pudcfq4Kya+vul4gmno4rTSFxSm1nYjWnPBF7HDeRdfenfDo84Pt0pclQD6s/EJEdOr1HDB3N8s5kMlRqgCGg0dUOi8EPMsJLfg7ZFqENHSPTdbzUaWQ9uN7uQYZVYXAipW2mCXEd/NH6mGFzz2stnHqYB8YT72SG8u5X0fUMvwWpteEfHKzl54I9C9y52xUBrVZfYqBGtscedB+gEpDNtbZEHy1Co0TgrG5sibc2fAxpsg8uyrf7mcw6f/2Zgst x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: d0cbd8fc-cb97-4e7b-5adf-08d5f2ba0b8d x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600073)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB5050; x-ms-traffictypediagnostic: DB7PR05MB5050: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231311)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:DB7PR05MB5050; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB5050; x-forefront-prvs: 07459438AA x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39850400004)(396003)(366004)(136003)(346002)(376002)(189003)(199004)(2900100001)(25786009)(66066001)(97736004)(256004)(2906002)(81156014)(6436002)(6246003)(8936002)(81166006)(53936002)(86362001)(229853002)(55016002)(14454004)(4326008)(7736002)(74316002)(316002)(99286004)(3846002)(9686003)(446003)(305945005)(476003)(5660300001)(7696005)(33656002)(53546011)(110136005)(11346002)(76176011)(6116002)(68736007)(102836004)(105586002)(5250100002)(6506007)(106356001)(26005)(486006)(478600001)(54906003); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB5050; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 2ZPoXpukH2f4Y0n3ihjcBPbz3jQXPDDeYU/MN+4VpyUo68yrG/bq65uaObHNc6PAgwid1OAFfk6XqpM6IOcluEhKqC3QNSCX53ogaBp86ZIYVyZQ/CWk2M/nEeeYJnkGBf9HO8guv0OUxgBJaxjOX810bEY4MqaSi6cnDvau76UUrs8kO7MoS1mSUyJ5aaiKMWdKAdBjIE7C3nBp0xRUBkDtlQw5gaicqhxxo/LZPC8im6/LVSivhnls/pGikJ9GfQJ79fBDNU5aaV5Dcr995PQECvgCGz9aISgTtpDbyIuOokS+F/WYDGsdnoGNZS9SrPEWeQT5/hebAGcbg03E2pU4Osy4agZS8O8kBnEYwp0= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: d0cbd8fc-cb97-4e7b-5adf-08d5f2ba0b8d X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jul 2018 05:38:41.2714 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB5050 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix invalid network interface index value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jul 2018 05:38:43 -0000 Wednesday, July 25, 2018 8:05 PM, Yongseok Koh: > Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix invalid network interface > index value >=20 >=20 > > On Jul 25, 2018, at 4:24 AM, Adrien Mazarguil > wrote: > > > > Network interface indices being unsigned, an invalid index or error is > > normally expressed through a zero value (see if_nametoindex()). > > > > mlx5_ifindex() has a signed return type for negative values in case of > > error. Since mlx5_nl.c does not check for errors, these may be fed > > back as invalid interfaces indices to subsequent system calls. This > > usage would have been correct if mlx5_ifindex() returned a zero value > instead. > > > > This patch makes mlx5_ifindex() unsigned for convenience. > > > > Fixes: ccdcba53a3f4 ("net/mlx5: use Netlink to add/remove MAC > > addresses") > > Cc: Nelio Laranjeiro > > Cc: stable@dpdk.org > > > > Signed-off-by: Adrien Mazarguil > > Acked-by: Nelio Laranjeiro > > --- > Acked-by: Yongseok Koh Applied to next-net-mlx, thanks.=20 >=20 > Thanks