From: Shahaf Shuler <shahafs@mellanox.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Yongseok Koh <yskoh@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>,
Stephen Hemminger <sthemmin@microsoft.com>
Subject: Re: [dpdk-dev] [RFC] mlx5: fix error unwind in device start
Date: Tue, 14 Aug 2018 07:35:37 +0000 [thread overview]
Message-ID: <DB7PR05MB44265A7C0A4D3CF75D6914D5C3380@DB7PR05MB4426.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20180813082049.1758d647@xeon-e3>
Monday, August 13, 2018 6:21 PM, Stephen Hemminger:
> Subject: Re: [RFC] mlx5: fix error unwind in device start
>
> The issue was caused in an early version of netvsc VF support where it forgot
> to call dev_configure on the mlx5 device. In that case mlx5 would get
> confused and stuck.
I see, well missing the configuration stage is quite critical regardless. I am surprised ethdev layer didn't block the device start,
and maybe this is the right fix for this specific case till a rework will be done for the mlx5 device start logic.
prev parent reply other threads:[~2018-08-14 7:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 21:59 Stephen Hemminger
2018-08-13 7:52 ` Shahaf Shuler
2018-08-13 15:20 ` Stephen Hemminger
2018-08-14 7:35 ` Shahaf Shuler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR05MB44265A7C0A4D3CF75D6914D5C3380@DB7PR05MB4426.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=sthemmin@microsoft.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).