From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0052.outbound.protection.outlook.com [104.47.1.52]) by dpdk.org (Postfix) with ESMTP id 609E41C0B for ; Mon, 23 Apr 2018 13:10:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=JSdgD8YPAANcfDJSxi53V+3GdRCNnDEvcvzETzM6E6g=; b=agpuBD6R8UYIpOqUPZ4S/T+6ZabNDIxj/MeHtq8HgUJF2rWC6OFy49/rC4mUHaAmakLMnARZHQkPFdnsgsXgtrhGjIh+hzhdgphsw0ypOi3bNze0ulKHn5XYUZVUpGRecxR68N3nJLix98gRJ4XY2LlwwKInLwd9pQXhBHqc5U8= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4202.eurprd05.prod.outlook.com (52.134.107.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.696.15; Mon, 23 Apr 2018 11:10:12 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::f116:5be4:ba29:fed8]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::f116:5be4:ba29:fed8%13]) with mapi id 15.20.0696.017; Mon, 23 Apr 2018 11:10:12 +0000 From: Shahaf Shuler To: Adrien Mazarguil , Declan Doherty CC: "dev@dpdk.org" , Alex Rosenbaum , "Ferruh Yigit" , Thomas Monjalon , "Qi Zhang" , Alejandro Lucero , Andrew Rybchenko , Mohammad Abdul Awal , Remy Horton , "John McNamara" , Rony Efraim , Jingjing Wu , Wenzhuo Lu , Vincent Jardin , Yuanhan Liu , Bruce Richardson , Konstantin Ananyev , Zhihong Wang Thread-Topic: [dpdk-dev] [PATCH v4 4/6] ethdev: add mark flow item to flow item types Thread-Index: AQHT197cVl2BVfwJXUuXW9ZbZCb3eaQONgog Date: Mon, 23 Apr 2018 11:10:11 +0000 Message-ID: References: <1523017443-12414-1-git-send-email-declan.doherty@intel.com> <20180418210423.13847-1-declan.doherty@intel.com> <20180418210423.13847-5-declan.doherty@intel.com> <20180419130333.GB4957@6wind.com> In-Reply-To: <20180419130333.GB4957@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4202; 7:QAmwoUKSg2v1LOe1lvyJJ0S7Bcuw84WBVZ0KsdB8CkVVF+xMasGH8KzR89dE72f7Z4bxWLRkh1x+9l6nadzGws/bTOXO5HIIXtHrG6EF/27dIxr81sHn4djJXDCXjW9ANH3apfFkKNRnwc3NLc4QFbGQDCPC86fNCTu94Az18YfLuGKJQm/bFyczj3PSNdxG+Hg2GErWE3cicjuvXeTyZrRy4pNbZQa+qOhJJ65JZofroRgGdtAj9ttcEVLqG8/G x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4202; x-ms-traffictypediagnostic: DB7PR05MB4202: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3231232)(944501410)(52105095)(3002001)(6055026)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(20161123564045)(20161123562045)(6072148)(201708071742011); SRVR:DB7PR05MB4202; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4202; x-forefront-prvs: 06515DA04B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(346002)(376002)(39380400002)(366004)(396003)(446003)(6116002)(55016002)(186003)(66066001)(26005)(76176011)(3660700001)(316002)(6436002)(39060400002)(8676002)(110136005)(54906003)(7696005)(4326008)(229853002)(3846002)(5250100002)(14454004)(99286004)(3280700002)(2906002)(25786009)(476003)(81166006)(86362001)(93886005)(5660300001)(6506007)(102836004)(33656002)(6246003)(53936002)(7736002)(8936002)(11346002)(9686003)(2900100001)(478600001)(7416002)(74316002)(305945005); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4202; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; MLV:ovrnspm; PTR:InfoNoRecords; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: yOSoMRcy3+Ad9Linu4zDvwqmkQbVjbfnCB//+HwZcQO8jHOvIw2GjbazBMkpQv+DQ9VTKdCWrwRReTHeNF1pKnO1+O9/33mePPOwOzR0dEssJNzae0xTqp7lJlTroqgx5fxYhbtor8rk4BGOtQo6YFAXc0UFbkFcLCLFwr3cyhSJ4DD4Z9oHSkbTlMW66ko0 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 167c8a78-f276-42f7-aba7-08d5a90ac873 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 167c8a78-f276-42f7-aba7-08d5a90ac873 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2018 11:10:11.9490 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4202 Subject: Re: [dpdk-dev] [PATCH v4 4/6] ethdev: add mark flow item to flow item types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Apr 2018 11:10:14 -0000 Thursday, April 19, 2018 4:04 PM, Adrien Mazarguil: > > Subject: Re: [dpdk-dev] [PATCH v4 4/6] ethdev: add mark flow item to flow > item types >=20 > On Wed, Apr 18, 2018 at 10:04:21PM +0100, Declan Doherty wrote: > > Introduces a new action type RTE_FLOW_ITEM_TYPE_MARK which enables > > flow patterns to specify arbitrary integer values to match aginst >=20 > Typo on "aginst". >=20 > > which are set by the RTE_FLOW_ACTION_TYPE_MARK action in a > previously > > matched flow from a higher prioriry group. >=20 > prioriry =3D> priority, however this last addition is unnecessary, it cou= ld be any > prior flow rule that happens to use PASSTHRU. >=20 > > > > Signed-off-by: Declan Doherty > > --- > > doc/guides/prog_guide/rte_flow.rst | 28 > ++++++++++++++++++++++++++++ > > lib/librte_ether/rte_flow.h | 24 ++++++++++++++++++++++++ > > 2 files changed, 52 insertions(+) > > > > diff --git a/doc/guides/prog_guide/rte_flow.rst > > b/doc/guides/prog_guide/rte_flow.rst > > index 325010544..6f23ad909 100644 > > --- a/doc/guides/prog_guide/rte_flow.rst > > +++ b/doc/guides/prog_guide/rte_flow.rst > > @@ -598,6 +598,34 @@ associated with a port_id should be retrieved by > other means. > > | ``mask`` | ``index`` | zeroed to match any port index | > > +----------+-----------+--------------------------------+ > > > > +Item: ``MARK`` > > +^^^^^^^^^^^^^^ > > + > > +Matches packets coming from a previously matched flow in a higher > > +priority group >=20 > See above re "higher priority group". >=20 > > +with an arbitrary integer value which was set using the ``MARK`` > > +action in the previously matched rule. > > + Why we have to bind It with the MARK? It is HW limitation or design conside= ration?=20 My understanding is you want flow action of setting metadata to be used lat= er as a matching item for the flows on other group. It doesn't have to, but can be, bounded with the specific mark the applicat= ion wants to receive.=20