From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0062.outbound.protection.outlook.com [104.47.1.62]) by dpdk.org (Postfix) with ESMTP id 534A11B556 for ; Sun, 17 Jun 2018 10:21:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LpkDbdNYoEBloSCJP/PKXXVJCechX1cfR4216E+BSGs=; b=mGkBv/57B2wO9jtFqcBIJMjcG3Vl1Rh1x8DRh71RedGVqWthXME9KowDr1+BKSNsC4xj/MGtXby5Gdzzg4zQ3zzWMuRffA1jGjV7URtxg3wa+MUR1hC3lh/oShThHu8vLNHmWaqIt48Wc/LsjDi1sT5fHlNMOGaUgFuCog6prRI= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4345.eurprd05.prod.outlook.com (52.134.108.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.19; Sun, 17 Jun 2018 08:21:14 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::4c94:2db9:b8c5:cc6b]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::4c94:2db9:b8c5:cc6b%4]) with mapi id 15.20.0863.016; Sun, 17 Jun 2018 08:21:14 +0000 From: Shahaf Shuler To: =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , Stephen Hemminger CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] mlx5: fix log initialization Thread-Index: AQHUA0bc0pmWD4FS1EqCC7611Bzie6RfUD8AgATRM3A= Date: Sun, 17 Jun 2018 08:21:14 +0000 Message-ID: References: <20180613184626.13458-1-stephen@networkplumber.org> <20180614064620.jfdsgvg5b7jiu5z7@laranjeiro-vm.dev.6wind.com> In-Reply-To: <20180614064620.jfdsgvg5b7jiu5z7@laranjeiro-vm.dev.6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4345; 7:X+HkTkWHTWyQDtwoADIO619zOizXoata4IafCm7b2SX4lKNCDJ2ArwN6QX53CHptunb3UM1137SbL/8RObP46xfAsXcPllmWokq0ndbCp0nQIOy+kNTUxqGHMQfspOQG9TNZFUYVMIpaP3c01tdrs8GlATMucW+jgoRc7QP1sUycrTxOVJqdOJllI9F/4qgvtKzdiuC9RbZfexuv2T4oMlzxycJMRPwVNi+jPkfdbda3kT3fqnicuZhk4rrNm5PT x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 6c26cfbf-c6a1-4a39-bf52-08d5d42b4ac2 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(711020)(48565401081)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4345; x-ms-traffictypediagnostic: DB7PR05MB4345: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231254)(944501410)(52105095)(3002001)(10201501046)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123562045)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:DB7PR05MB4345; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4345; x-forefront-prvs: 07063A0A30 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39380400002)(396003)(366004)(39860400002)(346002)(376002)(199004)(189003)(6436002)(102836004)(305945005)(476003)(8676002)(2900100001)(6116002)(33656002)(2906002)(3846002)(66066001)(3660700001)(446003)(186003)(68736007)(110136005)(11346002)(26005)(7736002)(55016002)(81166006)(316002)(81156014)(478600001)(229853002)(486006)(74316002)(25786009)(106356001)(9686003)(7696005)(4326008)(5660300001)(53936002)(76176011)(5250100002)(6246003)(8936002)(3280700002)(105586002)(14454004)(6506007)(99286004)(86362001)(97736004); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4345; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: mHVIk9k4T4oCzBvh84eCHrrGgbk0bjUb1/OVbzx/oeO58o7Qn/YXd6FStZ3eHL3S8AFvUz73kaqQAK00o5OeaTIRVya9R+5TUV5XYwEgsD2G2QQV4nsNkEZJxP3uyk2pWwQObL6zVwbWkFfVYafyru0mQrFIHTntjN3xEAMTuvbB+xwKMytXvHUFxJ1WssOT spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c26cfbf-c6a1-4a39-bf52-08d5d42b4ac2 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jun 2018 08:21:14.4346 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4345 Subject: Re: [dpdk-dev] [PATCH] mlx5: fix log initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Jun 2018 08:21:15 -0000 Thursday, June 14, 2018 9:46 AM, N=E9lio Laranjeiro: > Subject: Re: [dpdk-dev] [PATCH] mlx5: fix log initialization >=20 > On Wed, Jun 13, 2018 at 11:46:26AM -0700, Stephen Hemminger wrote: > > The mlx5 driver had two init functions, but this could cause log > > initialization to be done after the other initialization. Also, the > > name of the function does not match convention (cut/paste error?). >=20 > Indeed an error in the copy/paste, sorry, >=20 > > Fix by initializing log type first at start of the pmd_init. > > This also gets rid of having two constructor functions. > > > > Fixes: a170a30d22a8 ("net/mlx5: use dynamic logging") > > Signed-off-by: Stephen Hemminger >=20 > Acked-by: Nelio Laranjeiro >=20 Applied to next-net-mlx with few log modifications: 1. title should be net/mlx5 2. Cc: stable@dpdk.org Thanks.=20