From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <shahafs@mellanox.com>
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01on0079.outbound.protection.outlook.com [104.47.1.79])
 by dpdk.org (Postfix) with ESMTP id BB6A32BE1
 for <dev@dpdk.org>; Mon,  7 May 2018 07:30:58 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;
 s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;
 bh=nPhYgUVAxoIAHtrp9YFDmUJRIz5K1mdz5o0e+oOgLOs=;
 b=ToEEJYpONvi00pVnaVBkOEcAqEfmizNGQcURBc0e6TcRxAVpPT2t1vMhXJzadRwjQaPONBzSjuX1GCTWvoFcaOSGaWxX3oUQ0DfLnv+iK6fJxYXhQnFhJzOKtsBO4mKRyFSoAvAoyq7VXk08UUOSKFlZjY/Y7ConxDZGHIHqDCY=
Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by
 DB7PR05MB4332.eurprd05.prod.outlook.com (52.134.108.145) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id
 15.20.735.18; Mon, 7 May 2018 05:30:56 +0000
Received: from DB7PR05MB4426.eurprd05.prod.outlook.com
 ([fe80::f116:5be4:ba29:fed8]) by DB7PR05MB4426.eurprd05.prod.outlook.com
 ([fe80::f116:5be4:ba29:fed8%13]) with mapi id 15.20.0735.018; Mon, 7 May 2018
 05:30:56 +0000
From: Shahaf Shuler <shahafs@mellanox.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
CC: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>, Ali Alnubani
 <alialnu@mellanox.com>, Thomas Monjalon <thomas@monjalon.net>, "Raslan
 Darawsheh" <rasland@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: event/octeontx: add event timer adapter driver
Thread-Index: AQHT5Tyl0xoPiQtjWk6YK0xR3TZWTqQisyKAgAELHvA=
Date: Mon, 7 May 2018 05:30:56 +0000
Message-ID: <DB7PR05MB44265FB47DE076AC3C2346BCC39B0@DB7PR05MB4426.eurprd05.prod.outlook.com>
References: <VI1PR05MB4269C6391BE1991586F19421D78A0@VI1PR05MB4269.eurprd05.prod.outlook.com>
 <20180423084433.GA29406@ltp-pvn>
 <DB7PR05MB44263B186BA5C9883D8C06D1C3840@DB7PR05MB4426.eurprd05.prod.outlook.com>
 <20180506133321.GA24899@jerin>
In-Reply-To: <20180506133321.GA24899@jerin>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: spf=none (sender IP is )
 smtp.mailfrom=shahafs@mellanox.com; 
x-originating-ip: [193.47.165.251]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; DB7PR05MB4332;
 7:EE1ffqidQmeb4fjczkvrFPHaWMJG/jt1C2LjNCoWI9XMXWV4IeMyg2CcnA0rTCBK12Mven93T5P+5VNhXvfn9wcBB2H7YATjm98zh1E/4nYG0UOPyOwjxMtPw/Yv7haLcxpWqFBWEwbhfyWezQTF/Ek0a7rp01x4f6siLrwO1A46YSnIx5RoSSIsdv+hLkirJYIusTqW596mmaBMrmhQo+dgThEU+Gq+JD5uTxxyCN/ER3BceC2DvrHRO2ZB5Z6x
x-ms-exchange-antispam-srfa-diagnostics: SOS;
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: UriScan:; BCL:0; PCL:0;
 RULEID:(7020095)(4652020)(5600026)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);
 SRVR:DB7PR05MB4332; 
x-ms-traffictypediagnostic: DB7PR05MB4332:
x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr
x-microsoft-antispam-prvs: <DB7PR05MB43328699A7C8BCCD5734CEA0C39B0@DB7PR05MB4332.eurprd05.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(158342451672863)(189930954265078)(45079756050767); 
x-ms-exchange-senderadcheck: 1
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0;
 RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(3231254)(944501410)(52105095)(93006095)(93001095)(10201501046)(6055026)(149027)(150022)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123562045)(20161123560045)(6072148)(201708071742011);
 SRVR:DB7PR05MB4332; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4332; 
x-forefront-prvs: 066517B35B
x-forefront-antispam-report: SFV:NSPM;
 SFS:(10009020)(366004)(396003)(39380400002)(376002)(39860400002)(346002)(189003)(199004)(13464003)(25786009)(97736004)(229853002)(478600001)(55016002)(45080400002)(14454004)(6306002)(966005)(6116002)(3846002)(53936002)(9686003)(5250100002)(5890100001)(11346002)(476003)(6916009)(486006)(33656002)(2900100001)(186003)(6436002)(446003)(3280700002)(59450400001)(316002)(7696005)(86362001)(575784001)(5660300001)(81156014)(81166006)(8676002)(93886005)(26005)(2906002)(3660700001)(99286004)(66066001)(8936002)(102836004)(76176011)(105586002)(106356001)(6246003)(4326008)(54906003)(7736002)(6506007)(74316002)(305945005)(68736007);
 DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4332;
 H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en;
 PTR:InfoNoRecords; MX:1; A:1; 
received-spf: None (protection.outlook.com: mellanox.com does not designate
 permitted sender hosts)
x-microsoft-antispam-message-info: ZDp04hwqyeW/9oIH0dl1yv+ayU0KGUbRT2F2oDkS2oG1Tw/IhyNzkqr4NH0maW83lZCaLLU5p2YG/SYqaMxw7ySkAikZqGG3q8AbN5vsnMNeQ4RIH03MnAiFXvEK3w5NTgu/2jJurZRN4cEqPk8fgnQim7RA2j9KC3oFY4D5UJN1lfCGDWf09XKjCiCRiCYo
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Office365-Filtering-Correlation-Id: 0edeccde-0f70-4e09-257f-08d5b3dbb55b
X-OriginatorOrg: Mellanox.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0edeccde-0f70-4e09-257f-08d5b3dbb55b
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2018 05:30:56.2933 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4332
Subject: Re: [dpdk-dev] event/octeontx: add event timer adapter driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 07 May 2018 05:30:59 -0000

Sunday, May 6, 2018 4:33 PM, Jerin Jacob:
> Subject: Re: event/octeontx: add event timer adapter driver
>=20
> -----Original Message-----
> > Date: Sun, 6 May 2018 13:17:55 +0000
> > From: Shahaf Shuler <shahafs@mellanox.com>
> > To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>, Ali Alnubani
> > <alialnu@mellanox.com>, Thomas Monjalon <thomas@monjalon.net>,
> Raslan
> > Darawsheh <rasland@mellanox.com>, "jerin.jacob@caviumnetworks.com"
> >  <jerin.jacob@caviumnetworks.com>
> > CC: "dev@dpdk.org" <dev@dpdk.org>
> > Subject: RE: event/octeontx: add event timer adapter driver
> >
> > Monday, April 23, 2018 11:45 AM, Pavan Nikhilesh:
> > > Subject: Re: event/octeontx: add event timer adapter driver
> > >
> > > Hi Ali,
> > >
> > > Looks like a compiler bug rather than code issue, I have verified
> > > this on x86 with gcc 4.8.5 and don't see an issue.
> > >
> > > Looking around I found that compiling with -O1 on aarch64 gcc 4.8.5
> > > seems to fix the compiler bug.
> >
> > Even if compiler bug, can we W.A in the PMD code? Surely you want your
> PMD to be compiled in most/all inbox gcc compilers.
> >
> > Here is even more problematic since it means DPDK doesn't compile
> natively on aarch with RH7.5. not sure how octeontx PMD can be enabled by
> default with such case.
>=20
>=20
> One option could be disable the specific driver for specific GCC version =
IF GCC
> VERSION IS BUGGY instead of disabling.

Yes this is yet another option.=20

>=20
> For arm64 being relativity new architecture, support for OLD compilers ar=
e
> not that good NOR really in use.

Well there are. Customer installing "new" OS (RH7.5) on his arm server will=
 currently not be able to compile DPDK.


>=20
> >
> >
> > >
> > > Thanks,
> > > Pavan.
> > >
> > > On Sun, Apr 22, 2018 at 04:03:36PM +0000, Ali Alnubani wrote:
> > > > Hi Pavan,
> > > >
> > > > The patchset
> > >
> https://emea01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fdp
> > > d
> > > k.org%2Fml%2Farchives%2Fdev%2F2018-
> > >
> April%2F094928.html&data=3D02%7C01%7Cshahafs%40mellanox.com%7C0829
> > >
> 941a97144eed811508d5a8f680c8%7Ca652971c7d2e4d9ba6a4d149256f461b%7
> > >
> C0%7C0%7C636600699041780885&sdata=3DhyAPljSPsY5PY2Had7vNwF5JX1zC0T
> > > i8WLEZr1lzhwo%3D&reserved=3D0 is causing a compilation error on
> > > QUALCOMM ARM with RHEL7.5 and gcc version 4.8.5:
> > > >
> > > > """
> > > > /download/dpdk-next-net-
> mlx/drivers/event/octeontx/timvf_worker.c:
> > > In function 'timvf_timer_arm_burst_sp':
> > > > /download/dpdk-next-net-
> > > mlx/drivers/event/octeontx/timvf_worker.c:89:1
> > > > : error: could not split insn } ^ (insn 95 98 99 (parallel [
> > > >             (set (reg:DI 0 x0 [orig:98 D.8130 ] [98])
> > > >                 (mem/v:DI (reg/f:DI 21 x21 [orig:88 D.8136 ] [88]) =
[-1  S8 A64]))
> > > >             (set (mem/v:DI (reg/f:DI 21 x21 [orig:88 D.8136 ] [88])=
 [-1  S8 A64])
> > > >                 (unspec_volatile:DI [
> > > >                         (plus:DI (mem/v:DI (reg/f:DI 21 x21
> > > > [orig:88 D.8136 ] [88]) [-1  S8
> > > A64])
> > > >                             (const_int -281474976710656 [0xffff0000=
00000000]))
> > > >                         (const_int 0 [0])
> > > >                     ] UNSPECV_ATOMIC_OP))
> > > >             (clobber (reg:CC 66 cc))
> > > >             (clobber (reg:DI 1 x1))
> > > >             (clobber (reg:SI 2 x2))
> > > >         ]) /download/dpdk-next-net-
> > > mlx/drivers/event/octeontx/timvf_worker.h:95 1832
> > > {atomic_fetch_adddi}
> > > >      (expr_list:REG_UNUSED (reg:CC 66 cc)
> > > >         (expr_list:REG_UNUSED (reg:SI 2 x2)
> > > >             (expr_list:REG_UNUSED (reg:DI 1 x1)
> > > >                 (nil)))))
> > > > /download/dpdk-next-net-
> > > mlx/drivers/event/octeontx/timvf_worker.c:89:1
> > > > : internal compiler error: in final_scan_insn, at final.c:2897
> > > > Please submit a full bug report, with preprocessed source if
> appropriate.
> > > > See
> > >
> <https://emea01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fb
> > > u
> > >
> gzilla.redhat.com%2Fbugzilla&data=3D02%7C01%7Cshahafs%40mellanox.com%
> > >
> 7C0829941a97144eed811508d5a8f680c8%7Ca652971c7d2e4d9ba6a4d149256f
> > >
> 461b%7C0%7C0%7C636600699041780885&sdata=3DbPZVI%2BkCTkDrHmUscl%2
> > > FqJyuwe%2BmZw795yiAvoUX%2BPE8%3D&reserved=3D0> for instructions.
> > > >   PMDINFO opdl_evdev.o.pmd.c
> > > >   CC opdl_evdev.o.pmd.o
> > > >   LD opdl_evdev.o
> > > >   PMDINFO sw_evdev.o.pmd.c
> > > >   CC sw_evdev.o.pmd.o
> > > >   LD sw_evdev.o
> > > > Preprocessed source stored into /tmp/ccmqxmH7.out file, please
> > > > attach
> > > this to your bugreport.
> > > > make[6]: *** [timvf_worker.o] Error 1
> > > > make[5]: *** [octeontx] Error 2
> > > > make[5]: *** Waiting for unfinished jobs....
> > > >   AR librte_pmd_opdl_event.a
> > > >   INSTALL-LIB librte_pmd_opdl_event.a
> > > >   AR librte_pmd_sw_event.a
> > > >   INSTALL-LIB librte_pmd_sw_event.a
> > > > make[4]: *** [event] Error 2
> > > > make[3]: *** [drivers] Error 2
> > > > make[2]: *** [all] Error 2
> > > > make[1]: *** [pre_install] Error 2
> > > > make: *** [install] Error
> > > > """
> > > >
> > > > The compilation only passes with
> CONFIG_RTE_LIBRTE_OCTEONTX_PMD,
> > > CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF and
> > > CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL set to false.
> > > > It also passes if I upgrade gcc, but can we have a fix for old gcc =
versions?
> > > >
> > > > Thanks,
> > > > Ali
> >