From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10075.outbound.protection.outlook.com [40.107.1.75]) by dpdk.org (Postfix) with ESMTP id 3AE765B3E; Mon, 31 Dec 2018 08:24:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hkRZgB/bEefSW+NLr5Dmld7y19nMo2hjWBu8I1RMe+w=; b=ShIVNf/Zn8UVQy2IRRwYBzZG4tL4sBy/i88f8UDBiL0y1AEKVwZgjTIEgUy6yWzGETnjX6uD20jdu/833JGBsfPcaKisd7tOWBfLUwKL6DcgYlPcnWqVw8TYR6+K3f2DkKAvND5Ac/TQleTUjlT8vYyIT4ngIUBlfBDpAbfr5Go= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4218.eurprd05.prod.outlook.com (52.134.108.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1471.20; Mon, 31 Dec 2018 07:23:59 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::b0a0:72a4:7547:1c3c]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::b0a0:72a4:7547:1c3c%4]) with mapi id 15.20.1471.019; Mon, 31 Dec 2018 07:23:59 +0000 From: Shahaf Shuler To: Slava Ovsiienko , Mordechay Haimovsky , "dev@dpdk.org" CC: Mordechay Haimovsky , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 1/3] net/mlx5: fix shared counter allocation logic Thread-Index: AQHUn7LgZhrQS6NgKkmXwgat7Y+REKWYcNUA Date: Mon, 31 Dec 2018 07:23:58 +0000 Message-ID: References: <1545748697-3385-4-git-send-email-motih@mellanox.com> <1545949196-3355-2-git-send-email-motih@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4218; 6:iyV0QzywYL7eHrtxpIEzjfSnha2IzuHbFbkAbAkGeTA7T6wymzbH8e4ADQoLFTRFGQSBvSa1YVCCAIGb0EpysXFApIPU+6pjs2IV5SBs26Kk3qYV6RZJxjQtHXN8nRFnJyXcRbHPjymDF/J92jdZ9qZXDJ4NnHzmOnQXD1q7tfxpyH6TZ6CY8QhViuzVNI1n2in1P7UzmIeliSw9Vg5dDJcL78wlBrQqgNLCg/FCNRpgYxxNwYYdEG1D+V/1SzOyrDIk9t4wM+VgDmV9I+3YqflReAOcZlz5fBHBv8a5R99Wi/fQnZP+NcyNV88YB6YYZDeqg4FLWDtWoMnUPfSDaG6UOIh6F3ZbrWORaipeb70URya+57oVBUK3etZhGeUlj10kMwbDjvibYw4MdlT+UyhZX1RiMMSMhMlnzga+jYgQe5pyhKa5JAgYv7fxWhGMIlUm9glbjvzp/HDv3mR+Iw==; 5:CtL9DaXt9U8pMd7R/orpwaXzYR3Ms1KZnd7ih63++J47L/Q01JLUm+IP9NCHe4pnMdXL0iHxXA3hSZfbnYTrczoWq+XJ4l/Yi7CuVZIB/1Prl/oVJna+L7Mxvs0XulJCEwMuI1bCPMFeciDYpOcu//wwP8p7QBIF46aUroZ8O2o=; 7:uy9r67xodu3TpHpyx1NKcNySgVoiLAkjVjYeyY7PfXJH3BvD0yiTmDQ45p2F4oPOh9Tm8QEAm2oeErzEty3yyYi24T9tC1XmHOWyXrAOWSxwI5f2ckRgqb+JWe8JQ36afnxQEZDWevzGvrdyVliI1g== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: b3dd6482-5cd1-49d2-6af8-08d66ef0ee6d x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600109)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4218; x-ms-traffictypediagnostic: DB7PR05MB4218: x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(3230021)(908002)(999002)(5005026)(6040522)(8220055)(2401047)(8121501046)(10201501046)(93006095)(93001095)(3231475)(944501520)(52105112)(3002001)(6055026)(6041310)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(20161123562045)(201708071742011)(7699051)(76991095); SRVR:DB7PR05MB4218; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4218; x-forefront-prvs: 0903DD1D85 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(39860400002)(346002)(396003)(366004)(136003)(13464003)(189003)(199004)(53936002)(74316002)(8936002)(86362001)(2906002)(6246003)(478600001)(486006)(68736007)(186003)(14454004)(105586002)(106356001)(5660300001)(110136005)(26005)(476003)(81156014)(256004)(14444005)(97736004)(9686003)(55016002)(81166006)(3846002)(6116002)(71190400001)(71200400001)(305945005)(7736002)(33656002)(2501003)(450100002)(11346002)(4326008)(66066001)(446003)(25786009)(6436002)(54906003)(229853002)(102836004)(316002)(99286004)(7696005)(6506007)(53546011)(76176011); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4218; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: LGGrkoipx04rg2XES+1iY+3MVzTa6JcAG0pJXiE/0c+gMRpsTKa/rqQR77P6kfQGv2Ch/nBUCvdMbwFYT0VBYw4KNXnbSO9zYhY/ulyd4NiUOQ680cr5g+ABzGMQ4WrjluoM0NIPVIqjouJeGXebAt95IIy7Es6MSKF5daG7L+k7LUgRqIirHqcsode2nponCe3YbIZ1YmJwlD8FCueW/9P66cBp+5Jk0cSGHCehBtngeSSBFNiS3QUGsriz6Qx8Kl1evbrMUIepGNCk5u/oaZViyC4X46M6ADAuwTfSaS6I1KhL2sWchjf8jJv2CiVo spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: b3dd6482-5cd1-49d2-6af8-08d66ef0ee6d X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Dec 2018 07:23:58.9927 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4218 Subject: Re: [dpdk-dev] [PATCH v2 1/3] net/mlx5: fix shared counter allocation logic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Dec 2018 07:24:10 -0000 Saturday, December 29, 2018 10:13 PM, Slava Ovsiienko: > Subject: Re: [dpdk-dev] [PATCH v2 1/3] net/mlx5: fix shared counter alloc= ation > logic >=20 > Moti, don't you forget to update flow_verbs_counter_release() ? > Only shared counters should be removed from the list. +1, thanks slava. Moti, I have no more comments on this series. Please fix above and send the next series w/ my Ack.=20 >=20 > WBR, > Slava >=20 > > -----Original Message----- > > From: dev On Behalf Of Mordechay Haimovsky > > Sent: Friday, December 28, 2018 0:20 > > To: dev@dpdk.org > > Cc: Mordechay Haimovsky ; stable@dpdk.org > > Subject: [dpdk-dev] [PATCH v2 1/3] net/mlx5: fix shared counter > > allocation logic > > > > This commit fixes the logic for searching and allocating a shared > > counter in mlx5_flow_verbs. > > Now only the shared counters in the counters list are checked for a > > match and not all the counters as before. > > > > Fixes: 84c406e74524 ("net/mlx5: add flow translate function") > > Cc: stable@dpdk.org > > > > Signed-off-by: Moti Haimovsky > > --- > > v2: > > * Modified commit header > > --- > > drivers/net/mlx5/mlx5_flow_verbs.c | 14 +++++++------- > > 1 file changed, 7 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/net/mlx5/mlx5_flow_verbs.c > > b/drivers/net/mlx5/mlx5_flow_verbs.c > > index 81ec59d..409e1cd 100644 > > --- a/drivers/net/mlx5/mlx5_flow_verbs.c > > +++ b/drivers/net/mlx5/mlx5_flow_verbs.c > > @@ -121,13 +121,13 @@ > > struct mlx5_flow_counter *cnt; > > int ret; > > > > - LIST_FOREACH(cnt, &priv->flow_counters, next) { > > - if (!cnt->shared || cnt->shared !=3D shared) > > - continue; > > - if (cnt->id !=3D id) > > - continue; > > - cnt->ref_cnt++; > > - return cnt; > > + if (shared) { > > + LIST_FOREACH(cnt, &priv->flow_counters, next) { > > + if (cnt->shared && cnt->id =3D=3D id) { > > + cnt->ref_cnt++; > > + return cnt; > > + } > > + } > > } > > cnt =3D rte_calloc(__func__, 1, sizeof(*cnt), 0); > > if (!cnt) { > > -- > > 1.8.3.1