DPDK patches and discussions
 help / color / mirror / Atom feed
From: Shahaf Shuler <shahafs@mellanox.com>
To: Emma Kenny <emma.kenny@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "anatoly.burakov@intel.com" <anatoly.burakov@intel.com>,
	"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1] examples/multi_process: fix build error
Date: Tue, 3 Jul 2018 12:10:24 +0000	[thread overview]
Message-ID: <DB7PR05MB44266BBCE9EC17D66E0C15D7C3420@DB7PR05MB4426.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20180702154021.17908-1-emma.kenny@intel.com>

Monday, July 2, 2018 6:40 PM, Emma Kenny:
> Subject: [PATCH v1] examples/multi_process: fix build error
> 
> Fix bug with undeclared variable name and calling a variable that is not
> member of struct.
> 
> CC main.o
> l2fwd_fork/main.c:  In function ‘main’: l2fwd_fork/main.c:1043:33:
>  error: ‘dev_info’ undeclared (first use in this function)
> rte_eth_dev_info_get(portid, &dev_info);
> 
> l2fwd_fork/main.c:1043:33: note: each undeclared identifier is reported only
> once for each function it appears in
> l2fwd_fork/main.c:1077:11: error: ‘struct rte_eth_txconf’
> has no member named ‘tx_offloads’
>    txq_conf.tx_offloads = local_port_conf.txmode.offloads;
> 
> make[1]: *** [main.o] Error 1
> make: *** [all] Error 2
> 
> Fixes: f8c02ca878af ("examples/multi_process: convert to new ethdev
> offloads API")
> Cc: shahafs@mellanox.com
> 
> Signed-off-by: Emma Kenny <emma.kenny@intel.com>

Acked-by: Shahaf Shuler <shahafs@mellanox.com>

> ---
>  examples/multi_process/l2fwd_fork/main.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/examples/multi_process/l2fwd_fork/main.c
> b/examples/multi_process/l2fwd_fork/main.c
> index 94318ab..62e3937 100644
> --- a/examples/multi_process/l2fwd_fork/main.c
> +++ b/examples/multi_process/l2fwd_fork/main.c
> @@ -1030,6 +1030,7 @@ main(int argc, char **argv)
>  		struct rte_eth_rxconf rxq_conf;
>  		struct rte_eth_txconf txq_conf;
>  		struct rte_eth_conf local_port_conf = port_conf;
> +		struct rte_eth_dev_info dev_info;
> 
>  		/* skip ports that are not enabled */
>  		if ((l2fwd_enabled_port_mask & (1 << portid)) == 0) { @@ -
> 1074,7 +1075,7 @@ main(int argc, char **argv)
>  		fflush(stdout);
>  		txq_conf = dev_info.default_txconf;
>  		txq_conf.txq_flags = ETH_TXQ_FLAGS_IGNORE;
> -		txq_conf.tx_offloads = local_port_conf.txmode.offloads;
> +		txq_conf.offloads = local_port_conf.txmode.offloads;
>  		ret = rte_eth_tx_queue_setup(portid, 0, nb_txd,
>  				rte_eth_dev_socket_id(portid),
>  				&txq_conf);
> --
> 2.9.5
> 
> --------------------------------------------------------------
> Intel Research and Development Ireland Limited Registered in Ireland
> Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
> Registered Number: 308263
> 
> 
> This e-mail and any attachments may contain confidential material for the
> sole use of the intended recipient(s). Any review or distribution by others is
> strictly prohibited. If you are not the intended recipient, please contact the
> sender and delete all copies.

  parent reply	other threads:[~2018-07-03 12:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-02 15:40 Emma Kenny
2018-07-02 15:55 ` Ferruh Yigit
2018-07-03 12:10 ` Shahaf Shuler [this message]
2018-07-11 17:24   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB7PR05MB44266BBCE9EC17D66E0C15D7C3420@DB7PR05MB4426.eurprd05.prod.outlook.com \
    --to=shahafs@mellanox.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=emma.kenny@intel.com \
    --cc=ferruh.yigit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).