From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0052.outbound.protection.outlook.com [104.47.1.52]) by dpdk.org (Postfix) with ESMTP id C6EB81BAFE for ; Wed, 11 Apr 2018 11:05:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=VWQWCerEHyOkrW9RMRxIr0k1CJEvCReaGSLUGOIKFu8=; b=x//450XEHameqT3NlsNEn04uuP9lWBglgmRYG8xtuFVacZWLgGV4XIP0qJP6atEASquI7at4PvSF0WeVVvYogfohMe4So5YpPcWLeRFlzUjPCE/YbX6teJ0EJrsTmijSBMxdu+Ad0CE0UtvSlNqf0MT4LJSg16oEqO4uCqoLpX8= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4476.eurprd05.prod.outlook.com (52.134.109.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.653.12; Wed, 11 Apr 2018 09:05:49 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::808d:386e:26f3:859f]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::808d:386e:26f3:859f%13]) with mapi id 15.20.0653.014; Wed, 11 Apr 2018 09:05:49 +0000 From: Shahaf Shuler To: =?iso-8859-1?Q?N=E9lio_Laranjeiro?= CC: Adrien Mazarguil , Yongseok Koh , "dev@dpdk.org" Thread-Topic: [PATCH v2] net/mlx5: fix link status initialization Thread-Index: AQHT0KRkja9G5gvOLEuUXumy3Yxu+KP7Ripw Date: Wed, 11 Apr 2018 09:05:49 +0000 Message-ID: References: <20180403044817.27457-1-shahafs@mellanox.com> <20180410061336.49844-1-shahafs@mellanox.com> <20180410081754.byft4mcgqa7wbmvx@laranjeiro-vm.dev.6wind.com> In-Reply-To: <20180410081754.byft4mcgqa7wbmvx@laranjeiro-vm.dev.6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4476; 7:BvFxhbSF+qRoqBXqpiBzh97YHVCU8MBK2Ss35aqc8av9sLrvNfpWUgW+e8zAAMImCYEQDgw3HqtalIuPX0zYMXsFyZTqVY98QUcs7IrL/q3dDkQAV/WGdSlP0ce9UAdE9tkIMz3QZpizXUkbM5A6Z8imRi4b1QBX561DoPL+UKOvoaGxJKi8fu6t5z3T0QVpatgZ3TTh3WQKW0FzSDQC4jkZ29vUabHepettVT9oDI9q39DQVwpnMHxMvE6Skvg4 x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(3008032)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4476; x-ms-traffictypediagnostic: DB7PR05MB4476: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231221)(944501327)(52105095)(10201501046)(3002001)(6055026)(6041310)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(20161123560045)(6072148)(201708071742011); SRVR:DB7PR05MB4476; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4476; x-forefront-prvs: 0639027A9E x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39380400002)(39860400002)(346002)(396003)(366004)(376002)(189003)(199004)(229853002)(9686003)(6506007)(66066001)(76176011)(97736004)(106356001)(59450400001)(99286004)(105586002)(102836004)(7696005)(86362001)(5250100002)(6246003)(53936002)(6116002)(33656002)(316002)(14454004)(3846002)(5660300001)(478600001)(81156014)(2900100001)(8936002)(26005)(446003)(68736007)(186003)(4326008)(7736002)(486006)(8676002)(11346002)(81166006)(25786009)(476003)(305945005)(74316002)(54906003)(6436002)(55016002)(3660700001)(6916009)(3280700002)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4476; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:3; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: osBan65sMf7JbmyZONhZ2RfrqQ9YcAyRz4sYhJPC281ZrRBmVk5eRpTGI0l6bkL/Zni2J5ytUfom5zYPZrlbptdJqMEwHgUApPIUz+GeSdrSJuBCWKBJ27PiGFkQdDC55HzG26KBd0QZfQbS2vmvG15eT4rDzO5BPI8+eSNh/3SnjBhkg8n8oMGPq+DYEhyYCryqU0YfFmKOHBGftDh5y5Zle+P29vSZjWo6zpi7rHONDfuWlC7aNutfB0eXqspP7PQSK4oNsADx8dKYhjoGZ9zAdGtzToPl7XE0W0cam1jdWA8gjZuYBSFAthZxv++7Z13XzbKdNv2gt01WzpPoZdwKZpOmXJdLY6TWgy6m0lfAKMDJ9tDnkPzoUf5gzHlB4SjCvUrgUU8X025pucOYqUYOISglcRt8Uq/vFUyoK2c= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 7e353819-1d4c-42f9-649d-08d59f8b6bb5 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e353819-1d4c-42f9-649d-08d59f8b6bb5 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Apr 2018 09:05:49.8332 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4476 Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix link status initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Apr 2018 09:05:53 -0000 Tuesday, April 10, 2018 11:18 AM, N=E9lio Laranjeiro: > Subject: Re: [PATCH v2] net/mlx5: fix link status initialization >=20 > On Tue, Apr 10, 2018 at 09:13:36AM +0300, Shahaf Shuler wrote: > > Following commit 7ba5320baa32 ("net/mlx5: fix link status behavior") > > The initial link status is no longer set as part of the port start. > > > > When LSC interrupts are enabled, ethdev layer reads the link status > > directly from the device data instead of using the PMD callback. > > This may cause application to query the link as down while in fact it > > was already up before the DPDK application start (and no interrupt to > > fix it). > > > > Fixes: 7ba5320baa32 ("net/mlx5: fix link status behavior") > > Cc: nelio.laranjeiro@6wind.com > > > > Signed-off-by: Shahaf Shuler > > Acked-by: Yongseok Koh > > --- > > > > On v2: > > - Reworded commit log. > > - Cleared the wait_to_complete on the link update call. > > > > --- > > drivers/net/mlx5/mlx5.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index > > cfab558979..3d222df707 100644 > > --- a/drivers/net/mlx5/mlx5.c > > +++ b/drivers/net/mlx5/mlx5.c > > @@ -991,6 +991,12 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv > __rte_unused, > > DRV_LOG(DEBUG, "port %u forcing Ethernet interface up", > > eth_dev->data->port_id); > > mlx5_set_link_up(eth_dev); > > + /* > > + * Even though the interrupt handler is not installed yet, > > + * interrupts will still trigger on the asyn_fd from > > + * Verbs context returned by ibv_open_device(). > > + */ > > + mlx5_link_update(eth_dev, 0); > > /* Store device configuration on private structure. */ > > priv->config =3D config; > > continue; > > -- > > 2.12.0 >=20 > You should have linked this patch with the ethdev one[1], if the ethdev i= s > refused, this patch won't solve anything. >=20 > With a reserves of acceptance of [1]: > Acked-by: Nelio Laranjeiro As the ethdev pathc applied -> Applied to next-net-mlx, thanks