From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140049.outbound.protection.outlook.com [40.107.14.49]) by dpdk.org (Postfix) with ESMTP id 326BF2BD5 for ; Sun, 9 Dec 2018 07:03:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P8HBd18PVGy1FHwc9QHxkr1fBapceZlz5fFJ93a3YiI=; b=GvgtyOJyRBr14+V3O/dzN5MqhSMHOvtKEBqSZ7yM0y2bwUN7quDz6fHwHMRDZ/W2hM7xj7PCV3/44cI07v4jCmfKZ+CDVNG+wFxyMFRD+tG1hbTRTHj47Du9DqENstwTgffqF4bpqG3g9NgSvphuLDyMlur3ret4expZKvvihVs= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB5528.eurprd05.prod.outlook.com (20.177.192.225) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1404.17; Sun, 9 Dec 2018 06:03:57 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::f59c:f6f0:665b:8b16]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::f59c:f6f0:665b:8b16%4]) with mapi id 15.20.1404.025; Sun, 9 Dec 2018 06:03:57 +0000 From: Shahaf Shuler To: Tom Barbette , "dev@dpdk.org" CC: "bruce.richardson@intel.com" , "john.mcnamara@intel.com" , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , Yongseok Koh Thread-Topic: [RFC PATCH 2/3] mlx5: Implement support for read_clock Thread-Index: AQHUhwBX9XdhMqZ/r0OemXluKya22aV1+vfA Date: Sun, 9 Dec 2018 06:03:57 +0000 Message-ID: References: <1543398732-79439-1-git-send-email-barbette@kth.se> <1543398732-79439-3-git-send-email-barbette@kth.se> In-Reply-To: <1543398732-79439-3-git-send-email-barbette@kth.se> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.105] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB5528; 6:UU3HWcQaVZKNtwr8m0RYwtWwBkjEC0UF1/vqPUk3qpd6O61K/5O923bqEa88uBVxTzzOLgP8ezhYS1LwhK4Ql0sIB3Mt9WQgQa0SaYyZf5q4m+r79tbx6rcLwPHBmy5ABQYW+/+s+6HG6NXQN8iR/VtraQJbwRNyQ4wzVDAA4Odsz+OAzI13BAVVkVm+r7E0bhgiGXKvHzBDDaFzXxhro9KeSb7F+8dX4CGxbhQpcVPwXzKtV37OBYMFSTjEci4YftIXM62QT7O7ZzSuf4HrGLrWcCkRZRzPbXebMPpkk2/EkNbyS6fz61QnnAquTi30leXqopcZVWOEqi3QoWQ6gHw97WYQd1VjFw9dwc/zfgfSzdFhY9tXkBWjT3ZhHoqvhMKtjFGXAV8a+gplmY9PYxwuG/O4NccoofhWCfTrbQA6LYmN1dBoaToXAr7aIUKI2dFnHLFVtQg3XWu+6Xz9iw==; 5:XHBwOemZOW49xbk9maVoBbi5vPRe6wM5O6gWebgzUlFqF57LTpNC6xJ6+8FdeYOX++2UD2p5/ObVQJFIB7Qz5RbdIRkAI3HqhQjYp162H1thbz+F2fQXHSquNRQF0ggAoZnxE/UHCXvc2T2EE5hboRzOlBeiH5I44Ni3p0horqc=; 7:jfIeNga9iMAoy72ktCYGDSPGdxgtZBHs3WOkPVmoWaKms5AeuBGPgEvb6R/hEkSqh83NuDiK6l9p6PFlrLAu4FfeRkinJpDyG2aQyik3kH8kUK5XSUqWW94TS+PeTdL6SSyFyignd3HslvClLbGNeQ== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 6a918863-5e6d-4a9d-9f51-08d65d9c1b95 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB5528; x-ms-traffictypediagnostic: DB7PR05MB5528: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(3230017)(999002)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231472)(944501520)(52105112)(10201501046)(3002001)(6055026)(148016)(149066)(150057)(6041310)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095); SRVR:DB7PR05MB5528; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB5528; x-forefront-prvs: 0881A7A935 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(39850400004)(346002)(376002)(136003)(366004)(189003)(199004)(8676002)(81156014)(81166006)(8936002)(14454004)(86362001)(105586002)(97736004)(106356001)(33656002)(14444005)(256004)(217873002)(66066001)(2501003)(478600001)(25786009)(6436002)(99286004)(102836004)(6116002)(3846002)(54906003)(53936002)(229853002)(7736002)(6506007)(55016002)(110136005)(4326008)(7696005)(305945005)(74316002)(186003)(476003)(71190400001)(26005)(71200400001)(316002)(2906002)(107886003)(486006)(76176011)(6246003)(68736007)(11346002)(446003)(5660300001)(9686003); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB5528; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: fdzZhz4/oTbCol+DwZzCD9Vutv3A6rsZZVTbwdzXvInd3GNGJIOAiFvtk/sNTMBgS4t8XzmLGAzq0C3xsrwCS6Mjx62vlOf9DBxXC9XAEAaflLhTDuL2MYrsiyMktptZuPh34WD4n6Kwv+wEMyuTlg/Yv5CHTOGZrt9CFVsOkTTLRJ0+DeH5Tl80pNl74Uz0ECrwjdtq6UhLJ52piSYCbIyHT6zxK8Ma2rLno2uBpFCnE3mwVlvJDAoJ9WIiqvagMG4wb5UUjnrYnEo0F6NI6dheMoDlb0AZ/nivrdKV9FWAWjV/HsERNNDo29iHKeIslRxIrvu7YaaDISzm5vYPcuVSLAusi4TJyeHuiwZWux0= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6a918863-5e6d-4a9d-9f51-08d65d9c1b95 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Dec 2018 06:03:57.7374 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB5528 Subject: Re: [dpdk-dev] [RFC PATCH 2/3] mlx5: Implement support for read_clock X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Dec 2018 06:03:59 -0000 Hi Tom, See few comments.=20 Wednesday, November 28, 2018 11:52 AM, Tom Barbette: > Subject: [RFC PATCH 2/3] mlx5: Implement support for read_clock >=20 > Signed-off-by: Tom Barbette > --- > drivers/net/mlx5/mlx5.c | 1 + > drivers/net/mlx5/mlx5.h | 1 + > drivers/net/mlx5/mlx5_ethdev.c | 31 > +++++++++++++++++++++++++++++++ > drivers/net/mlx5/mlx5_glue.c | 8 ++++++++ > drivers/net/mlx5/mlx5_glue.h | 2 ++ > 5 files changed, 43 insertions(+) >=20 > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index > 9e5cab169..ed799ab5a 100644 > --- a/drivers/net/mlx5/mlx5.c > +++ b/drivers/net/mlx5/mlx5.c > @@ -372,6 +372,7 @@ const struct eth_dev_ops mlx5_dev_ops =3D { > .xstats_reset =3D mlx5_xstats_reset, > .xstats_get_names =3D mlx5_xstats_get_names, > .dev_infos_get =3D mlx5_dev_infos_get, > + .read_clock =3D mlx5_read_clock, > .dev_supported_ptypes_get =3D mlx5_dev_supported_ptypes_get, > .vlan_filter_set =3D mlx5_vlan_filter_set, > .rx_queue_setup =3D mlx5_rx_queue_setup, diff --git > a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index > bc500b2bc..3972debf5 100644 > --- a/drivers/net/mlx5/mlx5.h > +++ b/drivers/net/mlx5/mlx5.h > @@ -258,6 +258,7 @@ int mlx5_set_flags(struct rte_eth_dev *dev, unsigned > int keep, > unsigned int flags); > int mlx5_dev_configure(struct rte_eth_dev *dev); void > mlx5_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info > *info); > +int mlx5_read_clock(struct rte_eth_dev *dev, uint64_t *time); > const uint32_t *mlx5_dev_supported_ptypes_get(struct rte_eth_dev > *dev); int mlx5_link_update(struct rte_eth_dev *dev, int > wait_to_complete); int mlx5_force_link_status_change(struct rte_eth_dev > *dev, int status); diff --git a/drivers/net/mlx5/mlx5_ethdev.c > b/drivers/net/mlx5/mlx5_ethdev.c index d178ed6a1..eb97ab27e 100644 > --- a/drivers/net/mlx5/mlx5_ethdev.c > +++ b/drivers/net/mlx5/mlx5_ethdev.c > @@ -557,6 +557,37 @@ mlx5_dev_infos_get(struct rte_eth_dev *dev, > struct rte_eth_dev_info *info) > } > } >=20 > +/** > + * Get device current raw clock counter > + * > + * @param dev > + * Pointer to Ethernet device structure. > + * Above space is not needed.=20 > + * @param[out] time > + * Current raw clock counter of the device. > + * > + * @return > + * 0 if the clock has correctly been read And if not?=20 > + */ > +int > +mlx5_read_clock(struct rte_eth_dev *dev, uint64_t *clock) { > + struct priv *priv =3D dev->data->dev_private; > + struct ibv_values_ex values; > + int err =3D 0; > + > + values.comp_mask =3D IBV_VALUES_MASK_RAW_CLOCK; > + err =3D mlx5_glue->query_rt_values_ex(priv->ctx, &values); > + if (err !=3D 0) { > + DRV_LOG(WARNING, "Could not query the clock !"); > + return err; > + } > + Above space is not needed.=20 > + *clock =3D values.raw_clock.tv_nsec; > + return 0; > +} > + > + > /** > * Get supported packet types. > * > diff --git a/drivers/net/mlx5/mlx5_glue.c b/drivers/net/mlx5/mlx5_glue.c > index dd10ad6de..e23296519 100644 > --- a/drivers/net/mlx5/mlx5_glue.c > +++ b/drivers/net/mlx5/mlx5_glue.c > @@ -86,6 +86,13 @@ mlx5_glue_query_device_ex(struct ibv_context > *context, > return ibv_query_device_ex(context, input, attr); } >=20 > +static int > +mlx5_glue_query_rt_values_ex(struct ibv_context *context, > + struct ibv_values_ex *values) > +{ > + return ibv_query_rt_values_ex(context, values); } > + > static int > mlx5_glue_query_port(struct ibv_context *context, uint8_t port_num, > struct ibv_port_attr *port_attr) @@ -491,6 +498,7 @@ > const struct mlx5_glue *mlx5_glue =3D &(const struct mlx5_glue){ > .close_device =3D mlx5_glue_close_device, > .query_device =3D mlx5_glue_query_device, > .query_device_ex =3D mlx5_glue_query_device_ex, > + .query_rt_values_ex =3D mlx5_glue_query_rt_values_ex, > .query_port =3D mlx5_glue_query_port, > .create_comp_channel =3D mlx5_glue_create_comp_channel, > .destroy_comp_channel =3D mlx5_glue_destroy_comp_channel, diff -- > git a/drivers/net/mlx5/mlx5_glue.h b/drivers/net/mlx5/mlx5_glue.h index > 2d92ba8bc..31ebee72a 100644 > --- a/drivers/net/mlx5/mlx5_glue.h > +++ b/drivers/net/mlx5/mlx5_glue.h > @@ -70,6 +70,8 @@ struct mlx5_glue { > int (*query_device_ex)(struct ibv_context *context, > const struct ibv_query_device_ex_input *input, > struct ibv_device_attr_ex *attr); > + int (*query_rt_values_ex)(struct ibv_context *context, > + struct ibv_values_ex *values); You need to bump up the LIB_GLUE_VERSION to 19.02 on the makefile(s) as you= change the lib glue ABI.=20 > int (*query_port)(struct ibv_context *context, uint8_t port_num, > struct ibv_port_attr *port_attr); > struct ibv_comp_channel *(*create_comp_channel) > -- > 2.17.1