From: Shahaf Shuler <shahafs@mellanox.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
Andrew Rybchenko <arybchenko@solarflare.com>,
Thomas Monjalon <thomasm@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] ethdev: make default behavior CRC strip on Rx
Date: Tue, 4 Sep 2018 05:17:21 +0000 [thread overview]
Message-ID: <DB7PR05MB44267FADD10982A614416955C3030@DB7PR05MB4426.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20180903144501.31373-1-ferruh.yigit@intel.com>
Hi Ferruh,
Monday, September 3, 2018 5:45 PM, Ferruh Yigit:
> Removed DEV_RX_OFFLOAD_CRC_STRIP offload flag.
> Without any specific Rx offload flag, default behavior by PMDs is to
> strip CRC.
>
> PMDs that support keeping CRC should advertise
> DEV_RX_OFFLOAD_KEEP_CRC
> Rx offload capability.
>
> Applications that require keeping CRC should check PMD capability first
> and if it is supported can enable this feature by setting
> DEV_RX_OFFLOAD_KEEP_CRC in Rx offload flag in rte_eth_dev_configure()
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
[...]
> diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
> index 1f7bfd441..718f4b1d9 100644
> --- a/drivers/net/mlx5/mlx5_rxq.c
> +++ b/drivers/net/mlx5/mlx5_rxq.c
> @@ -388,7 +388,6 @@ mlx5_get_rx_queue_offloads(struct rte_eth_dev
> *dev)
> DEV_RX_OFFLOAD_TIMESTAMP |
> DEV_RX_OFFLOAD_JUMBO_FRAME);
>
> - offloads |= DEV_RX_OFFLOAD_CRC_STRIP;
> if (config->hw_fcs_strip)
> offloads |= DEV_RX_OFFLOAD_KEEP_CRC;
>
> @@ -1438,7 +1437,7 @@ mlx5_rxq_new(struct rte_eth_dev *dev, uint16_t
> idx, uint16_t desc,
> tmpl->rxq.vlan_strip = !!(offloads & DEV_RX_OFFLOAD_VLAN_STRIP);
> /* By default, FCS (CRC) is stripped by hardware. */
> tmpl->rxq.crc_present = 0;
> - if (rte_eth_dev_must_keep_crc(offloads)) {
> + if (offloads | DEV_RX_OFFLOAD_KEEP_CRC) {
I don't understand this logic, and it exists on many other location in the patch.
Shouldn't it be (offloads & DEV_RX_OFFLOAD_KEEP_CRC) ?
> if (config->hw_fcs_strip) {
> tmpl->rxq.crc_present = 1;
> } else {
Also I think the CRC offload should have an entry on the port caps printed by testpmt "show port caps 0" (see port_offload_cap_display()).
next prev parent reply other threads:[~2018-09-04 5:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 14:45 Ferruh Yigit
2018-09-03 13:59 ` Andrew Rybchenko
2018-09-04 5:13 ` Shahaf Shuler
2018-09-04 5:17 ` Shahaf Shuler [this message]
2018-09-04 5:54 ` Andrew Rybchenko
2018-09-04 8:06 ` Ferruh Yigit
2018-09-04 6:29 ` Tomasz Duszynski
2018-09-04 10:12 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2018-09-04 10:02 ` Shahaf Shuler
2018-09-14 11:37 ` Ferruh Yigit
2018-09-19 7:34 ` David Marchand
2018-09-19 18:04 ` Ferruh Yigit
2018-09-10 7:13 ` Maxime Coquelin
2018-09-10 10:40 ` Jan Remeš
2018-09-10 11:34 ` Jerin Jacob
2018-09-18 13:05 ` Legacy, Allain
2018-09-11 8:05 ` Hyong Youb Kim
2018-09-24 17:31 ` [dpdk-dev] [PATCH] doc: announce CRC strip changes in release notes Ferruh Yigit
2018-09-24 17:01 ` Thomas Monjalon
2018-09-24 17:12 ` David Marchand
2018-09-25 15:03 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR05MB44267FADD10982A614416955C3030@DB7PR05MB4426.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=thomasm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).