From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20085.outbound.protection.outlook.com [40.107.2.85]) by dpdk.org (Postfix) with ESMTP id 1D3B810A3 for ; Thu, 1 Nov 2018 09:03:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RO6ck9oVvji/vxfJArsqZfTj607zL/slipjGJZ8q4pI=; b=uSwekcjB2AUrXNEZGbR7gA8QIVmS7X23a4xAd90BAvWuejQLvmbrVEpTUr6nBWCbUCgI3677Z/6ishXYzPoUQdKjUwNFEb4nJD2rFzdRzAl1gukzgxtdyx6X008InGVuZn1e8Ua42Orz6j6UExNIRPEW9aYv71T14JFGlERTHmI= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4297.eurprd05.prod.outlook.com (52.134.108.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.21; Thu, 1 Nov 2018 08:03:36 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::80e:e6b:baf2:d973]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::80e:e6b:baf2:d973%3]) with mapi id 15.20.1273.027; Thu, 1 Nov 2018 08:03:36 +0000 From: Shahaf Shuler To: Yongseok Koh CC: "dev@dpdk.org" Thread-Topic: [PATCH v2 1/2] net/mlx5: move device spawn configuration to probing Thread-Index: AQHUcCUNAi6Mz+QHO0+MvFXVy9cG7qU6jLPQ Date: Thu, 1 Nov 2018 08:03:36 +0000 Message-ID: References: <20181029231509.39886-1-yskoh@mellanox.com> <20181030074901.40342-1-yskoh@mellanox.com> <20181030074901.40342-2-yskoh@mellanox.com> In-Reply-To: <20181030074901.40342-2-yskoh@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4297; 6:IIoKcby7jGfhBxAVyGb5zqm18noizgZB3oPQVD8IcCiH6XQHRGwe7xdl+MtrAX5596q7opW1QYN2oRrSA4gX1pYSiKArEMTap9Or4W+MNtUESwCOHBWmFdItnszm3VmekZFFHKVKoM8UhW4nUhQcXBQNBEBRbClsvQW3F5AlgKWTnq4pJAVjZ7vj+3Vkv5qW6LlIslS7YtZtQvz5FUoHbVJQ7+j4Ay4eUJqm07FwXUexOs/1cMMKp3aj+Z1e0LOBhieW9c0TaLijq6InX7Xee3P82m5197qmw06OcZhWEGb20RenLlXgtWf+dwxNpSAkDi69WyLxDH9mNK7fDNXKf0uJBVpIS/clBLUwD12+HER7fHAnrfoFy4LPcVfWZUGEQnGNAMUI92TYW30pvmGUXzo0wtgjb7TKU4PWSvDF+7qACT8oLRiX2HSw2pTCwf28RaJM/MRKFcp3Qv2V/lVBPg==; 5:3Ya31rKnWyprs1i9lm12uYxSAxgrcHHX2t4LYDPd9O/4SxSZcSnWFLLU25wyleVPL0ZCUmPHZdU7a7QSW9cvf5oKC9Qy/FRaswAZhwkqVRK6Oci+pv/kJGG6m01v220EAb0VplKvtw+dQwHNWXnhbCQLB1bDe4REgaTd0P8oWkk=; 7:bDhlsxrrHxuJYuV6htq3+4PTHXv74rPi6qKnuP8/OVYbp03TLDq8eOnK7J5Pr/0FyowYcTAvw2w9SdL6S7ylDTJ7DZFV0NURfCpbDAqioWpl4CS5y4Wy+Op8EijEmSAank4zTFGQhzoaCt+ZayF9ug== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 619b7656-1e9f-4895-d040-08d63fd086ca x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4297; x-ms-traffictypediagnostic: DB7PR05MB4297: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231382)(944501410)(52105095)(6055026)(148016)(149066)(150057)(6041310)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095); SRVR:DB7PR05MB4297; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4297; x-forefront-prvs: 0843C17679 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(376002)(346002)(39860400002)(136003)(366004)(189003)(199004)(99286004)(33656002)(26005)(478600001)(68736007)(106356001)(229853002)(5250100002)(6862004)(53936002)(2906002)(6506007)(9686003)(3846002)(8936002)(6116002)(316002)(7696005)(105586002)(4326008)(76176011)(102836004)(55016002)(97736004)(8676002)(6636002)(25786009)(2900100001)(81166006)(6436002)(7736002)(81156014)(186003)(74316002)(86362001)(5660300001)(66066001)(11346002)(446003)(6246003)(476003)(486006)(71190400001)(14444005)(256004)(14454004)(71200400001)(305945005)(309714004); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4297; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: F6u78nm7EJPpW8zgDf5esVkawHhR88TL0EsbvR8xVC9oWvEvzMCMQ7BOWTmhPCAn0MFqCchZfKbxemwnvCcwA8D8kJeEdnd+q8HoCDL0qVdC5H8eRSjTNmQqzvSbKLmyIQTt/AjFdXk7ydK/bu0suUYSnXodv8M+E6zfPMEeeNIXfnyRDs13RPtgHpCabKblk45S+Hrq34asPg6ILt6H/GxstVrGY3V1t0PUxMCD2j5BOA8kZ8gf32Dauno3WHVYzw0CPe6VwbS7R35T2Vj4n45AzpnsujmqdNKs03Ism/tvrkKqDM8ZtcX3JFQbVWohgf1+4zqqvD1sSCpP5W2dQlZ84sZK57Ofnx7DSIvGHc0= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 619b7656-1e9f-4895-d040-08d63fd086ca X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Nov 2018 08:03:36.5038 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4297 Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/mlx5: move device spawn configuration to probing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Nov 2018 08:03:38 -0000 Hi Koh,=20 Since I have comment on the other patch small nit.=20 Tuesday, October 30, 2018 9:49 AM, Yongseok Koh: > Subject: [PATCH v2 1/2] net/mlx5: move device spawn configuration to > probing >=20 Probably you need to add log about the motivation for this change.=20 > Signed-off-by: Yongseok Koh > --- > drivers/net/mlx5/mlx5.c | 54 ++++++++++++++++++++++++------------------- > ------ > 1 file changed, 27 insertions(+), 27 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index > ec6a482a9a..6fa50ba1b1 100644 > --- a/drivers/net/mlx5/mlx5.c > +++ b/drivers/net/mlx5/mlx5.c > @@ -704,8 +704,8 @@ mlx5_uar_init_secondary(struct rte_eth_dev *dev) > * Backing DPDK device. > * @param ibv_dev > * Verbs device. > - * @param vf > - * If nonzero, enable VF-specific features. > + * @param config > + * Device configuration parameters Missing period.=20 > * @param[in] switch_info > * Switch properties of Ethernet device. > * > @@ -719,7 +719,7 @@ mlx5_uar_init_secondary(struct rte_eth_dev *dev) > static struct rte_eth_dev * mlx5_dev_spawn(struct rte_device *dpdk_dev, > struct ibv_device *ibv_dev, > - int vf, > + struct mlx5_dev_config config, > const struct mlx5_switch_info *switch_info) { > struct ibv_context *ctx; > @@ -727,24 +727,6 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev, > struct ibv_port_attr port_attr; > struct ibv_pd *pd =3D NULL; > struct mlx5dv_context dv_attr =3D { .comp_mask =3D 0 }; > - struct mlx5_dev_config config =3D { > - .vf =3D !!vf, > - .cqe_pad =3D 0, > - .mps =3D MLX5_ARG_UNSET, > - .tx_vec_en =3D 1, > - .rx_vec_en =3D 1, > - .mpw_hdr_dseg =3D 0, > - .txq_inline =3D MLX5_ARG_UNSET, > - .txqs_inline =3D MLX5_ARG_UNSET, > - .inline_max_packet_sz =3D MLX5_ARG_UNSET, > - .vf_nl_en =3D 1, > - .mprq =3D { > - .enabled =3D 0, > - .stride_num_n =3D MLX5_MPRQ_STRIDE_NUM_N, > - .max_memcpy_len =3D > MLX5_MPRQ_MEMCPY_DEFAULT_LEN, > - .min_rxqs_num =3D MLX5_MPRQ_MIN_RXQS, > - }, > - }; > struct rte_eth_dev *eth_dev =3D NULL; > struct priv *priv =3D NULL; > int err =3D 0; > @@ -1176,7 +1158,7 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev, > eth_dev->dev_ops =3D &mlx5_dev_ops; > /* Register MAC address. */ > claim_zero(mlx5_mac_addr_add(eth_dev, &mac, 0, 0)); > - if (vf && config.vf_nl_en) > + if (config.vf && config.vf_nl_en) > mlx5_nl_mac_addr_sync(eth_dev); > priv->tcf_context =3D mlx5_flow_tcf_context_create(); > if (!priv->tcf_context) { > @@ -1345,7 +1327,7 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv > __rte_unused, { > struct ibv_device **ibv_list; > unsigned int n =3D 0; > - int vf; > + struct mlx5_dev_config dev_config; > int ret; >=20 > assert(pci_drv =3D=3D &mlx5_driver); > @@ -1443,21 +1425,39 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv > __rte_unused, > */ > if (n) > qsort(list, n, sizeof(*list), mlx5_dev_spawn_data_cmp); > + /* Default configuration. */ > + dev_config =3D (struct mlx5_dev_config){ > + .mps =3D MLX5_ARG_UNSET, > + .tx_vec_en =3D 1, > + .rx_vec_en =3D 1, > + .txq_inline =3D MLX5_ARG_UNSET, > + .txqs_inline =3D MLX5_ARG_UNSET, > + .inline_max_packet_sz =3D MLX5_ARG_UNSET, > + .vf_nl_en =3D 1, > + .mprq =3D { > + .enabled =3D 0, /* Disabled by default. */ > + .stride_num_n =3D MLX5_MPRQ_STRIDE_NUM_N, > + .max_memcpy_len =3D > MLX5_MPRQ_MEMCPY_DEFAULT_LEN, > + .min_rxqs_num =3D MLX5_MPRQ_MIN_RXQS, > + }, > + }; > + /* Device speicific configuration. */ > switch (pci_dev->id.device_id) { > case PCI_DEVICE_ID_MELLANOX_CONNECTX4VF: > case PCI_DEVICE_ID_MELLANOX_CONNECTX4LXVF: > case PCI_DEVICE_ID_MELLANOX_CONNECTX5VF: > case PCI_DEVICE_ID_MELLANOX_CONNECTX5EXVF: > - vf =3D 1; > + dev_config.vf =3D 1; > break; > default: > - vf =3D 0; > + break; > } > for (i =3D 0; i !=3D n; ++i) { > uint32_t restore; >=20 > - list[i].eth_dev =3D mlx5_dev_spawn > - (&pci_dev->device, list[i].ibv_dev, vf, &list[i].info); > + list[i].eth_dev =3D mlx5_dev_spawn(&pci_dev->device, > + list[i].ibv_dev, dev_config, > + &list[i].info); > if (!list[i].eth_dev) { > if (rte_errno !=3D EBUSY && rte_errno !=3D EEXIST) > break; > -- > 2.11.0