From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50061.outbound.protection.outlook.com [40.107.5.61]) by dpdk.org (Postfix) with ESMTP id E23AC1B61D for ; Tue, 3 Apr 2018 07:19:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=cGc8o4fzQheOlxDm0IX03NjB1C0W9O/X7fDcbxhcaOw=; b=yF96cj9kgxfAj/gv9toR7xmE2jEBhgUu1wf8hnnLnYLhoOCrlLI+IUAlnTUw6DEMzEWmehugMfBJk7VfjCmaq6GArfIhiSB0yuBB2iQEiGAlKhTegYyJtLyofCrn0GxuEhFrw25/TgZza9ZsDhIB4Nd4VqEFVWlrg1ihbmlwEC8= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4251.eurprd05.prod.outlook.com (52.134.108.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.631.10; Tue, 3 Apr 2018 05:19:35 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::808d:386e:26f3:859f]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::808d:386e:26f3:859f%13]) with mapi id 15.20.0631.013; Tue, 3 Apr 2018 05:19:36 +0000 From: Shahaf Shuler To: Thomas Monjalon CC: "dev@dpdk.org" , Ajit Khaparde , Jerin Jacob , Shijith Thotton , Santosh Shukla , Rahul Lakkireddy , John Daley , Wenzhuo Lu , Konstantin Ananyev , Beilei Xing , Qi Zhang , Jingjing Wu , Adrien Mazarguil , =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , Yongseok Koh , "Tomasz Duszynski" , Jianbo Liu , "Alejandro Lucero" , Hemant Agrawal , Shreyansh Jain , "Harish Patil" , Rasesh Mody , "Andrew Rybchenko" , Shrikrishna Khare , Maxime Coquelin , Allain Legacy , Bruce Richardson , Gaetan Rivet , Olivier Matz Thread-Topic: Survey for final decision about per-port offload API Thread-Index: AQHTyC3CbGCTyIXro0mFjUrcVyTSnaPrVRuAgAJQFwCAAN3sAA== Date: Tue, 3 Apr 2018 05:19:35 +0000 Message-ID: References: <2759953.P7QpFFSjiU@xps> <3164302.jtqUZe9MAY@xps> In-Reply-To: <3164302.jtqUZe9MAY@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.107] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4251; 7:L6hMwVEwpUFOxtYs66yXpy0ZpQ5ykfVOiyeS9vCrDo/zT8+rAcPzWwc2ObcRV46aKitlOaAMedgSDvKVMa/W1rUqyGdkg/yeT+DPcPGJ2/ppbrsHM9AVsCzIWiY576dhTEdRhgQKDi5mgBjYDKhtpsS4MvWNNpSe0qtsxYDOdGbdMRyPCmTbR9Ico/LmQwBrNQa98wfhzyHRtLEvP33f8fdWrZoe8VfMs7jnsD/XJkosk0hYOcABWQSx7XJczZYB x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 7cc3d797-6e57-47f5-ad59-08d599227dbc x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4251; x-ms-traffictypediagnostic: DB7PR05MB4251: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231221)(944501327)(52105095)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041310)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(6072148)(201708071742011); SRVR:DB7PR05MB4251; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4251; x-forefront-prvs: 0631F0BC3D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(366004)(376002)(39860400002)(396003)(39380400002)(189003)(199004)(7696005)(305945005)(76176011)(6116002)(9686003)(39060400002)(74316002)(478600001)(14454004)(33656002)(6916009)(5250100002)(106356001)(25786009)(8656006)(5660300001)(99286004)(55016002)(3846002)(7416002)(2906002)(8936002)(81156014)(53936002)(8676002)(3280700002)(26005)(81166006)(6506007)(54906003)(186003)(97736004)(102836004)(476003)(486005)(229853002)(3660700001)(66066001)(446003)(11346002)(86362001)(105586002)(6246003)(7736002)(316002)(486005)(6436002)(4326008)(68736007)(2900100001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4251; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: dSxX9h5YUrbmwbi9yZk3iPgDghwiJmIDcsYYJKSHf4/50NF4i16GY7itdXwtSxu4LyOR9FiBCxRk574lXfLfb8BnMChoK5KGeFNcIzVpNsPtLp9px+hDcI3vPttC9gHAFLUqqvEvG4DaXq+sMM0vtsRl5MpfV0wLA8aJYHLLFlf/mQR8x0sppTHdcLlTSYnL20iIMtLafVgRDiD4RrZGRjqgXGKBXP4uOp3pGMtP/4DoEaUP3In5s+8oaV9+PdUC80y3hbHTVKvzzn70ts6vUAK/P/Itb7EFU07p7nCKT7ptZGmROFCoCsqt2IDYXxU2aHZ4P6of8DfTeuafWGw/4FtWuYwhPyfQgQLo/u7+EKt7e/3GKoc3E/S/Fg3HlliEkR5lLjbREEnSoIZBS7WnPi/EBerX4Byv6yT9mn4TpB0= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7cc3d797-6e57-47f5-ad59-08d599227dbc X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Apr 2018 05:19:35.7904 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4251 Subject: Re: [dpdk-dev] Survey for final decision about per-port offload API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Apr 2018 05:19:41 -0000 Monday, April 2, 2018 6:54 PM, Thomas Monjalon: > 01/04/2018 06:44, Shahaf Shuler: > > > There is the same kind of confusion in the offload capabilities: > > > rte_eth_dev_info.[rt]x_offload_capa > > > rte_eth_dev_info.[rt]x_queue_offload_capa > > > The queue capabilities must be a subset of port capabilities, i.e. > > > every queue capabilities must be reported as port capabilities. > > > But the port capabilities should be reported at queue level only if > > > it can be applied to a specific queue. > > > > > > 4/ Do you agree with above statement (to be added in the doc)? > > > > No. > > > > The documentation should describe the API from the application side, an= d > not provide guidelines for the PMDs implementation. > > If missing, we should clarify more about what queue and port offload > means. Something like: > > "When port offload is enabled, the offload applies on the port along > > with all of its associated queues" and "When queue offload is enabled = the > offload, the offload applies only on the specific queue." > > > > The PMDs then will decide how they report the different offloads they > offer. >=20 > I don't understand why you want to be free in capabilities implementation= . > If the capabilities are not strictly standardized, how can they be used b= y the > application? They are standardize, according to the API. the rules of the APIs are: 1. port offload is applied to the port and all of its queues. 2. queue offload is applied only to the specific queue.=20 The two above are enough for the PMDs to understand how they should set the= offloads. We don't need to describe in the API that every queue offload is a port off= load (maybe there is some unreasonable limitation to some PMD to do so).=20 >=20 > Rewording from application point of view: >=20 > All the offload capabilities (port-level and queue-level) are reported in > rte_eth_dev_info.[rt]x_offload_capa. > The offloads reported in rte_eth_dev_info.[rt]x_queue_offload_capa can > be applied to a specific queue. >=20 > Is it OK? I think all we need is statements 1 and 2 above. However, I will not insist= about this one too much.=20 As a general statement, for any API that we will do, we should have a clear= distinction between "API definition" and "PMD guidelines for implementatio= n"=20 The API definition should have the most exact rules for the **application**= to understand how to work.=20 On the example above, the application doesn't care every port offload is qu= eue offload (this is PMD guideline). It only cares about 1 and 2. This is w= hat defines to it how to use the offloads API.=20 >=20