From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50077.outbound.protection.outlook.com [40.107.5.77]) by dpdk.org (Postfix) with ESMTP id B595A1B455 for ; Thu, 2 Aug 2018 12:35:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ffcGCJ6r3m3se3h4I9CttRoHliaHbd+RvJ8LRfEBcHo=; b=sRmvjL45VIcwO6dj0pQ9OVdmKvOSt44njqfqB3TeosgViJ2/OgDNGlVzLKXfyfvRxpvcnVFux0zVG11xG/PLxlKoKwM+dePSNZ6Vbg1hCMYjM9/YjqaXgLhJzADbb2Uo/tun0kYbDPbtctvk5sjO/JOCedQmi2qnpKKZPTLkha4= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4156.eurprd05.prod.outlook.com (52.134.107.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.995.19; Thu, 2 Aug 2018 10:35:28 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::52a:650b:ae10:fc3]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::52a:650b:ae10:fc3%4]) with mapi id 15.20.1017.010; Thu, 2 Aug 2018 10:35:28 +0000 From: Shahaf Shuler To: Shahaf Shuler , Yongseok Koh CC: "dev@dpdk.org" , Ori Kam , =?iso-8859-1?Q?N=E9lio_Laranjeiro?= Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix VLAN filtering Thread-Index: AQHUKKQ02gpsqkUI4kub+aFyV6Y0faSsR6dA Date: Thu, 2 Aug 2018 10:35:28 +0000 Message-ID: References: <20180731075720.112272-1-shahafs@mellanox.com> In-Reply-To: <20180731075720.112272-1-shahafs@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.105] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4156; 6:eqeIfeXCGTKxsTNVgp0kTnSQqAcOC2pe92HuzRc6BKtrSfF4v2Vil1j/YSF125vsHV/NkIk1nIkS4aUbhdymdOwmvfR/gWw3XvWqkOW0V4p8pLOsUCushJ/XQi11LPKdsjvPhx05d2C4pVg4a3+A/zahQlGWmL6zolNd0NLIGTJxIrjHpGVDiICXTCQTZWrAvvhVsmJGa6noP7JFsEZ4RzFc44dFqU3lih03DbV8sgBweqPnekKhvXaeQ0mxX/iQOdKIzGNK6mhN7NHbcRu+LDqycdPTVcaYMNJZl1k9eePfLSzqZT8zc0FKzzwnevX2QLwF4G/XhirOdaNgsz1K1GuTG6zVu18qI98fbKRqkMEBxgT1ieMLx8jPlQrPqaVSODXYYPFdw/rR5Agsd1z274BAGIXAHQh3LbZVcURjD/L4s/5AeUD6FgmTW+kwFgvyYar+Bg2uGUbWfpIJlPNHkQ==; 5:vXOaEHoXfwzs+Drjz7DGORX239VOI8KjZ05PsGQL/ulZdaY1v0UBF7nGxbQVYYPgrQIDx3Emgks6s65VGY27sUYllfvCq2bYV12O8lacqtjfTp2nCFV4XgywGO7RELVD98C0HT469wlc2kZTUTruVABCyz1u8QBFTbqFmLgBIBs=; 7:q9xya04eTIOwfDNha19QbL2i6lG6V4j8A+89yhOOZmT222GlUMM9v0Ieg9xvdkCNjVNn8wMqRIsuVP/4b2CRpK8grah5rMZlO7Mah8LEGf56ieOjIxpqM8SzgjEfPSg3T0NC6kky9yguEwioHJrpz4nYAsfD+brvW7Ty29Z4+WWZLUyEHGg+MD+m+pIf+y2wICDlweAeW6PtwDUdKYUbISHHQFJrFKj94yoxRVnm3Z/UUM+9uMPxSPi0fmkQ60Xl x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 99e5179a-daf7-4f92-1c43-08d5f863aa63 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4156; x-ms-traffictypediagnostic: DB7PR05MB4156: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(3231311)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:DB7PR05MB4156; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4156; x-forefront-prvs: 07521929C1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(396003)(346002)(136003)(366004)(39860400002)(189003)(199004)(7696005)(33656002)(54906003)(229853002)(476003)(97736004)(6246003)(478600001)(9686003)(99286004)(4326008)(53936002)(25786009)(14454004)(11346002)(106356001)(110136005)(486006)(105586002)(7736002)(446003)(66066001)(26005)(74316002)(2906002)(8676002)(2900100001)(5660300001)(68736007)(6116002)(3846002)(81166006)(316002)(6636002)(305945005)(8936002)(102836004)(6506007)(5250100002)(55016002)(256004)(6436002)(76176011)(81156014)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4156; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 02Ld2GTNPFWvw0QQcAxF0aKPoLfDq9s4sZzbsyXB+7Vy7zjYfsr0ApMwTIxuaJck7vdU/9XANPsWW7PTS3QbDhGMyqJYej9AMxtOyM4RHF6FVSDZDBqw+3WincZ76DrkmrTLqN+qvlWSCbt8bVJNRzMYB6c0D3r2plkgE/ZVjbmug3v44tb7xoOCaFkFdTqhiXlHTAG32aydVcPapb/hL1a+QP4rrJDCDxnTcbleu5DmOhC9tbwwzui80xVW8jDG+VOUbWn34ib0kiinAtPxwMjW9lhqwhqh0K5PCl5paXhX5ciDKLLjtYdeFuOAIwfk9XGN6DMAwh4nsMKFHwl5/EEqjnawuaRwOjaNQYzZaE0= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 99e5179a-daf7-4f92-1c43-08d5f863aa63 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Aug 2018 10:35:28.5835 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4156 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix VLAN filtering X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Aug 2018 10:35:31 -0000 Tuesday, July 31, 2018 10:57 AM, Shahaf Shuler: > Subject: [dpdk-dev] [PATCH] net/mlx5: fix VLAN filtering >=20 > The below commit has added a graph based expansion logic for RSS rule to > satisfy Verbs requirements. With this logic, for example, the rule: >=20 > flow create 0 ingress pattern eth / end actions rss queues 0 1 end types = ipv4- > tcp ipv6-tcp end / end >=20 > will be expanded into the rules: >=20 > flow create 0 ingress pattern eth / ipv4 / tcp / end actions rss queues 0= 1 end > types ipv4-tcp ipv6-tcp end / end >=20 > flow create 0 ingress pattern eth / ipv6 / tcp / end actions rss queues 0= 1 end > types ipv4-tcp ipv6-tcp end / end >=20 > flow create 0 ingress pattern eth / end actions queue index 0 / end >=20 > The below commit defined two graphs: > 1. graph for the tunnel case which starts from the ETH item 2. graph for = the > non-tunnel case which starts from the ETH item >=20 > The graphs are ignoring the VLAN case. Hence rules with VLAN item will fa= il to > traverse the graph and it will result in flow rule creation error. >=20 > Adding the VLAN item to the existing graphs will not work as the flow eng= ine > will reject any VLAN item without a specific vid. >=20 > To solve this case two new graphs were added (for the tunnel and non- > tunnel case) which contain the VLAN item and are being used only when the > VLAN item exists in the flow pattern. >=20 > Two cases left un-covered for the inner RSS: > 1. The case were VLAN exists in the pattern as part of the inner headers = 2. > The case were VLAN exists in the pattern both in the outer and the inner > headers >=20 > Solving those cases will require to add two more graphs. > Holding a VLAN for the overlay network is not common, the subnets are > usually defined by the tunnel protocol, for example the VXLAN vni. > Hence adding those two graphs seems like an overkill at this point. > Based on needs one can add those to provide the full support. >=20 > Fixes: 592f05b29a25 ("net/mlx5: add RSS flow action") > Cc: nelio.laranjeiro@6wind.com >=20 > Signed-off-by: Shahaf Shuler Applied to next-net-mlx, thanks.=20