From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01hn0201.outbound.protection.outlook.com [104.47.2.201]) by dpdk.org (Postfix) with ESMTP id 7A22B2C15 for ; Tue, 24 Jul 2018 13:22:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rQn6netFpd1SSt0l7FLHEr2Koo/FPDgZ+glQqcsubmY=; b=SZxWhuXNFWBjQnGP2Fkavbc0eS65YPSOLvkgUHUlkdLVTeTXC7Du6QwaHpKVG6fzkGnEeCaUcsCRyPFG9ER4U3BECCzDPFnXu7xKs9HabMsL+P2lK/hDx/nHgSGp4ijwZZJOR4iPPQ4CF8GPveXjihXOJSnoxktX+86WekfDKmQ= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4875.eurprd05.prod.outlook.com (20.176.235.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.16; Tue, 24 Jul 2018 11:21:52 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::52a:650b:ae10:fc3]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::52a:650b:ae10:fc3%3]) with mapi id 15.20.0952.022; Tue, 24 Jul 2018 11:21:52 +0000 From: Shahaf Shuler To: =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , "dev@dpdk.org" , Yongseok Koh CC: Adrien Mazarguil Thread-Topic: [PATCH] mk: fix application compilation with lmnl and mlx5 Thread-Index: AQHUIzDP+hJIi2bht0eHYPbwhmIV3KSeLpRQ Date: Tue, 24 Jul 2018 11:21:52 +0000 Message-ID: References: <14690e825609ee181e3cd522302d4788ef436f35.1532424524.git.nelio.laranjeiro@6wind.com> In-Reply-To: <14690e825609ee181e3cd522302d4788ef436f35.1532424524.git.nelio.laranjeiro@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4875; 7:S+1z8kXekS0LI3HcVIiaUDhNUyeQTTakyseOwa/SW5Sk3oPokuVUZLvWxRssPVjV8FNdmstb/KS41ta99vs+ayxcWPnZNqwlID3PCFmNT8rM9jnhUgH4nji0LlSOtszcUB7zvJN+ctmFc6uyJ/NW73D4RrlH7NxwLj5vjbuB38wy5cXmYoJvp1vonDKipPMrR53vBNnHwRZrGYQtllghtQ/2TDztnWCVaFQdSedn/bqWAfYpiegIXsPxoorRoBP3 x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 63359e25-a686-4f71-9d11-08d5f157a808 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600073)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4875; x-ms-traffictypediagnostic: DB7PR05MB4875:|DB7PR05MB4875: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(66839620246622); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(3231311)(2232096)(944501410)(52105095)(10201501046)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123560045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:DB7PR05MB4875; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4875; x-forefront-prvs: 0743E8D0A6 x-forefront-antispam-report: SFV:SPM; SFS:(10009020)(376002)(39860400002)(346002)(366004)(396003)(136003)(199004)(189003)(229853002)(2906002)(6636002)(6506007)(55016002)(66066001)(81166006)(9686003)(6246003)(446003)(86362001)(81156014)(102836004)(6116002)(11346002)(6436002)(3846002)(2501003)(305945005)(8936002)(4326008)(68736007)(5660300001)(76176011)(8676002)(5250100002)(97736004)(14444005)(26005)(2900100001)(99286004)(256004)(53936002)(186003)(14454004)(478600001)(7696005)(106356001)(486006)(25786009)(7736002)(74316002)(476003)(110136005)(105586002)(33656002)(316002)(59010400001); DIR:OUT; SFP:1501; SCL:5; SRVR:DB7PR05MB4875; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: hLHy/2w98EIR5vVZw+GHo+hBZw4p8jBDH+uYmkI2OReYzt5X/Ccg6S/WPtTM0R+91eZ3c5Lq0yIHiJvmnTGIp5TVB8jCcpqJcgHwErhBw308+wgU/QwjmS1a3m9/JYlS9yMtfvFy9QiCQgpaFpZjZJ/mrpTupXOZkWw7NlDIAAWrkiCr4nEL3LExGRDORzBYBYXIHKnEKFdr9+g0xkLmpXqANSgZtiTWNFQWA6CZ2i1fYkz1doOUI85tdwK4hm1XBQsJdqciexgTfcZIQO2jrm5rSACvESRRr3Qdb+A+nmREQWHENyYAXNJF/u+nxt98IppEGz0CT0jJWDPibAvAVqeADuXaTGVqs+tkPGEPdEK1CAZ3Qr/aIEP+wQoz6XcFjJGGnHeqPxxTF7I10rHNnrsRWG7PkYDYE1r68w4S2FRkwcr12bErn2Fin2Hx0N8e2JDY5vCjbo0fbXeToFc9jJPjTu4ipX126OnlIdH+W7Ss9cMhrWrBy80jxeBlcoKfSpE2EhctOAJAJZTFrPBGpXhYL1vly+kjXIoPfN3qJYMOD6a9QZ8k5GtSukO8PR7QA0XXSBAEhIX+LGm1qS7RwyhjBE3fbNcanOIaokK0pXcBCTZTfa7QijvuaZu8UtwfapRfmAeBxQ0DDezTc/gQ6e4knOBmdYMAV1EZfIiOJJg+S/9vTkZNgOKzEzN8wFh4D+oYs0rzTFLOVdZoEMocZw== spamdiagnosticoutput: 1:22 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 63359e25-a686-4f71-9d11-08d5f157a808 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jul 2018 11:21:52.5441 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4875 Subject: Re: [dpdk-dev] [PATCH] mk: fix application compilation with lmnl and mlx5 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jul 2018 11:22:00 -0000 Tuesday, July 24, 2018 12:29 PM, Nelio Laranjeiro: > Subject: [PATCH] mk: fix application compilation with lmnl and mlx5 >=20 > When Mellanox MLX5 PMD is compiled with > CONFIG_RTE_LIBRTE_MLX5_DLOPEN_DEPS=3Dy, the external dependency on > libmln is missing. >=20 > Fixes: 4d5cce06231a ("net/mlx5: lay groundwork for switch offloads") > Cc: adrien.mazarguil@6wind.com >=20 > Signed-off-by: Nelio Laranjeiro > --- > mk/rte.app.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/mk/rte.app.mk b/mk/rte.app.mk index f4d28c2da..ff39d37aa > 100644 > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -149,7 +149,7 @@ else > _LDLIBS-$(CONFIG_RTE_LIBRTE_MLX4_PMD) +=3D -lrte_pmd_mlx4 - > libverbs -lmlx4 > endif > ifeq ($(CONFIG_RTE_LIBRTE_MLX5_DLOPEN_DEPS),y) > -_LDLIBS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) +=3D -lrte_pmd_mlx5 -ldl > +_LDLIBS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) +=3D -lrte_pmd_mlx5 -ldl - > lmnl This issue raise some more basic question.=20 The DLOPEN mode was introduced to run in systems which don't have verbs/mlx= 5 libs installed, because those were the only dependencies for the PMD back= then. Now we have the libmnl, which is external dependency just like rdma-core, a= nd following your fix, hard linked also in case of DLOPEN option. It means the whole DPDK binary/lib will be depended on libmnl and this is n= ot what we want with DLOPEN. Can we consider different options: 1. always statically link libmnl=20 2. dlopen libmnl just like we do for verbs/mlx5 > else > _LDLIBS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) +=3D -lrte_pmd_mlx5 - > libverbs -lmlx5 -lmnl > endif > -- > 2.18.0