* [dpdk-dev] [PATCH] net/mlx5: fix flow count action for shared counters
@ 2018-07-29 10:43 Shahaf Shuler
2018-07-31 7:55 ` Shahaf Shuler
0 siblings, 1 reply; 2+ messages in thread
From: Shahaf Shuler @ 2018-07-29 10:43 UTC (permalink / raw)
To: yskoh; +Cc: dev, nelio.laranjeiro
According to commit fb8fd96d4251 ("ethdev: add shared counter to flow
API") the counter id should be taken into account only when the shared
flag is set.
Fixes: 60bd8c9747e8 ("net/mlx5: add count flow action")
Cc: nelio.laranjeiro@6wind.com
Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
---
drivers/net/mlx5/mlx5_flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index b94c442ec4..adda4df656 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -490,7 +490,7 @@ mlx5_flow_counter_new(struct rte_eth_dev *dev, uint32_t shared, uint32_t id)
struct mlx5_flow_counter *cnt;
LIST_FOREACH(cnt, &priv->flow_counters, next) {
- if (cnt->shared != shared)
+ if (!cnt->shared || cnt->shared != shared)
continue;
if (cnt->id != id)
continue;
--
2.12.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: fix flow count action for shared counters
2018-07-29 10:43 [dpdk-dev] [PATCH] net/mlx5: fix flow count action for shared counters Shahaf Shuler
@ 2018-07-31 7:55 ` Shahaf Shuler
0 siblings, 0 replies; 2+ messages in thread
From: Shahaf Shuler @ 2018-07-31 7:55 UTC (permalink / raw)
To: Shahaf Shuler, Yongseok Koh; +Cc: dev, Nélio Laranjeiro
Sunday, July 29, 2018 1:44 PM, Shahaf Shuler:
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix flow count action for shared
> counters
>
> According to commit fb8fd96d4251 ("ethdev: add shared counter to flow
> API") the counter id should be taken into account only when the shared flag
> is set.
>
> Fixes: 60bd8c9747e8 ("net/mlx5: add count flow action")
> Cc: nelio.laranjeiro@6wind.com
>
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
Applied to next-net-mlx, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-31 7:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-29 10:43 [dpdk-dev] [PATCH] net/mlx5: fix flow count action for shared counters Shahaf Shuler
2018-07-31 7:55 ` Shahaf Shuler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).