From: Shahaf Shuler <shahafs@mellanox.com>
To: Ori Kam <orika@mellanox.com>, Yongseok Koh <yskoh@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Xueming(Steven) Li" <xuemingl@mellanox.com>,
Raslan Darawsheh <rasland@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix compilation issue on ARM SOC
Date: Tue, 16 Oct 2018 07:48:40 +0000 [thread overview]
Message-ID: <DB7PR05MB442696E616BF91556E479F20C3FE0@DB7PR05MB4426.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <AM4PR05MB3425348D42197073A5AB0FEEDBFE0@AM4PR05MB3425.eurprd05.prod.outlook.com>
Tuesday, October 16, 2018 9:51 AM, Ori Kam:
> Subject: RE: [dpdk-dev] [PATCH v2] net/mlx5: fix compilation issue on ARM
> SOC
>
>
>
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Shahaf Shuler
> > Sent: Tuesday, October 16, 2018 9:05 AM
> > To: Yongseok Koh <yskoh@mellanox.com>
> > Cc: dev@dpdk.org; Ori Kam <orika@mellanox.com>; Xueming(Steven) Li
> > <xuemingl@mellanox.com>
> > Subject: [dpdk-dev] [PATCH v2] net/mlx5: fix compilation issue on ARM
> > SOC
> >
> > On some ARM environment, the below compilation error will be seen
> >
> > dpdk/drivers/net/mlx5/mlx5_flow_dv.c: In function
> > 'flow_dv_translate_item_nvgre':
> > /tmp/dpdk/drivers/net/mlx5/mlx5_flow_dv.c:785:22: error: pointer
> > targets in initialization differ in signedness [-Werror=pointer-sign]
> > const char *tni_v = nvgre_v->tni;
> >
> > The reason for this error is that nvgre_v->tni is defined as byte
> > array in size of 3B. However the code in the function iterate till the
> > 4B in order to copy/set also the subsequent field after it (flow_id)
> >
> > Fixing by pointing to this struct from a different pointer.
> >
> > Fixes: fc2c498ccb94 ("net/mlx5: add Direct Verbs translate items")
> > Cc: orika@mellanox.com
> > Cc: xuemingl@mellanox.com
> >
> > Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> > ---
> >
> > On v2:
> > - changed pointer names.
> > - added pointer for the tni and flow id mask
> >
> > ---
[...]
> > 2.12.0
>
>
> Acked-by: Ori Kam <orika@mellanox.com>
Applied to next-net-mlx, thanks.
>
> Thanks,
> Ori
prev parent reply other threads:[~2018-10-16 7:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-15 8:23 [dpdk-dev] [PATCH] " Shahaf Shuler
2018-10-15 10:20 ` Ori Kam
2018-10-16 6:05 ` [dpdk-dev] [PATCH v2] " Shahaf Shuler
2018-10-16 6:51 ` Ori Kam
2018-10-16 7:48 ` Shahaf Shuler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR05MB442696E616BF91556E479F20C3FE0@DB7PR05MB4426.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=dev@dpdk.org \
--cc=orika@mellanox.com \
--cc=rasland@mellanox.com \
--cc=xuemingl@mellanox.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).