From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30051.outbound.protection.outlook.com [40.107.3.51]) by dpdk.org (Postfix) with ESMTP id D0CFA4C8C for ; Tue, 16 Oct 2018 09:48:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HARuTqqr/2H1iAfdtOMEeQhYuNRO1IY/0zJlxgwhNnU=; b=Mr9TuBLeszd5yoSItutP8p8u67pxZBxNtrU/t225PRHuz3mGgc2m6oRwvPywaCkpX+7l1ru3wQcsyPomG39+jliWzAt2HIhpCRvk2C5h97TYzRArQrju48H4fKvG+9zw13I4uR7v6N1JCu3IOT5ZoDK8ys7QT7mJf9Rt9IlqJ3E= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB5445.eurprd05.prod.outlook.com (20.177.123.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1228.26; Tue, 16 Oct 2018 07:48:40 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::80e:e6b:baf2:d973]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::80e:e6b:baf2:d973%3]) with mapi id 15.20.1228.020; Tue, 16 Oct 2018 07:48:40 +0000 From: Shahaf Shuler To: Ori Kam , Yongseok Koh CC: "dev@dpdk.org" , "Xueming(Steven) Li" , Raslan Darawsheh Thread-Topic: [dpdk-dev] [PATCH v2] net/mlx5: fix compilation issue on ARM SOC Thread-Index: AQHUZRZBmTNn3aFEdkuR0SLniY7LiqUhbxYAgAAPycA= Date: Tue, 16 Oct 2018 07:48:40 +0000 Message-ID: References: <20181015082352.81673-1-shahafs@mellanox.com> <20181016060517.122247-1-shahafs@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.105] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB5445; 6:IEejK67TZ1Yxtox2siMJsSmHv1uPl0QooCs3ruhOXRnRaNrdYs5JAO4AV0cr3trfmJ2f6dv+yZjrQjTFP3U6BcujbK5dsdwcvC4II4C46QeH15pbTzODB5D7d14pIMtel7agTABIAHUSTn8TWAqUxGDFsjILAMwZrrDWBPB1tr26arn9FVqT5TDV9pS5xcuYp8hIaVeHtvOR2Riiv52V5Y+h6TtvJ/WE064gTMk21oC+9mJF5zAYcZSaapgIhH+3G2+H+478+872MobcSsolWt7tI/SJXS12mcOlR2Aj5wE9LbrYCS8r9YsWnrqKqwfdZwN/5rjGBC81+IG6clg29vWaovxVbtiru7gJaFGN1WG+7j3tbYeRFEulay5vqQ4o3aBuY9b61sblLu8/eeK4iCqBeFquC2RHZcDfc95MChk6+Qi0l5IFg2LkWMwfl8yjiNmAFNq7/KbQr113fAHRNw==; 5:hx53XE35K7tHh55I1cranBlUKqBl6a+BmNxHYd4bYwXNFrYfEGR4bamPtH+14VITcPsOcZB4diPLCpKOMiuWXn7CQJAuPuneu9yksKRae2uxIjFmh30ybidLPVuqT4BsySeF8l8JWlPbR4VLJFyzwDXKOW2ODkJvkGx3AwkDPzY=; 7:yUk1ck0uN4scKBBYAaY47hYa9nHh1YPj+QrV1S952cGAH9KmWcPll1fMngj3tWyJbNBGmusXSmzBOuym22fIu9LFz3ge+mVvFToXqTtfB5YC5AUBNBIJTo4eSkzzsgIwGs9clPRr5prBXMnLbVpxzqHZA+yhg8ZHx0at9z4EKp3XNpWgxFjIItOiHGsznkWOMM+AMnq1wMyBeVeuxQWr9sq8g+dSqbfsYNruUYE06Rg33rbqer1X7LLcgV5IxuAk x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 72f13b38-3628-4a64-40c2-08d6333bca09 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB5445; x-ms-traffictypediagnostic: DB7PR05MB5445: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231355)(944501410)(52105095)(3002001)(10201501046)(93006095)(93001095)(6055026)(149066)(150057)(6041310)(20161123560045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(201708071742011)(7699051); SRVR:DB7PR05MB5445; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB5445; x-forefront-prvs: 0827D7ACB9 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(136003)(396003)(346002)(376002)(39860400002)(13464003)(189003)(199004)(81166006)(5250100002)(4326008)(476003)(25786009)(5660300001)(6506007)(53546011)(6436002)(11346002)(33656002)(446003)(316002)(107886003)(8936002)(8676002)(81156014)(486006)(7696005)(76176011)(68736007)(102836004)(55016002)(2900100001)(26005)(74316002)(478600001)(229853002)(106356001)(2906002)(14454004)(99286004)(305945005)(3846002)(7736002)(6116002)(71200400001)(71190400001)(105586002)(53936002)(14444005)(6636002)(110136005)(9686003)(97736004)(86362001)(186003)(256004)(66066001)(6246003)(54906003); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB5445; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: SNMLoayvH8IV2nKPyjJdFBWdCmumieL/BQTUQd3ogiikTGb6Su4GmMcewYeexHNeL5yoQh24d0XEMbBB5S6x46gVCaJR0psm5i5VSHu3iPXqdI8aytintgz2ZHUdkNAeGBfJZrgsi9NFoRLx3/1cGSwNMJmlGQn0vpYz/9oeLL+AwChDdfGBwRVXiNLJnLBZXqkM3Kivlqouef0NdZTWFXz7QILOVs3fFVpom/zrXM1jtKA5ZtzTSzSKGgPy9kRkuSV45UnKkOHnBgMRuoJ46A14WcqYmwnBL9WtXs0wwBYneEGi+BUZQir0mvapcTH60GMfRMkzmMJQa4EAHlhgi6GG4w1tMEaFEruSGymYyvU= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 72f13b38-3628-4a64-40c2-08d6333bca09 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Oct 2018 07:48:40.3788 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB5445 Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix compilation issue on ARM SOC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2018 07:48:42 -0000 Tuesday, October 16, 2018 9:51 AM, Ori Kam: > Subject: RE: [dpdk-dev] [PATCH v2] net/mlx5: fix compilation issue on ARM > SOC >=20 >=20 >=20 > > -----Original Message----- > > From: dev On Behalf Of Shahaf Shuler > > Sent: Tuesday, October 16, 2018 9:05 AM > > To: Yongseok Koh > > Cc: dev@dpdk.org; Ori Kam ; Xueming(Steven) Li > > > > Subject: [dpdk-dev] [PATCH v2] net/mlx5: fix compilation issue on ARM > > SOC > > > > On some ARM environment, the below compilation error will be seen > > > > dpdk/drivers/net/mlx5/mlx5_flow_dv.c: In function > > 'flow_dv_translate_item_nvgre': > > /tmp/dpdk/drivers/net/mlx5/mlx5_flow_dv.c:785:22: error: pointer > > targets in initialization differ in signedness [-Werror=3Dpointer-sign] > > const char *tni_v =3D nvgre_v->tni; > > > > The reason for this error is that nvgre_v->tni is defined as byte > > array in size of 3B. However the code in the function iterate till the > > 4B in order to copy/set also the subsequent field after it (flow_id) > > > > Fixing by pointing to this struct from a different pointer. > > > > Fixes: fc2c498ccb94 ("net/mlx5: add Direct Verbs translate items") > > Cc: orika@mellanox.com > > Cc: xuemingl@mellanox.com > > > > Signed-off-by: Shahaf Shuler > > --- > > > > On v2: > > - changed pointer names. > > - added pointer for the tni and flow id mask > > > > --- [...] > > 2.12.0 >=20 >=20 > Acked-by: Ori Kam Applied to next-net-mlx, thanks.=20 >=20 > Thanks, > Ori