From: Shahaf Shuler <shahafs@mellanox.com>
To: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Yongseok Koh <yskoh@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/2] net/mlx5: enforce RSS key length limitation
Date: Tue, 27 Mar 2018 05:55:32 +0000 [thread overview]
Message-ID: <DB7PR05MB442697582BD05003E8931123C3AC0@DB7PR05MB4426.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20180326111755.wmr2gzvvrujc3jco@laranjeiro-vm.dev.6wind.com>
Monday, March 26, 2018 2:18 PM, Nélio Laranjeiro:
> On Mon, Mar 26, 2018 at 01:12:18PM +0300, Shahaf Shuler wrote:
> > @@ -48,6 +48,13 @@ mlx5_rss_hash_update(struct rte_eth_dev *dev,
> > return -rte_errno;
> > }
> > if (rss_conf->rss_key && rss_conf->rss_key_len) {
> > + if (rss_conf->rss_key_len != rss_hash_default_key_len) {
> > + DRV_LOG(ERR,
> > + "port %u RSS key len must be %zu Bytes
> long",
> > + dev->data->port_id,
> rss_hash_default_key_len);
> > + rte_errno = ENOTSUP;
>
> Should be EINVAL when values are incorrect.
OK.
Considering it is the only comment in this series, are you OK with me changing it while applying to next-net-mlx?
>
> > + return -rte_errno;
> > + }
> > priv->rss_conf.rss_key = rte_realloc(priv->rss_conf.rss_key,
> > rss_conf->rss_key_len, 0);
> > if (!priv->rss_conf.rss_key) {
> > --
> > 2.12.0
>
> Thanks,
>
> --
> Nélio Laranjeiro
> 6WIND
next prev parent reply other threads:[~2018-03-27 5:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 10:12 Shahaf Shuler
2018-03-26 10:12 ` [dpdk-dev] [PATCH 2/2] net/mlx5: fix RSS key len query Shahaf Shuler
2018-03-26 11:33 ` Nélio Laranjeiro
2018-03-26 11:17 ` [dpdk-dev] [PATCH 1/2] net/mlx5: enforce RSS key length limitation Nélio Laranjeiro
2018-03-27 5:55 ` Shahaf Shuler [this message]
2018-03-27 7:15 ` Nélio Laranjeiro
2018-03-28 6:08 ` Shahaf Shuler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR05MB442697582BD05003E8931123C3AC0@DB7PR05MB4426.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
--cc=stable@dpdk.org \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).