From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0085.outbound.protection.outlook.com [104.47.1.85]) by dpdk.org (Postfix) with ESMTP id 709FFA49A; Tue, 27 Mar 2018 07:55:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=aKjoT9VSI1fB3V9DP7b7UJ6cD6s93PsWgPJ/oFbPh4o=; b=NqlqAgvJShfbGRuzRTpDTx2Vpm4O/m7SCgn8f5YQrECmGBWFEL0HXb3oHNt9Guc5KkTazJk6+VtBZSHV4rCg2FgqaI4o8KUq4j55iHArBgBya9t9wgbFFtPxwrZbcD0k9uaGtDZCuLXISeGwKWzWTSm4E0lRkMLixXVJ8v+vwEU= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4105.eurprd05.prod.outlook.com (52.134.107.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.609.10; Tue, 27 Mar 2018 05:55:32 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::808d:386e:26f3:859f]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::808d:386e:26f3:859f%13]) with mapi id 15.20.0609.012; Tue, 27 Mar 2018 05:55:32 +0000 From: Shahaf Shuler To: =?iso-8859-1?Q?N=E9lio_Laranjeiro?= CC: Adrien Mazarguil , Yongseok Koh , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH 1/2] net/mlx5: enforce RSS key length limitation Thread-Index: AQHTxPRLyHG0lP76JUqW3pC/SsfrEaPjlkCw Date: Tue, 27 Mar 2018 05:55:32 +0000 Message-ID: References: <20180326101219.91229-1-shahafs@mellanox.com> <20180326111755.wmr2gzvvrujc3jco@laranjeiro-vm.dev.6wind.com> In-Reply-To: <20180326111755.wmr2gzvvrujc3jco@laranjeiro-vm.dev.6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4105; 7:GafaMiC47OUrKl1EmRBszrCE2cpDdOG2/MsCNRIV1Iy+r4YBSVrg0W5dGFoDd5RiqzgmCIoyB7LQuGtPd4SSijQ++46iDrgavF60Br87UZGbtV4MqxZnCJhNd3qe47rLgLor0gDqNCM7AfmGSuv8V9OoTRFqtjtyfQgPQuOIL+o2KFO0EaP9wdUdQU3vFlx4VlJSPKk+xEOd4GW4gMAKxN6KOuQkiJfJuutLSJvYlUs2AZrh5KyjmZ/UTQVXCAEU x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 93cab3ae-567a-4dc2-cf72-08d593a75a59 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4105; x-ms-traffictypediagnostic: DB7PR05MB4105: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231221)(944501327)(52105095)(6055026)(6041310)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(6072148)(201708071742011); SRVR:DB7PR05MB4105; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4105; x-forefront-prvs: 0624A2429E x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(39380400002)(346002)(396003)(376002)(366004)(189003)(199004)(316002)(105586002)(6506007)(186003)(25786009)(81166006)(81156014)(3846002)(305945005)(26005)(33656002)(6116002)(5660300001)(2906002)(6246003)(8676002)(7736002)(3280700002)(54906003)(74316002)(53936002)(486005)(486005)(478600001)(7696005)(2900100001)(3660700001)(76176011)(59450400001)(99286004)(102836004)(5250100002)(66066001)(97736004)(86362001)(446003)(14454004)(8936002)(229853002)(11346002)(68736007)(4326008)(55016002)(9686003)(106356001)(476003)(6436002)(6916009); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4105; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: W9n5QYRplOrNO+FGF4aNctUGdS18Njc0zvhRku88MdMPblEapqWmZYIDkwWO3DqsLvOeUymwdRv/4Mu1rX+FgqEs7dE/3dUNP2R/oAyKcmz6Hm/nvfgRTknohg5wTRKx8TWvX7nEf6weYdQ1cuD0h6dh+UtRfu0piJmut2ey4Wqgi9++cD0fqW2QDa2r12XdoRM9AP8cfABcDZwxKU2fgK+Md0v6vIb2sR1edXKl/RSMh2D57J87Vv6ww+Oq5lm4i6Fmwq7/eIiyylJ+NXmjoPrWq1Djf+F+X78yd59pvrlIL5Ee0xk5rgc9TVsH7snm+g7pfSJf62yHG9wV7T5xOg== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 93cab3ae-567a-4dc2-cf72-08d593a75a59 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Mar 2018 05:55:32.6356 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4105 Subject: Re: [dpdk-dev] [PATCH 1/2] net/mlx5: enforce RSS key length limitation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Mar 2018 05:55:40 -0000 Monday, March 26, 2018 2:18 PM, N=E9lio Laranjeiro: > On Mon, Mar 26, 2018 at 01:12:18PM +0300, Shahaf Shuler wrote: > > @@ -48,6 +48,13 @@ mlx5_rss_hash_update(struct rte_eth_dev *dev, > > return -rte_errno; > > } > > if (rss_conf->rss_key && rss_conf->rss_key_len) { > > + if (rss_conf->rss_key_len !=3D rss_hash_default_key_len) { > > + DRV_LOG(ERR, > > + "port %u RSS key len must be %zu Bytes > long", > > + dev->data->port_id, > rss_hash_default_key_len); > > + rte_errno =3D ENOTSUP; >=20 > Should be EINVAL when values are incorrect. OK. Considering it is the only comment in this series, are you OK with me chang= ing it while applying to next-net-mlx?=20 >=20 > > + return -rte_errno; > > + } > > priv->rss_conf.rss_key =3D rte_realloc(priv->rss_conf.rss_key, > > rss_conf->rss_key_len, 0); > > if (!priv->rss_conf.rss_key) { > > -- > > 2.12.0 >=20 > Thanks, >=20 > -- > N=E9lio Laranjeiro > 6WIND