From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00084.outbound.protection.outlook.com [40.107.0.84]) by dpdk.org (Postfix) with ESMTP id 8B37D5592 for ; Thu, 22 Mar 2018 08:36:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=4XTDn64Uj2exszJuFyYUiIAmpvFI4cxxb0drpYlZcpY=; b=v6h1tGPJQPMuCkWcbmPsie5ZpGWBofOsXmbcj63Gsz8KsPGKlhw1UrNI4adjYlZZ1d3Yac6vG2HlxMhCEk/oK8yqZB3lydbTzA9ra+DnBSY2dW5ngzYRJZZuSOcCQxEEjyxRr8/n6K3ge98fsgsUQiJsNj1s1vTvimyocuca7OE= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4394.eurprd05.prod.outlook.com (52.134.108.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.588.14; Thu, 22 Mar 2018 07:36:08 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::3473:b2b5:68f:fe6e]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::3473:b2b5:68f:fe6e%13]) with mapi id 15.20.0588.016; Thu, 22 Mar 2018 07:36:08 +0000 From: Shahaf Shuler To: =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , "Adrien Mazarguil" , Yongseok Koh CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 2/3] net/mlx5: use Netlink to enable promisc / all multicast mode Thread-Index: AQHTwRpZngmDDbMa40G4HlOvY0B0x6Pb3msQ Date: Thu, 22 Mar 2018 07:36:08 +0000 Message-ID: References: <73d9075c4ac78166d5ae88bec01542d9a5af9463.1521639463.git.nelio.laranjeiro@6wind.com> In-Reply-To: <73d9075c4ac78166d5ae88bec01542d9a5af9463.1521639463.git.nelio.laranjeiro@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4394; 6:wUIcSxrhNVF+n3wZuP67MiLWipiBpV8QtXauRiu/CUWjLPehpor8xMiqUE+/SLTq9JNF8jo6FMEl3zgJEH9vgEHShjM0iMd98ova7bkt/fWQBPHfv7Hbb5xazB3P6CbCpYYhdR8fg32swRw9bT70OF8LCNVBn8ugK+8jLk3x2lOe4J8PPd+Zm9gVZ0PTZyP6IIASr4+0yrTRr7cPGDBp7FMKPC3xJUn0e7dTxAKle/QD4ZH1aweT7lQAO6+qSXVn7MMvt4wusz8TR0TCYzuHRVDK7Y3mc1rijh3tRpqWrbyzb2BE/0F7Wplfzgg3EGTEUhdTkCReajzkPOESaf8KTjSf9DhXvizTvVyVm4ABokKDR/Ldthfeiglf157CIDUA; 5:3AkOs+pgad1ilsoPtzKG1crBSgeJK4+VFDUpQCcSEY52W7/uNRZjtA/j9XeQ+phVyj7qC9dfwK28geoJ0oL9Fs3dUX0Hcj1DLXO/jmgzjDm/WY2hzkgk08sBeoPf41jNiyrJcKSGJxy4lIjqsG/gAauPhuQRwf+9WkwF6zKv1HM=; 24:/NkeA9bWH6qUhuSg0YNJCfpQOS8r9Wn7Ct9FtjI6n/r8Dk+rr3OxQZ30jfMx3+4LJh2MyDuOTiQD9wP4NWo+9IPClC/Qep7sN+2I06T5Wyg=; 7:/ts2oq7ZcCcpumPINPMzV//kQbIwTzIhV1+x3xkMpxhcLG8rtVvD1DJJDKIweEb54aSqjpjs8rL+DTCppoCASWG7MV5fRjg2Gy8hJGOjTd/LqKzwhTjdHrb2LhgsT57DIjuwuQ/4M2l0pe08cpdvh4u3JmcwlfhOzFtmnKSJq6HK4wGG1ZtY3ERX/7iIvtf6++Uzg6I7M/jV6jv6Uz7kY73Ni6PEsPdj6xmuFg2ZqOS6HhTCEtaworEqQ1NOoJKM x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: c59b108d-fd1d-4b74-69c8-08d58fc793df x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4394; x-ms-traffictypediagnostic: DB7PR05MB4394: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(3231221)(944501327)(52105095)(93006095)(93001095)(6055026)(6041310)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123560045)(6072148)(201708071742011); SRVR:DB7PR05MB4394; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4394; x-forefront-prvs: 0619D53754 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39380400002)(376002)(396003)(39860400002)(346002)(366004)(199004)(189003)(6636002)(6506007)(7696005)(6116002)(99286004)(3846002)(59450400001)(102836004)(25786009)(33656002)(316002)(106356001)(105586002)(229853002)(5250100002)(4326008)(2900100001)(2950100002)(446003)(3660700001)(8936002)(81166006)(81156014)(110136005)(3280700002)(2906002)(478600001)(14454004)(53936002)(66066001)(5660300001)(6436002)(74316002)(97736004)(305945005)(7736002)(55016002)(68736007)(9686003)(186003)(86362001)(76176011)(26005)(6246003)(575784001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4394; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: Geup0Qpa6Ldi3xZSt073uUi30tIDDpA+fSIQBlis1gTCMMaZNVfFOdsNaNUbxYp0wgcMHmOvWoQHpcxbIyDO3D90xSGlhhvRkh34kqVM8scaWN2rpKItxR8pbb5HTFEXQvlF9NfOpAEJPdau2BFlM4cwR8+s4mBsGHwAKGfwlPIighbAZelb+yRd3P/X/qe23Lr5kqzOV7Mm89pz8CcCJ4gheMpUJAYVmhG1Fs8nQ4GytL6zeVxUccR406l6UtO1CZJK9Llj8rRjB04Dy/WcFyRA88ZkkhFAQjmGZ7KzzrtGDEpyBhHAGnLW2tN3wd/iev0LYiJepXdlvg8Iuq+bNg== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: c59b108d-fd1d-4b74-69c8-08d58fc793df X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Mar 2018 07:36:08.3855 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4394 Subject: Re: [dpdk-dev] [PATCH v3 2/3] net/mlx5: use Netlink to enable promisc / all multicast mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Mar 2018 07:36:09 -0000 Wednesday, March 21, 2018 3:40 PM, Nelio Laranjeiro: =20 > VF devices are not able to receive promisc or allmulti traffic unless it = fully > requests it though Netlink. This will cause the request to be processed = by > the PF which will handle the request and enable it. >=20 > This requires the VF to be trusted by the PF. >=20 > Signed-off-by: Nelio Laranjeiro > Acked-by: Adrien Mazarguil > --- > drivers/net/mlx5/mlx5_nl.c | 94 > ++++++++++++++++++++++++++++++++++++++++++ > drivers/net/mlx5/mlx5_rxmode.c | 8 ++++ > 2 files changed, 102 insertions(+) [...] > diff --git a/drivers/net/mlx5/mlx5_rxmode.c > b/drivers/net/mlx5/mlx5_rxmode.c index e43a4b030..c1c0f21c7 100644 > --- a/drivers/net/mlx5/mlx5_rxmode.c > +++ b/drivers/net/mlx5/mlx5_rxmode.c > @@ -35,6 +35,8 @@ mlx5_promiscuous_enable(struct rte_eth_dev *dev) > int ret; >=20 > dev->data->promiscuous =3D 1; > + if (((struct priv *)dev->data->dev_private)->config.vf) > + mlx5_nl_promisc(dev, 1); > ret =3D mlx5_traffic_restart(dev); > if (ret) > DRV_LOG(ERR, "port %u cannot enable promiscuous mode: > %s", @@ -53,6 +55,8 @@ mlx5_promiscuous_disable(struct rte_eth_dev > *dev) > int ret; >=20 > dev->data->promiscuous =3D 0; > + if (((struct priv *)dev->data->dev_private)->config.vf) > + mlx5_nl_promisc(dev, 0); Same comment: What if the DPDK process is terminated ungracefully?