From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40044.outbound.protection.outlook.com [40.107.4.44]) by dpdk.org (Postfix) with ESMTP id 5B238201 for ; Tue, 13 Nov 2018 14:21:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ev4WCWwemRBQ/RA6+7iCku8WZ9BGEEBHokkT5iK+YZo=; b=Kj2ylhSTRhAaTjxUNp/PrrPz2s6jCv/rO+3ns/fFnQ/JjAa++PD5BXB2aqhmh9+7BNvf3IKj2FevourmSKuHs/kSeN/cRlEO/bqqFFhS/gAQ4WtsQTSVWLQ+TR6hN1po3IF1gnO7dEhodyU0TogLgF6IZuqirdpVLnavI+7+1lA= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB5755.eurprd05.prod.outlook.com (20.178.105.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.26; Tue, 13 Nov 2018 13:21:23 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::bc22:c2f5:208d:826f]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::bc22:c2f5:208d:826f%2]) with mapi id 15.20.1294.044; Tue, 13 Nov 2018 13:21:23 +0000 From: Shahaf Shuler To: Slava Ovsiienko , Yongseok Koh CC: "dev@dpdk.org" Thread-Topic: [PATCH 0/4] net/mlx5: prepare to add E-switch rule flags check Thread-Index: AQHUesKGEDdaMNssikqvGRvxoRZur6VNsbUA Date: Tue, 13 Nov 2018 13:21:23 +0000 Message-ID: References: <1541225876-8817-2-git-send-email-viacheslavo@mellanox.com> <1542052877-41512-1-git-send-email-viacheslavo@mellanox.com> In-Reply-To: <1542052877-41512-1-git-send-email-viacheslavo@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.105] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB5755; 6:REEhO/TxmBYBvK/dqK8ss0xepFy+1MZRWLEdcfGD6nZX5aYaPGQ5H/yuRKMrU76br9fH1qq9xPjClp62Y4SR8eU6zcwN5Dc4Nkxl7QFg3Lqnj+Fv19XEFtiI7I+pLsNc94XM1pVqsASJhV1rtogue0Jy8ucuxHoHakGpUgKH1d9EcD3imWTvNMJMM6CQGZA1L9pf2RrLtZGCjwM3809uauAnkhjL11JMP3rgm0LyuZjE4NwxFWV8Te4RqkRsB7L+YGe6Zmip8vYRF+ewrYO+8aI6SG6vLQ+FSdwD6SRf6nMl4NnCrEXFYeLGU1SN9v45ZcSueNFc9NZRxvEfSPpGOHx2TVYzvd8Un6EEdrQew/1+wzK1zw/6BWlh142HvJFgOelg4+5bsI3XF3YacS3HF3rxNypBEipzsn5j9fthI36IDu5cKIVe95w1FsL0BFdsnuFlMc6OKVVc8uOPl9TLaQ==; 5:0BGfKI1mEfhGjEYa+rMAcCRJou4ic0mdrSQA2Fr4okIFh2+TpKyW/+G178gHY39BvAMxuZO9OZVWLFgVKCPRRRYfATg0utyTv020SRwOZ1+0D80sZGSnHKfnZ7ub0TWvcE8IQ57d8ZfxDrYvHjdkCjYncSxtvOFULx5ZJ6F2sJk=; 7:BuS/OIyvn73/Eqda4fdcxl2HG/T3YjncQ8IDDhvtk2oId+tzj1qz5K0GQgSUnc0CsGA2oG4Eh7V1tYzqIyNhKDsT6LfBOhJBqQqhkeeKJx1wQ7O7pou4J1d4xSf4RyWyW0XdTxFCtgYGE0OxFgfiug== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 72eb71e9-e638-441c-8e40-08d6496ae87e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390060)(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB5755; x-ms-traffictypediagnostic: DB7PR05MB5755: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231382)(944501410)(52105112)(3002001)(10201501046)(6055026)(148016)(149066)(150057)(6041310)(20161123562045)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(201708071742011)(7699051)(76991095); SRVR:DB7PR05MB5755; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB5755; x-forefront-prvs: 085551F5A8 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(39860400002)(376002)(366004)(346002)(396003)(189003)(199004)(478600001)(14444005)(256004)(6436002)(305945005)(110136005)(7736002)(486006)(74316002)(316002)(14454004)(33656002)(8676002)(5660300001)(97736004)(81166006)(81156014)(25786009)(8936002)(68736007)(6636002)(7696005)(86362001)(66066001)(4326008)(106356001)(105586002)(3846002)(6116002)(2900100001)(71200400001)(71190400001)(6246003)(99286004)(26005)(53936002)(446003)(476003)(11346002)(9686003)(55016002)(186003)(6506007)(229853002)(76176011)(2906002)(102836004); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB5755; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: wMbNBA5pWXswN89aNWzxMQK8QFbgHkPUa8qAgUPPjm7VDXiKwgP+YIC93MdPlXg4w90S7bJ4FyHf4dl6XrS8edY5tw0R4HLhkVPQuKh2V3XoDZFTI4CZKYYdYk/SWDwaEcach0FU4oc6s/rMqniRIohRNvowaZEhSBVYtdGQy3Z5SJmqCLkdOIW2qr98iXr1EC10nX2Kat30xGU0aETuna9SV2fwTjBOUBFcVxXrkpfgqasFFf5bTz9QuHY/4A4Zo29eIO5wBw+jDmdyZ5F62BgnNOg9bwbCskPoE4rUuM1wv+TORgV4avy/jN48RV5tCHIsqjoGgbBbIRj9Hbe6RxR+pIWTmukuAHalqyFuvGw= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 72eb71e9-e638-441c-8e40-08d6496ae87e X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2018 13:21:23.4066 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB5755 Subject: Re: [dpdk-dev] [PATCH 0/4] net/mlx5: prepare to add E-switch rule flags check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Nov 2018 13:21:24 -0000 Monday, November 12, 2018 10:02 PM, Slava Ovsiienko: > Subject: [PATCH 0/4] net/mlx5: prepare to add E-switch rule flags check >=20 > The tc flower filter rules are used to control E-switch from the applicat= ion > side. In order to gain garanteed rule hardware offload the skip_sw flag > should be specified while applying the rule. Some tc rules is rejected by > kernel if skip_sw flag is set by design. Currently this regards VXLAN tun= neling > rules only, which are applied to special VXLAN virtual devices. >=20 > Albeit these rules should be applied with no skip_sw flag set the kernel = tries > to perform hardware offload. If kernel succeeded the in_hw flag is set in= rule > properties and application may check this flag to get know whether the > applied rule is actually hardware offloaded. >=20 > Signed-off-by: Viacheslav Ovsiienko >=20 Hi Slava, In general looks good. Please see few comments. In addition, please make the signed-of name and the author name match for t= he next version.=20 > Viacheslav Ovsiienko (4): > net/mlx5: prepare Netlink communication routine to fix > net/mlx5: fix Netlink communication routine > net/mlx5: prepare to add E-switch rule flags check > net/mlx5: add E-switch rule hardware offload flag check >=20 > drivers/net/mlx5/mlx5_flow.h | 1 + > drivers/net/mlx5/mlx5_flow_tcf.c | 316 > +++++++++++++++++++++++++++++---------- > 2 files changed, 236 insertions(+), 81 deletions(-) >=20 > -- > 1.8.3.1