From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50046.outbound.protection.outlook.com [40.107.5.46]) by dpdk.org (Postfix) with ESMTP id CF8AB58FA; Thu, 28 Jun 2018 08:39:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nzoMuE6aCSqw/JmpP/zebRe60V6fAjsRCt8ERimlNfE=; b=NZBzwX70fabtRbf1ZxKcnnNq0zc1AWe5MnX8Mwb372nswbCZx+4v+05/CZWFjT8Jab3rVzUlWuDMU/28g1t/5G+YwQLTQ5e3dOcpbi9k4vOHJf/EV0kVKMHl0GF+F0B+Qv/eUdktixfZUXI1ccDCe3toxCt9U1DuZqCuX8ThYIk= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4427.eurprd05.prod.outlook.com (52.134.109.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.884.23; Thu, 28 Jun 2018 06:39:15 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::4c94:2db9:b8c5:cc6b]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::4c94:2db9:b8c5:cc6b%5]) with mapi id 15.20.0884.025; Thu, 28 Jun 2018 06:39:15 +0000 From: Shahaf Shuler To: =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , Adrien Mazarguil CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix invalid error check Thread-Index: AQHUDfgwu2qDlbCw3kCU6yPX2WfybaRz/4MAgAE53uA= Date: Thu, 28 Jun 2018 06:39:15 +0000 Message-ID: References: <20180627091909.22689-1-adrien.mazarguil@6wind.com> <20180627115522.dvxqrbjugasfsmbn@laranjeiro-vm.dev.6wind.com> In-Reply-To: <20180627115522.dvxqrbjugasfsmbn@laranjeiro-vm.dev.6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.105] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4427; 7:kIbAufLWGQ31vuxAI8jlAWxHhigaO1EstsMcIk1oDQcFXUrDKe+Ho+fO/KjEnECz9AUFYD6TZJl19tEpxrOoeS46k3/ZyjrS80yJS4vTqT/7c1L+6o5C7RAVkKDijDK7qztj8WHWaTqmx8NElIpnl9meDdhl9THX5mdRa6FRyaRZ3J+bV4CCn+roGG21WWGPgVYDLLJgEOyfaqDciQibgEqn2AOejAIrftIc7Or6zJEwHEmYFKVze0p7cNZ6e5ND x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 33b5bc31-bb3d-4a3c-0030-08d5dcc1de0a x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600026)(711020)(48565401081)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4427; x-ms-traffictypediagnostic: DB7PR05MB4427: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123560045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:DB7PR05MB4427; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4427; x-forefront-prvs: 0717E25089 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(366004)(376002)(136003)(396003)(346002)(189003)(199004)(256004)(33656002)(9686003)(7696005)(2900100001)(54906003)(5250100002)(6246003)(6436002)(55016002)(81166006)(102836004)(316002)(99286004)(68736007)(86362001)(4326008)(8676002)(2906002)(53936002)(26005)(110136005)(81156014)(105586002)(66066001)(5660300001)(106356001)(25786009)(8936002)(76176011)(186003)(7736002)(476003)(11346002)(446003)(478600001)(305945005)(74316002)(14454004)(97736004)(3846002)(6506007)(486006)(6116002)(229853002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4427; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: jrJvEkZyKboDfWvYb8ijU0bl2ZHE9bdQGJUab3ZImrhPWMgebuoJCBt/0+FfVdyGo/E7qTe4TpMe9BzVRo8Z4FryXVCiygp8WOd78EEIuF2rfx7ZYIONnNzfq7Hef8slbymeu/hvybpETOtqMfEwCqGMuREBphm1WBYknrVLDQghgaTkpy1lpSWfiPBtDZRPJQiHpVHmokfu6c3Jq0cB56859zgJwGQmN0kBsWF8NVKQXIrLYXNDYiu36N52NumRWQLjN2s6XNt5mkg5I6WK6X1rXChy2jJYEkPI2wnN6qvd3uAK1fyeBxvWpUzJhc2XdcvO0pVRD4fo+WmWFxG+LdQbw+n7G4bUUKIgxEyXunU= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 33b5bc31-bb3d-4a3c-0030-08d5dcc1de0a X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2018 06:39:15.3558 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4427 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix invalid error check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jun 2018 06:39:17 -0000 Wednesday, June 27, 2018 2:55 PM, N=E9lio Laranjeiro: > Subject: Re: [PATCH] net/mlx5: fix invalid error check >=20 > On Wed, Jun 27, 2018 at 11:20:52AM +0200, Adrien Mazarguil wrote: > > Since its return type is unsigned, if_nametoindex() returns 0 in case > > of error, never -1. > > > > Fixes: ccdcba53a3f4 ("net/mlx5: use Netlink to add/remove MAC > > addresses") > > Cc: Nelio Laranjeiro > > Cc: stable@dpdk.org > > > > Signed-off-by: Adrien Mazarguil > Acked-by: Nelio Laranjeiro Applied to next-net-mlx, thanks.=20 >=20 > > --- > > drivers/net/mlx5/mlx5_ethdev.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/mlx5/mlx5_ethdev.c > > b/drivers/net/mlx5/mlx5_ethdev.c index 90488af33..ebe5cb6e3 100644 > > --- a/drivers/net/mlx5/mlx5_ethdev.c > > +++ b/drivers/net/mlx5/mlx5_ethdev.c > > @@ -192,13 +192,13 @@ int > > mlx5_ifindex(const struct rte_eth_dev *dev) { > > char ifname[IF_NAMESIZE]; > > - int ret; > > + unsigned int ret; > > > > ret =3D mlx5_get_ifname(dev, &ifname); > > if (ret) > > return ret; > > ret =3D if_nametoindex(ifname); > > - if (ret =3D=3D -1) { > > + if (ret =3D=3D 0) { > > rte_errno =3D errno; > > return -rte_errno; > > } > > -- > > 2.11.0 >=20 > Thanks, >=20 > -- > N=E9lio Laranjeiro > 6WIND