From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0083.outbound.protection.outlook.com [104.47.1.83]) by dpdk.org (Postfix) with ESMTP id 10DC91BB41 for ; Mon, 14 May 2018 09:51:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=iqPe3wm7k4FEE9aHXIm6HAR6uo4wa88TogSJ4/Utc2o=; b=No+rzfYKZrbAyXu1alcPJVHcC/0a2L7NuCoz8bTgak0ecygZDBHekuNOt48FtlGpeA1ad5PeSSGaQ4Q3ih71VAadztoSGl6qc675c7/zb5t/7g19wjXlobx6eP3cUH64QuS2iNr4hwdj4DxnAEFCu3TZhNyts128pASNlsW8abs= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4235.eurprd05.prod.outlook.com (52.134.108.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.755.16; Mon, 14 May 2018 07:51:28 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::f116:5be4:ba29:fed8]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::f116:5be4:ba29:fed8%13]) with mapi id 15.20.0755.018; Mon, 14 May 2018 07:51:28 +0000 From: Shahaf Shuler To: Andrew Rybchenko , "dev@dpdk.org" CC: Ferruh Yigit , Thomas Monjalon , Wei Dai Thread-Topic: [PATCH v2 0/3] ethdev: fail if requested offload is not supported Thread-Index: AQHT61ZUQErtOJvwsEOGNPcOToxsBqQu2YOg Date: Mon, 14 May 2018 07:51:28 +0000 Message-ID: References: <1526055955-14027-1-git-send-email-arybchenko@solarflare.com> <1526283378-30507-1-git-send-email-arybchenko@solarflare.com> In-Reply-To: <1526283378-30507-1-git-send-email-arybchenko@solarflare.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4235; 7:xKJrahStnMJCb8U28AjFQoGz0vPYW7ZFXteZ2KUDtICHS4HLboRtBkuziQOS+DOWAFShEoztXg/4WlgsZKs1tpRo9kLD5uCyTu7cdS1QHcpfkRI+qmWENRKwFeSZlp7uGeb44OLjG+/mYLu+lBUNwXhyB/qi7fECqdOb94tS5IZ4bX0u1FGUtlrqL+bd+a8shEpAsb4vu8urQ+iLOK7ugV1A9XJDfPDKAnCfGpailbzdCOPvBDUskig3UPx/bP8J x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4235; x-ms-traffictypediagnostic: DB7PR05MB4235: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(278428928389397)(189930954265078)(45079756050767); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231254)(944501410)(52105095)(93006095)(93001095)(3002001)(10201501046)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123558120)(20161123560045)(6072148)(201708071742011); SRVR:DB7PR05MB4235; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4235; x-forefront-prvs: 067270ECAF x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39380400002)(39860400002)(396003)(376002)(346002)(366004)(189003)(199004)(6506007)(76176011)(59450400001)(3846002)(2906002)(99286004)(66066001)(33656002)(7736002)(105586002)(6116002)(3660700001)(6436002)(7696005)(316002)(54906003)(110136005)(305945005)(229853002)(3280700002)(2900100001)(106356001)(97736004)(5660300001)(486006)(86362001)(6306002)(9686003)(81156014)(53936002)(8676002)(8936002)(14454004)(4326008)(446003)(26005)(11346002)(25786009)(81166006)(476003)(45080400002)(966005)(102836004)(6246003)(55016002)(478600001)(74316002)(186003)(5250100002)(68736007)(2501003); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4235; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: qgkpinttS9cLHTMhKviI/QJNNiV1p06kBso3ELR0j4XE6/SJqvHugAW93Z2jw0LgDC3GD8hXDpZgpTPezmhnain93AUY7kdmMLmkKuq9+/7m/zpG8WT8nXvnFgMoFKkEEEFctXHZUpTcMJ+i0CBAyrQKs77wzIrZy3Be7pG6lClLiLB1l36tNWFQuZ8gHegN spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 8f0a3f13-9acc-4711-8378-08d5b96f7ffb X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f0a3f13-9acc-4711-8378-08d5b96f7ffb X-MS-Exchange-CrossTenant-originalarrivaltime: 14 May 2018 07:51:28.1397 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4235 Subject: Re: [dpdk-dev] [PATCH v2 0/3] ethdev: fail if requested offload is not supported X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 May 2018 07:51:30 -0000 Monday, May 14, 2018 10:36 AM, Andrew Rybchenko: > Subject: [PATCH v2 0/3] ethdev: fail if requested offload is not supporte= d >=20 > The series has fixes for problems discussed in [1]. >=20 > Basically it does not allow unsupported offloads to pass. >=20 > If fixes regressions for PMDs which carefully check offloads before, but = these > checks are removed now in favor of checks in ethdev. >=20 > It may break applications which request some offload which is not support= ed > by underlying PMD, but does not actually used. >=20 > Depending on discussion results it should be either dropped or applied. >=20 > [1] > https://emea01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fdpd > k.org%2Fml%2Farchives%2Fdev%2F2018- > May%2F101261.html&data=3D02%7C01%7Cshahafs%40mellanox.com%7C9a572 > e9d86b04c99854c08d5b96d75b5%7Ca652971c7d2e4d9ba6a4d149256f461b%7 > C0%7C0%7C636618802134607945&sdata=3DfQKCr%2FrFvakWVIFomy8iSD%2Bc > VtSie8mvgx63Qqgq690%3D&reserved=3D0 >=20 > v1 -> v2: > - use IGNORE flag to separate old and new offload API cases on > Tx queue setup and avoid expected errors if old API is used > as suggested by Shahaf > - remove convertion of rxmode bits on Rx queue setup since exactly > these bits are removed >=20 > Andrew Rybchenko (3): > ethdev: fail configure if requested offload is not supported > ethdev: fail if Tx queue offload is not supported > ethdev: fail if Rx queue offload is not supported >=20 > lib/librte_ethdev/rte_ethdev.c | 62 +++++++++++++++++++--------------- > 1 file changed, 35 insertions(+), 27 deletions(-) For the series - Acked-by: Shahaf Shuler >=20 > -- > 2.17.0