[dpdk-dev] [PATCH v3] mlx5: use pkg-config to handle SUSE libmnl

[dpdk-dev] [PATCH v3] mlx5: use pkg-config to handle SUSE libmnl

[Stephen Hemminger]

SUSE decided to install the libmnl include file in a non-standard
place: /usr/include/libmnl/libmnl/libmnl.h

This was probably a mistake by the SUSE package maintainer,
but hard to get fixed. Workaround the problem by pkg-config to find
the necessary include directive for libmnl.

Fixes: 20b71e92ef8e ("net/mlx5: lay groundwork for switch offloads")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
v3 - Tested on SLES 15, needs $(shell pkg-config ...) 

 drivers/net/mlx5/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile
index 1e9c0b42ac16..8497c98ef86e 100644
--- a/drivers/net/mlx5/Makefile
+++ b/drivers/net/mlx5/Makefile
@@ -51,6 +51,7 @@ CFLAGS += -D_DEFAULT_SOURCE
 CFLAGS += -D_XOPEN_SOURCE=600
 CFLAGS += $(WERROR_FLAGS)
 CFLAGS += -Wno-strict-prototypes
+CFLAGS += $(shell pkg-config --cflags libmnl)
 ifeq ($(CONFIG_RTE_LIBRTE_MLX5_DLOPEN_DEPS),y)
 CFLAGS += -DMLX5_GLUE='"$(LIB_GLUE)"'
 CFLAGS += -DMLX5_GLUE_VERSION='"$(LIB_GLUE_VERSION)"'
@@ -59,7 +60,7 @@ LDLIBS += -ldl
 else
 LDLIBS += -libverbs -lmlx5
 endif
-LDLIBS += -lmnl
+LDLIBS += $(shell pkg-config --libs libmnl)
 LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
 LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs
 LDLIBS += -lrte_bus_pci
-- 
2.19.1

Re: [dpdk-dev] [PATCH v3] mlx5: use pkg-config to handle SUSE libmnl

[Yongseok Koh]

On Thu, Oct 25, 2018 at 01:29:38PM -0700, Stephen Hemminger wrote:
> SUSE decided to install the libmnl include file in a non-standard
> place: /usr/include/libmnl/libmnl/libmnl.h
> 
> This was probably a mistake by the SUSE package maintainer,
> but hard to get fixed. Workaround the problem by pkg-config to find
> the necessary include directive for libmnl.
> 
> Fixes: 20b71e92ef8e ("net/mlx5: lay groundwork for switch offloads")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
Acked-by: Yongseok Koh <yskoh@mellanox.com>

Thanks

> v3 - Tested on SLES 15, needs $(shell pkg-config ...) 
> 
>  drivers/net/mlx5/Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile
> index 1e9c0b42ac16..8497c98ef86e 100644
> --- a/drivers/net/mlx5/Makefile
> +++ b/drivers/net/mlx5/Makefile
> @@ -51,6 +51,7 @@ CFLAGS += -D_DEFAULT_SOURCE
>  CFLAGS += -D_XOPEN_SOURCE=600
>  CFLAGS += $(WERROR_FLAGS)
>  CFLAGS += -Wno-strict-prototypes
> +CFLAGS += $(shell pkg-config --cflags libmnl)
>  ifeq ($(CONFIG_RTE_LIBRTE_MLX5_DLOPEN_DEPS),y)
>  CFLAGS += -DMLX5_GLUE='"$(LIB_GLUE)"'
>  CFLAGS += -DMLX5_GLUE_VERSION='"$(LIB_GLUE_VERSION)"'
> @@ -59,7 +60,7 @@ LDLIBS += -ldl
>  else
>  LDLIBS += -libverbs -lmlx5
>  endif
> -LDLIBS += -lmnl
> +LDLIBS += $(shell pkg-config --libs libmnl)
>  LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
>  LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs
>  LDLIBS += -lrte_bus_pci
> -- 
> 2.19.1
> 

Re: [dpdk-dev] [PATCH v3] mlx5: use pkg-config to handle SUSE libmnl

[Shahaf Shuler]

Saturday, October 27, 2018 12:49 AM, Yongseok Koh:
> Subject: Re: [dpdk-dev] [PATCH v3] mlx5: use pkg-config to handle SUSE
> libmnl
> 
> On Thu, Oct 25, 2018 at 01:29:38PM -0700, Stephen Hemminger wrote:
> > SUSE decided to install the libmnl include file in a non-standard
> > place: /usr/include/libmnl/libmnl/libmnl.h
> >
> > This was probably a mistake by the SUSE package maintainer, but hard
> > to get fixed. Workaround the problem by pkg-config to find the
> > necessary include directive for libmnl.
> >
> > Fixes: 20b71e92ef8e ("net/mlx5: lay groundwork for switch offloads")
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> Acked-by: Yongseok Koh <yskoh@mellanox.com>

Applied to next-net-mlx, with addition of Cc:stable@dpdk.org. thanks. 


> 
> Thanks
> 
> > v3 - Tested on SLES 15, needs $(shell pkg-config ...)
> >
> >  drivers/net/mlx5/Makefile | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile
> > index 1e9c0b42ac16..8497c98ef86e 100644
> > --- a/drivers/net/mlx5/Makefile
> > +++ b/drivers/net/mlx5/Makefile
> > @@ -51,6 +51,7 @@ CFLAGS += -D_DEFAULT_SOURCE  CFLAGS +=
> > -D_XOPEN_SOURCE=600  CFLAGS += $(WERROR_FLAGS)  CFLAGS +=
> > -Wno-strict-prototypes
> > +CFLAGS += $(shell pkg-config --cflags libmnl)
> >  ifeq ($(CONFIG_RTE_LIBRTE_MLX5_DLOPEN_DEPS),y)
> >  CFLAGS += -DMLX5_GLUE='"$(LIB_GLUE)"'
> >  CFLAGS += -DMLX5_GLUE_VERSION='"$(LIB_GLUE_VERSION)"'
> > @@ -59,7 +60,7 @@ LDLIBS += -ldl
> >  else
> >  LDLIBS += -libverbs -lmlx5
> >  endif
> > -LDLIBS += -lmnl
> > +LDLIBS += $(shell pkg-config --libs libmnl)
> >  LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring  LDLIBS +=
> > -lrte_ethdev -lrte_net -lrte_kvargs  LDLIBS += -lrte_bus_pci
> > --
> > 2.19.1
> >