From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00088.outbound.protection.outlook.com [40.107.0.88]) by dpdk.org (Postfix) with ESMTP id 9A98F4F9C for ; Sun, 28 Oct 2018 13:53:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FOtpTQZ2EFYUz4t2bqOUraK7Q2FKA6m8HdmcNlkN+n4=; b=FUZE3ZFzcXjJNAxqNS20oCOCvV8UUXvaRupaa9roXjaTEPua47iKZxOifbebANt7bxfYA/rS98O3Cc0fX/6m2UUMLTfZlLYrRFvYZXDnW8NEetsP9JtlslqCJuJtDJyu71qwR0DWpRqxIStF+Rkex7Y7wNSUA0JhDAFY9GDwaY8= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4251.eurprd05.prod.outlook.com (52.134.108.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1273.26; Sun, 28 Oct 2018 12:53:42 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::80e:e6b:baf2:d973]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::80e:e6b:baf2:d973%3]) with mapi id 15.20.1273.025; Sun, 28 Oct 2018 12:53:42 +0000 From: Shahaf Shuler To: Yongseok Koh , Stephen Hemminger CC: Adrien Mazarguil , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3] mlx5: use pkg-config to handle SUSE libmnl Thread-Index: AQHUbKF/G45wBEJOsUyY5GVAlPvlzKUyEiUAgAJBoqA= Date: Sun, 28 Oct 2018 12:53:42 +0000 Message-ID: References: <20181025202938.4747-1-stephen@networkplumber.org> <20181026214852.GB13615@mtidpdk.mti.labs.mlnx> In-Reply-To: <20181026214852.GB13615@mtidpdk.mti.labs.mlnx> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4251; 6:pNegDT5cuHCF8nXk0O+V9JO0CjmKHWovaXPEUKWW9btPgzO/X76dYtgrm+7PqO7OaVLDT4zsij4X4xtP9mHo2FnoEkI9sx7lgI3sTg3F4YlhA5j9Xongd/bMeJRgyeCgP2CAge4Y6RirF1ud1/uTjMPoYlBJql50sL1FyFu7xgTIjHsyC46t1LpDfzc6bwIH8Q1O2HqiodepPy0Y1Y2vmdhNB0d5K/iIp9A3ZVE2R6cQIU0fok2e3y5s4yKUBWJJe4MnJTqGBdw/DOfRbnhMBm9y3hUQrjaoX7A//jRy5O6PRkCgohRamtdxkUvgqSsF5ctPKRWCkKkT0jC0lkwUqM3CaMlC0txeTslrM+wSjr8xlExbpGOxL2Ww8V5dYJUmsbmda82E2ymR5ovsx/mQZIdy/5Uz4ILerbM50nQJ0MIJ6x/BLTopmLbP8gAnL5tJKU3fMan1ciNQbI/E7sfCwQ==; 5:iUTlUgutguEaJGEdbidKOa1/1tYi9yS9H4ZJCtnjQtbvoNmsb+O6e56vPS8eD9ig9fCN+OZl+CQxS2ogwQNSEmDSdRj/gy3qqtfW+jkSnw7y2UsxI01Dt/UjIoppb8yhKQmEbCcEp6Z2N33tEFuvbDqLMCiUSYHHC2ZRzLIm73M=; 7:6D6XpWQ+2iBDNGspj4/s+62yz8vS+1u07Mq2HrBSMuPxsRn1Z6JobTnQOI2OOWV8vWfN5hbtbnh447E86HeoBjmMOkDHFgo4qrrWOHkIa1DD1FkPb8XDx6EMCUWnbpW7rLr+msbZXf9JcIJS2axwnw== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 26c0eda1-5cc9-43bb-5b09-08d63cd463f3 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4251; x-ms-traffictypediagnostic: DB7PR05MB4251: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231382)(944501410)(52105095)(3002001)(10201501046)(93006095)(93001095)(6055026)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123564045)(20161123558120)(201708071742011)(7699051)(76991095); SRVR:DB7PR05MB4251; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4251; x-forefront-prvs: 0839D067E7 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(346002)(366004)(376002)(136003)(199004)(189003)(71200400001)(9686003)(486006)(71190400001)(6246003)(186003)(7736002)(53936002)(305945005)(229853002)(2906002)(97736004)(4326008)(106356001)(55016002)(105586002)(476003)(6436002)(86362001)(575784001)(25786009)(33656002)(6116002)(14444005)(3846002)(68736007)(256004)(6506007)(2900100001)(316002)(110136005)(54906003)(76176011)(7696005)(11346002)(81156014)(26005)(446003)(66066001)(99286004)(478600001)(74316002)(14454004)(5250100002)(8676002)(102836004)(81166006)(5660300001)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4251; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 5UuAAqu1L1lntYsxfsvWTLbAqJ+quVeTiQzRMA8cwGxbRHVhhni4GGO8Rj5epLmkeOPLr1/zHxRecqpbxWolrY1gqB21GyKO2nDh6LApAF/oJ4T9i+1YjztziBEN1pOuOfa7ZdPkE6zgsnoxijgzWbhRmrSUINFPsmkn0EnzT4kcx5/Wl/nF3Lv6GdboV0vjqolNWl9gi2ak3f1YA6J8KVHb4jyv4li6gzdUhOk7Wc6tm0zBP/0A46CezLzUPpV7Y+XKdt2b0GHCt5V495yu35Ecc0tDqrt4VQc7VTrwxzm+KqC1nXyBm3FCZZnt354/4zWGJGMBVw/ac0DVRsNi2G+TKebAuAJEBFxBqGJ2MRc= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 26c0eda1-5cc9-43bb-5b09-08d63cd463f3 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2018 12:53:42.6209 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4251 Subject: Re: [dpdk-dev] [PATCH v3] mlx5: use pkg-config to handle SUSE libmnl X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Oct 2018 12:53:43 -0000 Saturday, October 27, 2018 12:49 AM, Yongseok Koh: > Subject: Re: [dpdk-dev] [PATCH v3] mlx5: use pkg-config to handle SUSE > libmnl >=20 > On Thu, Oct 25, 2018 at 01:29:38PM -0700, Stephen Hemminger wrote: > > SUSE decided to install the libmnl include file in a non-standard > > place: /usr/include/libmnl/libmnl/libmnl.h > > > > This was probably a mistake by the SUSE package maintainer, but hard > > to get fixed. Workaround the problem by pkg-config to find the > > necessary include directive for libmnl. > > > > Fixes: 20b71e92ef8e ("net/mlx5: lay groundwork for switch offloads") > > Signed-off-by: Stephen Hemminger > > --- > Acked-by: Yongseok Koh Applied to next-net-mlx, with addition of Cc:stable@dpdk.org. thanks.=20 >=20 > Thanks >=20 > > v3 - Tested on SLES 15, needs $(shell pkg-config ...) > > > > drivers/net/mlx5/Makefile | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile > > index 1e9c0b42ac16..8497c98ef86e 100644 > > --- a/drivers/net/mlx5/Makefile > > +++ b/drivers/net/mlx5/Makefile > > @@ -51,6 +51,7 @@ CFLAGS +=3D -D_DEFAULT_SOURCE CFLAGS +=3D > > -D_XOPEN_SOURCE=3D600 CFLAGS +=3D $(WERROR_FLAGS) CFLAGS +=3D > > -Wno-strict-prototypes > > +CFLAGS +=3D $(shell pkg-config --cflags libmnl) > > ifeq ($(CONFIG_RTE_LIBRTE_MLX5_DLOPEN_DEPS),y) > > CFLAGS +=3D -DMLX5_GLUE=3D'"$(LIB_GLUE)"' > > CFLAGS +=3D -DMLX5_GLUE_VERSION=3D'"$(LIB_GLUE_VERSION)"' > > @@ -59,7 +60,7 @@ LDLIBS +=3D -ldl > > else > > LDLIBS +=3D -libverbs -lmlx5 > > endif > > -LDLIBS +=3D -lmnl > > +LDLIBS +=3D $(shell pkg-config --libs libmnl) > > LDLIBS +=3D -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring LDLIBS +=3D > > -lrte_ethdev -lrte_net -lrte_kvargs LDLIBS +=3D -lrte_bus_pci > > -- > > 2.19.1 > >