From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0065.outbound.protection.outlook.com [104.47.1.65]) by dpdk.org (Postfix) with ESMTP id CE0542C58; Thu, 16 Aug 2018 13:57:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WDso3bZnDF9qzqc1iq3sHUGTiVBVS1QNlpjefF88yPY=; b=WF+JLck1xM1qxtsu0KFUeq/U09ANC+fGDpyf3arxlz6F5bM66dAQl29ASpxSJw8psD6ZZB9v5ldftrE+7moVVEn1+aZJtwVZL4tDtWSt47l/Va3s5MyCtbJC332x7BdeQMDwY8DRi1eKIQzTGFfZ1/IrMyRk+N4QpWJB4WQeFgw= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB5098.eurprd05.prod.outlook.com (20.176.237.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1038.19; Thu, 16 Aug 2018 11:57:02 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::c873:513b:cfb5:a3bc]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::c873:513b:cfb5:a3bc%4]) with mapi id 15.20.1059.017; Thu, 16 Aug 2018 11:57:02 +0000 From: Shahaf Shuler To: Yongseok Koh CC: "dev@dpdk.org" , Raslan Darawsheh , Erez Ferber , Ali Alnubani , Wisam Monther , Olga Shern , "stable@dpdk.org" Thread-Topic: [PATCH v2] net/mlx5: disable ConnectX-4 Lx Multi Packet Send by default Thread-Index: AQHUNLsFzPzwtbqNLUSF4mDY0F0/UaTCRung Date: Thu, 16 Aug 2018 11:57:02 +0000 Message-ID: References: <20180813070018.101262-1-shahafs@mellanox.com> <20180815121730.87525-1-shahafs@mellanox.com> <21F5BB41-E163-4D6B-8DE3-4FE9EE67E822@mellanox.com> In-Reply-To: <21F5BB41-E163-4D6B-8DE3-4FE9EE67E822@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.105] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB5098; 6:2rSNWacJB71+HzpL2XNX92RRu59oIGv/lIgsK1hjmgzF+PYZ42Gt3hxUBan3VjPAMUqkRHtdEVSl2raMzVQnjElaS5hca2rIRqsZF4i5996ZN7W26VFBSXfp61wwKjKUmXavPIpjAiRJk9Gl9qtKRksVXXculOhSvpeVl9oSvlQUnLac5TWDOCDcWMK4IZHW5kSiuEOyPcTk5Kr3RDKK5cn6FtRMCZgg3yU30jEIvJi+3idrdBdd+vSdEcL6VeFWirKQ3uhHpYsD/aQLwGFNCyMmPyX29GM3jWKEgAp848CEHL2H4LoDNKbMpL/VeqcFRy50Ve0AU/fOLqE+oTC93JVeFSeijUYnLt1r/PxYyMU5tpAjl0hl+yQoPGgtXSGqn6BLhKBcL1IeEoIlyvn6OT9RFNP8hqKc7kjcYK3Gki1Cq/RjAmtOU4FH9p8uoumTnpROoWNrMs6hMtJJdlomOA==; 5:hXEmBEgHeAtITr1d4WejKzXYKcgev70ML2dTYVKq9rhiEkS32bjBaDNwV6vl+Ux8GXTf+3fSayRsppgr7wAIqLUb9GTiOZ8x4+NW3j8mLnOJYCkdpxHguRSJOzDDp+uqg4r414RXkeDckTTee/OQa+5zEb0w+aW8FXMLrb//bks=; 7:zsK/sPUlwbY4WoWBo3Aja/Dj+XqZ+X1Bc0I+oc02U0AHKZ9vMTYjIlZ7FL8//BdtiWT7NobukrK60vY2jChzc55L/2C4nJvv9J/QbK4HQ6bIGjtLPF4mbbFWHOpv4t/fUNjKBU+VlROg16uD9lPWfCGwnk6I9YvxjQnK9QWzKT4j4WisTLc0+aOHN9eu3x60K6RwQmOohXz6cVlZVSytpJbaW0I+ajv6sq6RrIqnITcoHQapqG/o+aLNqIz06BPg x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 51b18726-b41d-44ff-eb0f-08d6036f613e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB5098; x-ms-traffictypediagnostic: DB7PR05MB5098: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(192374486261705); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(823301045)(3002001)(3231311)(944501410)(52105095)(10201501046)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(201708071742011)(7699016); SRVR:DB7PR05MB5098; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB5098; x-forefront-prvs: 07665BE9D1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(366004)(396003)(136003)(346002)(376002)(189003)(199004)(33656002)(478600001)(53936002)(74316002)(14454004)(3846002)(6116002)(54906003)(6246003)(305945005)(9686003)(446003)(11346002)(476003)(486006)(2906002)(7736002)(6862004)(316002)(8936002)(26005)(55016002)(102836004)(8676002)(81166006)(256004)(76176011)(7696005)(5250100002)(6436002)(66066001)(97736004)(81156014)(86362001)(6506007)(99286004)(53546011)(14444005)(106356001)(229853002)(4326008)(25786009)(105586002)(68736007)(450100002)(2900100001)(5660300001)(6636002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB5098; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: /a5QWVYeGyL9Uk4TPCs2ouJkf6zp6/KvYB6rUjmbSmlm/P+CeuekvkyTeJe41BbhBBWIUrnxBknga4v3tME+2Q9x8xbPnAiMsUo/1VA3uIgV8YrCEgktJGUbi0ZGYsfdmhHHfPdSAf3Wt0fG+tfL0ys3TMz86LezLJ6YYFtC37zVQiLtKctxFItl+Z/fXOG0YZfUcROTi/geCztvlxVbZqOeajj/fcO1AYyIybc8SiDu7snY3UOfXMo4wz9cFWkkLAjsGZnCXg+LrVJ/yJYKG8530g+2S3edcxKsJ4lnHlVCLCKX0bn7kBE1wZH3/6Xy9t/c7a/TdYScoJi3MzbLmiZ2k6fKWAFYBdR7g2Y/afc= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 51b18726-b41d-44ff-eb0f-08d6036f613e X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Aug 2018 11:57:02.6332 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB5098 Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: disable ConnectX-4 Lx Multi Packet Send by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Aug 2018 11:57:05 -0000 Wednesday, August 15, 2018 8:12 PM, Yongseok Koh: > Subject: Re: [PATCH v2] net/mlx5: disable ConnectX-4 Lx Multi Packet Send > by default >=20 >=20 > > On Aug 15, 2018, at 5:17 AM, Shahaf Shuler > wrote: > > > > On ConnectX-4 Lx the Multi Packet Send (MPW) feature is considered > > un-secure, as on some cases were the application provides incorrect > > mbufs on the Tx burst the host or NIC can get stuck. > > > > Hence, disabling the feature by default for this specific NIC. > > Users can still enable this feature and enjoy the performance gain > > (mostly for low number of cores) by using the txq_mpw_en devarg. > > > > This patch will impact the out of the box performance of some > > application using ConnectX-4 Lx for the sack of security and robustness= . > > > > Since we need different defaults based on the underlying device the > > mpw field in the configuration struct was extended to contain also the > > MLX5_ARG_UNSET option. > > > > Cc: stable@dpdk.org > > > > Signed-off-by: Shahaf Shuler > > --- >=20 > Acked-by: Yongseok Koh Applied to next-net-mlx, thanks.=20 >=20 > Thanks