From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80082.outbound.protection.outlook.com [40.107.8.82]) by dpdk.org (Postfix) with ESMTP id B69DA5A6E for ; Wed, 1 Aug 2018 13:58:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BhWyC4sYZpBeQOgPWozXerrVBFvEjj43DgAp+d3madE=; b=qHnuraclaUMI5mM1P7Wff8Dfe0leF11aw1D1C6ES+slNLmalrPi1++5jU7FPuGdO8Kuml88o5Hajld6w01bLRBqu+LTukENy9Pshcd0ofKtyBcIOPD3fqP8UF35cMdCAJ5lgbkJUfufGV2Ws00G/Rbww6O6b0wlsBfUKpUpu95s= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4905.eurprd05.prod.outlook.com (20.176.235.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.995.21; Wed, 1 Aug 2018 11:58:50 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::52a:650b:ae10:fc3]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::52a:650b:ae10:fc3%4]) with mapi id 15.20.1017.010; Wed, 1 Aug 2018 11:58:50 +0000 From: Shahaf Shuler To: Matan Azrad , Yongseok Koh CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix tunnel offloads Thread-Index: AQHUKXLtoRLF5/FnJEy98m2qEZLlFaSqyctw Date: Wed, 1 Aug 2018 11:58:50 +0000 Message-ID: References: <1533112658-24390-1-git-send-email-matan@mellanox.com> In-Reply-To: <1533112658-24390-1-git-send-email-matan@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4905; 6:Vaeu1lkgObsFBzZvulwJVyR1pbXPQFkFpIdKBT0JLJyylyqB/iHmbNAQjHrdiVqOAEb+MKVksVRzuyE2iWzW9t52ep8J3lBhsOio6fAThTQdE6pB67nUMQd2ru5WaYBKikMPg4hdY2NyIQZpuI2+f761YY5SAf+lpYJv+xPJuxQaUMO+3uhH2RQGck6GANaBMLT7k+F/kAMlQ/XqUzTkbrGjUxxw4tAgoXU7JsrIS+p+QZ8WL3LtyBf3W/k1rARpn1xp/yJL/7mB+SvDImclrEKiF1ghAU01cuZfj4LcCAXlqgy35z3K0OmNS3rJEX6MYdADysacxdt8uBI9boqpMJTqEe9qWVJhIJNiia2xORKzfGqiuR4uMxPCU39ZL/sdDtE3oTPmajsZXJ6Hh/VdDZxKj756BNmniyu4BF5azXmw5qvYylYbHPgU4tKoApLIsqtgPhwmluWU3A7PWpVEng==; 5:0OvbOH1OmrrOCo/O2Sn+1d1FhC7lQ4hpro4FPpmsGlCjoFhLQyvJO4C7oYQEtMGBPftnq5E6mswn471T7mhYxxJWHSHSix41wImQM63bboBigJ+FLrm1FPMzS9nKOxVdbhtWZOmB3G52g2mRC9iUDRQPu3d9KFnNoHaBaMBjQaI=; 7:kNAdsiC76k7wEVocprJFxwRcabWjX8SQxMLgh0kJgxhFGuCQftm/TClz4wdRN5FYnPXZDSri9cabNw0QW8gWiTPhP2LWGw5fNcv+nuNCNJHz73dqsPHqxMmx0BahyP45PNOu5gf4cwRC8LcmmC13UFpEvOfpjmJaNvno36uKJ299PJLrytQ42qHk4Va8ARPiZhkPWYq7JT/b/scWJPLNRsXy3k+uz6ogkZMZ9heWZqJhJoMOQJrZwlX/I/OOymcX x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 0691565c-9d61-4dc1-5459-08d5f7a6258e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4905; x-ms-traffictypediagnostic: DB7PR05MB4905: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(788757137089); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(3231311)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:DB7PR05MB4905; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4905; x-forefront-prvs: 0751474A44 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(136003)(366004)(396003)(39860400002)(189003)(199004)(256004)(4326008)(486006)(81156014)(81166006)(8676002)(6246003)(476003)(229853002)(8936002)(25786009)(6636002)(305945005)(5660300001)(14444005)(5250100002)(74316002)(446003)(11346002)(66066001)(2906002)(478600001)(7696005)(316002)(9686003)(3846002)(2900100001)(55016002)(76176011)(7736002)(6436002)(6116002)(110136005)(99286004)(14454004)(97736004)(26005)(102836004)(86362001)(53936002)(6506007)(33656002)(105586002)(106356001)(68736007); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4905; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: HILo2byVPT5QLPv6mwR0yOZrPPYd9zVw5LVEsB9tpDslJP4U1DdWLj5VJren+sTwxRafG1veGlRnlIy7QfjiUib62/xw4ijT9vYBZZMkM8nP0scPnV41HSBHv8tYJ0SabJFXDRUweA7/NzQL9VsoQFR5xjKddmgmE+xn87NZn7ac2tgTD10a2r3GLRtDj+3p/AMmi15PR+/rwcTOtUmuVzntfeukTTjw74erSSXoJphlG6Nz7d33QdmbI0MssU+7S/K6FHPGDoIJ76jraXtm/47sTRfjybwW69sbCdOpnNflySyCSGBHToP1aSsbNqUWM+R5C1pFO0QnI0WDM27aNTZXQak2P7s9IlhBs1Hl+4E= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0691565c-9d61-4dc1-5459-08d5f7a6258e X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Aug 2018 11:58:50.8468 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4905 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix tunnel offloads X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Aug 2018 11:58:53 -0000 Wednesday, August 1, 2018 11:38 AM, Matan Azrad: > Subject: [dpdk-dev] [PATCH] net/mlx5: fix tunnel offloads >=20 > There are a dedicated QP attributes, tunnel offload flag and mask, which > must be configured in order to allow part of the HW tunnel offloads. >=20 > So, if a QP is pointed by a tunnel flow, the above QP attributes should b= e > configured. >=20 > The mask configuration is wrongly only performed if an internal RSS was > configured by the user, while there is no reason to condition the tunnel > offloads in RSS configurations. >=20 > Consequently, some of the tunnel offloads was not performed by the HW > when a tunnel flow was configured, for example, the packet tunnel types > was not reported to the user. >=20 > Replace the internal RSS condition with the tunnel flow condition. >=20 > Fixes: df6afd377ace ("net/mlx5: remove useless arguments in hrxq API") >=20 > Signed-off-by: Matan Azrad Applied to next-net-mlx, thanks.=20