From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0069.outbound.protection.outlook.com [104.47.2.69]) by dpdk.org (Postfix) with ESMTP id A9E9E2862 for ; Tue, 6 Nov 2018 20:04:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=exVflQIxHp4QUAvna8791LguGttNwi3+r71q9Lu6RNs=; b=kdY7Ybd2+GlyBOEjehn0G5Hd1L211qS7x5xcQs77lyveyheSEIJSUv38crjTROlUTysI0f/Pg+E4LXev+ila7D9WQJgjt/BrtEiseIw7THNDMY4E2S9NjqnZnjQb7I0bkfLGMeO0MyLPKwUAgWjZC714SW32voXtfV6BvCqwO2s= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB5544.eurprd05.prod.outlook.com (20.177.193.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.35; Tue, 6 Nov 2018 19:04:10 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::bc22:c2f5:208d:826f]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::bc22:c2f5:208d:826f%2]) with mapi id 15.20.1294.034; Tue, 6 Nov 2018 19:04:10 +0000 From: Shahaf Shuler To: Yongseok Koh CC: "dev@dpdk.org" , Ori Kam Thread-Topic: [PATCH] net/mlx5: fix L4 protocol validation Thread-Index: AQHUdai2eFYZN/Z/w0SlJ7cJGLbLtaVDG5Eg Date: Tue, 6 Nov 2018 19:04:10 +0000 Message-ID: References: <20181106081409.26377-1-yskoh@mellanox.com> In-Reply-To: <20181106081409.26377-1-yskoh@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.105] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB5544; 6:LBFopbvaSI9zD8SlgNyRZvVLfPABlyPVcE4qSC9N59GCDbQtNuO9pS4BQbNig7wY1P/EUFhAkrAOzTvTw8Yq/LVVbAi6gONnAR2bq/NEIJtU3gmaPL5roukEcpcb+Ot7R+rabFpd5y4FfFL9RzM3BHoQw6Bh6QbRWlN5q94ttj4JkReqsbxvMC55RSRR6rhX3dJL8NLMvah5BRc1QLZP5iebOHfaive80r+F/58qTe5esfw+Cjri1ebO1FZW3bwkrssuWDYb0IqvLFQQygKUXe2cCqeH78FjC0sjLKT9oDtvg4tKjQ6EvV9zKlUmTKxwDaWCybtMVQJFABEIqV/cgFm5RtjW9I7unzXS3ByYeUrbi2nQryhBeN+6MYJbJc9TXHVCml/IW05X6CdoeDFpUNHvYtOg1m4+vO5ur8AUlyYUjhbxV0JIpJpP+et7fkUiLHqjTK3c9ElqjUkTvoCWJw==; 5:BocB8jf7EOb/EMKMmKGuVb3GNBsK83zN8C1r3ei6QDdcOVRcNnLY7CLgSO+AlRWBHeQygJ6rbpNq5aivjGdmKR9NtnqfqeYWANk1afXCTpfjtL7DfOZt+j1gGSUnJmYmzl+aJu9A5YGu6/z7jHZ14tjred/5/RWZHLtym6MjAXo=; 7:tmLKC1xfxY7H94RCY4DthRxeIrFaRu8BuXtNmQuAIMOPbnKoaL8qaIJN/b6lzI6w/CN3CcDhSLxGTo+Bxlr6xiTONwbASs5PxqpEq3Sa7ISCBA340DbbEqfZZ1ZovsZWrQYNC4bwxT3An0qu3ps4gg== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 93340bb9-6924-4b61-5b39-08d6441aa281 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB5544; x-ms-traffictypediagnostic: DB7PR05MB5544: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231382)(944501410)(52105095)(3002001)(10201501046)(93006095)(93001095)(6055026)(148016)(149066)(150057)(6041310)(20161123560045)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(201708071742011)(7699051)(76991095); SRVR:DB7PR05MB5544; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB5544; x-forefront-prvs: 0848C1A6AA x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(346002)(376002)(366004)(39860400002)(136003)(189003)(199004)(26005)(6636002)(229853002)(54906003)(7736002)(68736007)(305945005)(446003)(102836004)(7696005)(6436002)(5660300001)(86362001)(106356001)(105586002)(55016002)(3846002)(6116002)(9686003)(76176011)(316002)(97736004)(53936002)(74316002)(25786009)(478600001)(71190400001)(71200400001)(66066001)(8936002)(81166006)(6862004)(6506007)(81156014)(14444005)(186003)(2900100001)(256004)(99286004)(33656002)(14454004)(8676002)(2906002)(6246003)(486006)(4326008)(11346002)(476003)(107886003); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB5544; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: XUuxxsqlG6MGEtfUT6LKNSiPVPdwEaDBGbAn4tg7Lli/mN5uyg975/Btf9P9wBI9OioqLhJkkAQIDWh6U2+0OaYe6wGBRvEm/TU74Fd2Uvq4LmOHOqApt8nI09Ia99YkbSvS0T3+VG3G0vZfYg7B5mjQWQ2QHqEsBVEvIdRhFxT4exW5ZIEZ4j0c7UOwkQR887Kn53mvrXUm6P0iUAGHSInp7NOgznG0c8jUl/iOD50A1kS2y1aW7CXWw1Rt38E3vDnpo4IdSaP8Gh9DzAEFOOVq2PotNQz1NuMqqN7yieZEpnEEx4gCQ819PTQtyuEFB7JJ9tB5n2d/C7lpAEOjQA4PlejIk/zOortOyiXa1Bc= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 93340bb9-6924-4b61-5b39-08d6441aa281 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Nov 2018 19:04:10.4947 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB5544 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix L4 protocol validation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Nov 2018 19:04:11 -0000 Tuesday, November 6, 2018 10:14 AM, Yongseok Koh: > Subject: [PATCH] net/mlx5: fix L4 protocol validation >=20 > - Currently, no device supports partial mask for protocol in IP header. > - As there could be multiple IP items, next_protocol variable in flow > validation has to be reset for inner layer. Otherwise, inner TCP/UDP wi= ll > see protocol number of outer IP header. > - Remove redundant protocol checking for MPLS, which is done in > mlx5_flow_validate_item_mpls(). >=20 > Fixes: 3d69434113d1 ("net/mlx5: add Direct Verbs validation function") > Fixes: 23c1d42c7138 ("net/mlx5: split flow validation to dedicated functi= on") > Cc: orika@mellanox.com >=20 > Signed-off-by: Yongseok Koh Applied to next-net-mlx, thanks.=20