From: Shahaf Shuler <shahafs@mellanox.com>
To: Yongseok Koh <yskoh@mellanox.com>,
Raslan Darawsheh <rasland@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Thomas Monjalon <thomas@monjalon.net>,
Ophir Munk <ophirmu@mellanox.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 2/2] net/mlx5: fix resource leak in case of error
Date: Wed, 9 May 2018 09:50:20 +0000 [thread overview]
Message-ID: <DB7PR05MB4426C834EB377EDED4711C64C3990@DB7PR05MB4426.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1722AD8A-15A4-4D8B-992D-1CCB84EFB1AD@mellanox.com>
--Shahaf
> -----Original Message-----
> From: Yongseok Koh
> Sent: Tuesday, May 8, 2018 10:20 PM
> To: Raslan Darawsheh <rasland@mellanox.com>
> Cc: Shahaf Shuler <shahafs@mellanox.com>; dev@dpdk.org; Thomas
> Monjalon <thomas@monjalon.net>; Ophir Munk
> <ophirmu@mellanox.com>; stable@dpdk.org
> Subject: Re: [PATCH v3 2/2] net/mlx5: fix resource leak in case of error
>
>
> > On May 8, 2018, at 2:11 AM, Raslan Darawsheh <rasland@mellanox.com>
> wrote:
> >
> > If something went wrong in mlx5 pci prop the allocated eth dev will
> > cause a memory leak.
> >
> > This commit release the eth dev that was previously allocated.
Considering this patch as a temporary w.a. as there is patchset[1] which starts to address this issue from ethdev layer.
> >
> > Fixes: 771fa900b73a ("mlx5: introduce new driver for Mellanox
> > ConnectX-4 adapters")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
> >
> > ---
> Acked-by: Yongseok Koh <yskoh@mellanox.com>
>
> Thanks
[1]
http://dpdk.org/dev/patchwork/patch/39544/
next prev parent reply other threads:[~2018-05-09 9:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 9:11 [dpdk-dev] [PATCH v3 1/2] net/mlx5: fix double free on error handling Raslan Darawsheh
2018-05-08 9:11 ` [dpdk-dev] [PATCH v3 2/2] net/mlx5: fix resource leak in case of error Raslan Darawsheh
2018-05-08 19:19 ` Yongseok Koh
2018-05-09 9:50 ` Shahaf Shuler [this message]
2018-05-08 19:08 ` [dpdk-dev] [PATCH v3 1/2] net/mlx5: fix double free on error handling Yongseok Koh
2018-05-09 9:51 ` Shahaf Shuler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR05MB4426C834EB377EDED4711C64C3990@DB7PR05MB4426.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=dev@dpdk.org \
--cc=ophirmu@mellanox.com \
--cc=rasland@mellanox.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).