From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40069.outbound.protection.outlook.com [40.107.4.69]) by dpdk.org (Postfix) with ESMTP id 97BDB1B00C; Wed, 9 May 2018 11:50:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=PlBmE18KTZUOT0D4FYURpKludmr1PkiKtn81uwtTKsI=; b=uMHYKicF4IvmOxYo5g5Cl74ccNJCFYgqCJl+VvzpeuD6SKRKZ3OYQNtVgB9hVz9ghXBFWrS8oeg2zt9pMQL5niNggUsJhz09Q8QX9+f+JuhXUb6xkB75Pu5BkwHlKGFsTvID+Ln1pG1Gbn5lU4e/WpL9AvE3m33CJEtNagsXGuY= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4474.eurprd05.prod.outlook.com (52.134.109.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.755.16; Wed, 9 May 2018 09:50:20 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::f116:5be4:ba29:fed8]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::f116:5be4:ba29:fed8%13]) with mapi id 15.20.0735.018; Wed, 9 May 2018 09:50:20 +0000 From: Shahaf Shuler To: Yongseok Koh , Raslan Darawsheh CC: "dev@dpdk.org" , Thomas Monjalon , Ophir Munk , "stable@dpdk.org" Thread-Topic: [PATCH v3 2/2] net/mlx5: fix resource leak in case of error Thread-Index: AQHT5qyWM8o/s42jwEiqGFM/LjqovqQmNbSAgADy9oA= Date: Wed, 9 May 2018 09:50:20 +0000 Message-ID: References: <1525770687-22980-1-git-send-email-rasland@mellanox.com> <1525770687-22980-2-git-send-email-rasland@mellanox.com> <1722AD8A-15A4-4D8B-992D-1CCB84EFB1AD@mellanox.com> In-Reply-To: <1722AD8A-15A4-4D8B-992D-1CCB84EFB1AD@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4474; 7:BFFE1JfewyWt2ZDsXuDeqY89ujBKaO5H302relB7ypUWtW3WO3URVUCFVuKmtgnMrJVuS47PkUguoEG58taP8nOzQQdleXJKtUXVJwskdI/zGNCHUfO01fC4bsQjHQIIdKUqf5wOEe25ZZJpzIDT8TPFf/EIOcmA5pZHhHNtGveVtKmjKM4+treXuabU0QjN2JmW29etk8m8UfsayxZv3lHjE/OJIc+u0wBwspJehwLyYyNR893WwGG3snbOfu9P x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4474; x-ms-traffictypediagnostic: DB7PR05MB4474: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3231254)(944501410)(52105095)(3002001)(6055026)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011); SRVR:DB7PR05MB4474; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4474; x-forefront-prvs: 0667289FF8 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39380400002)(39860400002)(376002)(366004)(346002)(396003)(13464003)(189003)(199004)(8676002)(486006)(11346002)(446003)(476003)(966005)(5250100002)(478600001)(6636002)(6436002)(14454004)(229853002)(8936002)(33656002)(97736004)(68736007)(110136005)(86362001)(5660300001)(54906003)(3846002)(6116002)(316002)(9686003)(2900100001)(26005)(53376002)(6246003)(53936002)(7736002)(55016002)(305945005)(105586002)(106356001)(102836004)(6306002)(66066001)(81156014)(81166006)(7696005)(2906002)(76176011)(25786009)(6506007)(59450400001)(99286004)(3280700002)(74316002)(4326008)(53546011)(3660700001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4474; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 24OsYa1AvjeegMjdK7/FtzBiXY2fbSDhCzlEJ35THrHNz3c5CLqPGFdpuUji9FKyDxRwJM4akZZqflE1iCTlRMAR5EbalDwbwOKiIoKLMdWpJTVySpdAqXSuW+eEYU6SNemvuVoaAwl9fEfab1SJwBbNeoKFycbNR/oTV5s0fX0wnQN0j0ugcTXzx2MRpxfv spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 8088dcda-4a18-44ce-9de9-08d5b5924716 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8088dcda-4a18-44ce-9de9-08d5b5924716 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2018 09:50:20.4060 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4474 Subject: Re: [dpdk-dev] [PATCH v3 2/2] net/mlx5: fix resource leak in case of error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 09:50:21 -0000 --Shahaf > -----Original Message----- > From: Yongseok Koh > Sent: Tuesday, May 8, 2018 10:20 PM > To: Raslan Darawsheh > Cc: Shahaf Shuler ; dev@dpdk.org; Thomas > Monjalon ; Ophir Munk > ; stable@dpdk.org > Subject: Re: [PATCH v3 2/2] net/mlx5: fix resource leak in case of error >=20 >=20 > > On May 8, 2018, at 2:11 AM, Raslan Darawsheh > wrote: > > > > If something went wrong in mlx5 pci prop the allocated eth dev will > > cause a memory leak. > > > > This commit release the eth dev that was previously allocated. Considering this patch as a temporary w.a. as there is patchset[1] which st= arts to address this issue from ethdev layer. > > > > Fixes: 771fa900b73a ("mlx5: introduce new driver for Mellanox > > ConnectX-4 adapters") > > Cc: stable@dpdk.org > > > > Signed-off-by: Raslan Darawsheh > > > > --- > Acked-by: Yongseok Koh >=20 > Thanks [1] http://dpdk.org/dev/patchwork/patch/39544/