DPDK patches and discussions
 help / color / mirror / Atom feed
From: Shahaf Shuler <shahafs@mellanox.com>
To: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>,
	Yongseok Koh <yskoh@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: separate generic tunnel TSO from the standard one
Date: Mon, 25 Jun 2018 11:23:22 +0000	[thread overview]
Message-ID: <DB7PR05MB4426C93D11A0452FF21EDA75C34A0@DB7PR05MB4426.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20180625064057.xnebd6se6obogwn4@laranjeiro-vm.dev.6wind.com>

Monday, June 25, 2018 9:41 AM , Nélio Laranjeiro:
> Subject: Re: [PATCH] net/mlx5: separate generic tunnel TSO from the
> standard one
> 
> On Sun, Jun 24, 2018 at 09:22:26AM +0300, Shahaf Shuler wrote:
> > The generic tunnel TSO was depended in the regular one capabilities to
> > be enabled.
> >
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> > Acked-by: Yongseok Koh <yskoh@mellanox.com>
> > ---
> >  drivers/net/mlx5/mlx5_txq.c | 13 +++++++++----
> >  1 file changed, 9 insertions(+), 4 deletions(-)
> >

[...]

> > -	txq_ctrl->txq.tunnel_en = config->tunnel_en;
> > +	txq_ctrl->txq.tunnel_en = config->tunnel_en | config->swp;
> >  	txq_ctrl->txq.swp_en = ((DEV_TX_OFFLOAD_IP_TNL_TSO |
> >  				 DEV_TX_OFFLOAD_UDP_TNL_TSO |
> >  				 DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM) &
> > --
> > 2.12.0
> >
> 
> Is not it a fix?

Well, more like optimization. To be less strict on when to enable the generic tunnel TSO.
I can rephrase the title if you insist. 

> 
> Regards,
> 
> --
> Nélio Laranjeiro
> 6WIND

  reply	other threads:[~2018-06-25 11:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-24  6:22 Shahaf Shuler
2018-06-25  6:40 ` Nélio Laranjeiro
2018-06-25 11:23   ` Shahaf Shuler [this message]
2018-06-25 11:33     ` Nélio Laranjeiro
2018-06-26 10:25       ` Shahaf Shuler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB7PR05MB4426C93D11A0452FF21EDA75C34A0@DB7PR05MB4426.eurprd05.prod.outlook.com \
    --to=shahafs@mellanox.com \
    --cc=adrien.mazarguil@6wind.com \
    --cc=dev@dpdk.org \
    --cc=nelio.laranjeiro@6wind.com \
    --cc=stable@dpdk.org \
    --cc=yskoh@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).