From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70059.outbound.protection.outlook.com [40.107.7.59]) by dpdk.org (Postfix) with ESMTP id B433C5920; Mon, 25 Jun 2018 13:23:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fYVT5Fe3QWXNqVXQKMFulc1PU7NaWROmg/p89ce7oJE=; b=TqcQ95ZOayBNvJSKmrJRNZ8dM4DLstYb+x+PLDYlzoMOFJhzn4z7lzHBsLDhpHvBDdCHvgkPBvE/BuHcToVYgG75NOOd+FUgRKTbk00ey14IxXNH97M/jUG1bZDhn10TWRCecygJqubcX5LM5+sbfv7bcurzCxmqoeJN7DGxosE= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4138.eurprd05.prod.outlook.com (52.134.107.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.884.24; Mon, 25 Jun 2018 11:23:22 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::4c94:2db9:b8c5:cc6b]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::4c94:2db9:b8c5:cc6b%5]) with mapi id 15.20.0884.024; Mon, 25 Jun 2018 11:23:22 +0000 From: Shahaf Shuler To: =?iso-8859-1?Q?N=E9lio_Laranjeiro?= CC: Adrien Mazarguil , Yongseok Koh , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: separate generic tunnel TSO from the standard one Thread-Index: AQHUDE9toPggSdQZvUmH34A2BgfWa6Rw1NdQ Date: Mon, 25 Jun 2018 11:23:22 +0000 Message-ID: References: <20180624062226.11507-1-shahafs@mellanox.com> <20180625064057.xnebd6se6obogwn4@laranjeiro-vm.dev.6wind.com> In-Reply-To: <20180625064057.xnebd6se6obogwn4@laranjeiro-vm.dev.6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.105] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4138; 7:U0hVtSQ9OrhqTndjxXvVjjRUEnpU9S/a2O+yaqQdmiZyID8QxREBJQDSWKX7aGQ94zMFMPhPs/kq6dENd0+AxAocCVE3KhGGnP3ZKxTS3lOmIg17ZLDy5G+ujnVrkZxdHLvG5/VWMOBUUvHgfMExtlpibHaoU5EWUsJQKAtAxEmZbsSbBiIqTsivxcGXeFhxnESYH0ljnL79iWylExGaTspcD3yJ68d1YwMuXwd5oRoYu0hlCFQmXCGa16yJuuHP x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 281203ed-c6d7-4b5b-f89d-08d5da8e0f80 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600026)(711020)(48565401081)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4138; x-ms-traffictypediagnostic: DB7PR05MB4138: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:DB7PR05MB4138; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4138; x-forefront-prvs: 0714841678 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(366004)(39860400002)(39380400002)(396003)(189003)(199004)(4326008)(6436002)(55016002)(33656002)(6246003)(2900100001)(53936002)(229853002)(2906002)(3280700002)(3660700001)(8676002)(6506007)(7736002)(74316002)(6916009)(76176011)(305945005)(7696005)(102836004)(316002)(8936002)(81166006)(97736004)(5250100002)(81156014)(99286004)(54906003)(66066001)(26005)(186003)(446003)(11346002)(476003)(478600001)(9686003)(25786009)(105586002)(106356001)(3846002)(6116002)(486006)(5660300001)(14454004)(68736007)(86362001)(41533002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4138; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: x9sLFsky0aVuHw1BPVgplmf3K8+Q2z2yKAu7KL28iz0XajNtdgnFxOnYarNZobQur8L+yIEW4W794RiIwtVMnWPmlGvqSuU3L7Z8np6qD78724PwQ8/vOC2GMntlNTV1STPeAVL1KSyi1WFdqxsEnfo0bxk2bXKx2SwwoigmolsL3oJz8G1tq27zzCZ+xwh+jPWFVvLcjGXsar9NXexYwQwfZwqEfIZy1/9lyq4uOVrhUjFiLdxSKi1ftPwdHeaDunmDO3g8DRNaiIMXPYVWt7GcGwoTNYA098O5CJluWvbRhjHgnP58MfQ4vmxHGOJ6PXndnRKaoYEegLPbtnLyVszsdYACPICWbu5YqY4qe2o= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 281203ed-c6d7-4b5b-f89d-08d5da8e0f80 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jun 2018 11:23:22.2254 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4138 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: separate generic tunnel TSO from the standard one X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jun 2018 11:23:24 -0000 Monday, June 25, 2018 9:41 AM , N=E9lio Laranjeiro: > Subject: Re: [PATCH] net/mlx5: separate generic tunnel TSO from the > standard one >=20 > On Sun, Jun 24, 2018 at 09:22:26AM +0300, Shahaf Shuler wrote: > > The generic tunnel TSO was depended in the regular one capabilities to > > be enabled. > > > > Cc: stable@dpdk.org > > > > Signed-off-by: Shahaf Shuler > > Acked-by: Yongseok Koh > > --- > > drivers/net/mlx5/mlx5_txq.c | 13 +++++++++---- > > 1 file changed, 9 insertions(+), 4 deletions(-) > > [...] > > - txq_ctrl->txq.tunnel_en =3D config->tunnel_en; > > + txq_ctrl->txq.tunnel_en =3D config->tunnel_en | config->swp; > > txq_ctrl->txq.swp_en =3D ((DEV_TX_OFFLOAD_IP_TNL_TSO | > > DEV_TX_OFFLOAD_UDP_TNL_TSO | > > DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM) & > > -- > > 2.12.0 > > >=20 > Is not it a fix? Well, more like optimization. To be less strict on when to enable the gener= ic tunnel TSO. I can rephrase the title if you insist.=20 >=20 > Regards, >=20 > -- > N=E9lio Laranjeiro > 6WIND